unistack-org/cloudinit
4
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

fix(initialize): don't quote version or ID

Browse Source 
The update_engine parsing and XML generation code is very naive. Instead
of trying to implement a correct parser and generater in C++ just
generate a file that doesn't have quote's around fields that we know
won't have spaces.
This commit is contained in:
Brandon Philips 2014-04-07 09:56:57 -07:00
parent 34aa147ebe
commit 7015338aef
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
initialize/oem.go
View File

@ -18,9 +18,9 @@ type OEMRelease struct {
func (oem *OEMRelease) String() string { func (oem *OEMRelease) String() string {
fields := []string{ fields := []string{
fmt.Sprintf("ID=%q", oem.ID), fmt.Sprintf("ID=%s", oem.ID),
fmt.Sprintf("VERSION_ID=%s", oem.VersionID),
fmt.Sprintf("NAME=%q", oem.Name), fmt.Sprintf("NAME=%q", oem.Name),
fmt.Sprintf("VERSION_ID=%q", oem.VersionID),
fmt.Sprintf("HOME_URL=%q", oem.HomeURL), fmt.Sprintf("HOME_URL=%q", oem.HomeURL),
fmt.Sprintf("BUG_REPORT_URL=%q", oem.BugReportURL), fmt.Sprintf("BUG_REPORT_URL=%q", oem.BugReportURL),
} }

4
initialize/oem_test.go
View File

@ -42,9 +42,9 @@ func TestOEMReleaseWrittenToDisk(t *testing.T) {
t.Fatalf("Unable to read expected file: %v", err) t.Fatalf("Unable to read expected file: %v", err)
} }
expect := `ID="rackspace" expect := `ID=rackspace
VERSION_ID=168.0.0
NAME="Rackspace Cloud Servers" NAME="Rackspace Cloud Servers"
VERSION_ID="168.0.0"
HOME_URL="https://www.rackspace.com/cloud/servers/" HOME_URL="https://www.rackspace.com/cloud/servers/"
BUG_REPORT_URL="https://github.com/coreos/coreos-overlay" BUG_REPORT_URL="https://github.com/coreos/coreos-overlay"
` `