From 4603ca308d153476609ce84e2d82b1d423ae89ee Mon Sep 17 00:00:00 2001 From: Charlie Drage Date: Wed, 31 Aug 2016 13:34:49 -0400 Subject: [PATCH 1/2] Add note to constants Adds a small note to the constants.go file for creating a new api call within libvirt.go --- internal/constants/constants.go | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/internal/constants/constants.go b/internal/constants/constants.go index de7e1af..1f89ae5 100644 --- a/internal/constants/constants.go +++ b/internal/constants/constants.go @@ -15,8 +15,7 @@ // Package constants provides shared data for the libvirt package. package constants -// magic program numbers -// see: https://libvirt.org/git/?p=libvirt.git;a=blob_plain;f=src/remote/remote_protocol.x;hb=HEAD +// protocol procedure numbers const ( ProgramVersion = 1 ProgramRemote = 0x20008086 @@ -25,6 +24,17 @@ const ( ) // libvirt procedure identifiers +// These are libvirt procedure numbers which correspond to each respective +// API call between remote_internal driver and libvirtd. Although stable. +// Each call is identified by a unique number which *may change at any time*. +// +// Examples: +// REMOTE_PROC_CONNECT_OPEN = 1 +// REMOTE_PROC_DOMAIN_DEFINE_XML = 11 +// REMOTE_PROC_DOMAIN_MIGRATE_SET_MAX_SPEED = 207, +// +// See: +// https://libvirt.org/git/?p=libvirt.git;a=blob_plain;f=src/remote/remote_protocol.x;hb=HEAD const ( ProcConnectOpen = 1 ProcConnectClose = 2 From 22e7211e58cd267a70542bf6bc76803d28e8b4d5 Mon Sep 17 00:00:00 2001 From: Charlie Drage Date: Wed, 31 Aug 2016 16:30:00 -0400 Subject: [PATCH 2/2] Add cdrage to authors --- AUTHORS | 1 + 1 file changed, 1 insertion(+) diff --git a/AUTHORS b/AUTHORS index 101e8fd..dd3b999 100644 --- a/AUTHORS +++ b/AUTHORS @@ -11,3 +11,4 @@ Contributors ------------ Justin Kim Ricky Medina +Charlie Drage