fixes response overwrite bug
This fixes a bug in truncated response payload handling. Payloads requiring more than one call to `Read()` were overwiting the previous Read()'s buffer contents. Because we know the response payload size, we can simply call `io.ReadAll()` rather than looping over calls to `Read()`.
This commit is contained in:
parent
d57bbc34c4
commit
e99de2e999
12
rpc.go
12
rpc.go
@ -195,14 +195,10 @@ func (l *Libvirt) listen() {
|
||||
// payload: packet length minus what was previously read
|
||||
size := int(length) - (constants.PacketLengthSize + constants.HeaderSize)
|
||||
buf := make([]byte, size)
|
||||
for n := 0; n < size; {
|
||||
nn, err := l.r.Read(buf)
|
||||
if err != nil {
|
||||
// invalid packet
|
||||
continue
|
||||
}
|
||||
|
||||
n += nn
|
||||
_, err = io.ReadFull(l.r, buf)
|
||||
if err != nil {
|
||||
// invalid packet
|
||||
continue
|
||||
}
|
||||
|
||||
// route response to caller
|
||||
|
Loading…
Reference in New Issue
Block a user