Review comments

internal/lvgen/constants.tmpl

@@ -4,10 +4,10 @@
  * To regenerate, run 'go generate' in internal/lvgen.
  */
 
+// Package constants contains libvirt procedure identifiers and other enums and
+// constants.
 package constants
 
-// libvirt procedure identifiers and other enums
-//
 // These are libvirt procedure numbers which correspond to each respective
 // API call between remote_internal driver and libvirtd. Each procedure is
 // identified by a unique number which *may change in any future libvirt

internal/lvgen/gen/main.go

@@ -17,7 +17,7 @@ package main
 import (
 	"fmt"
 	"os"
-	"path"
+	"path/filepath"
 
 	"github.com/digitalocean/go-libvirt/internal/lvgen"
 )
@@ -30,7 +30,7 @@ func main() {
 		fmt.Println("set $LIBVIRT_SOURCE to point to the root of the libvirt sources and retry")
 		os.Exit(1)
 	}
-	lvFile := path.Join(lvPath, protoPath)
+	lvFile := filepath.Join(lvPath, protoPath)
 	rdr, err := os.Open(lvFile)
 	if err != nil {
 		fmt.Printf("failed to open protocol file at %v: %v\n", lvFile, err)

internal/lvgen/lv-gen.go

@@ -1,9 +1,8 @@
-package lvgen
-
-// This file contains the instructions for regenerating the libvirt bindings.
-// We do this by parsing the remote_protocol.x file included in the libvirt
-// sources. Bindings will be generated if you run `go generate` in this
+// Package lvgen contains the instructions for regenerating the libvirt
+// bindings. We do this by parsing the remote_protocol.x file included in the
+// libvirt sources. Bindings will be generated if you run `go generate` in this
 // directory.
+package lvgen
 
 // Before running `go generate`:
 // 1) Make sure goyacc is installed from golang.org/x/tools (you can use this

internal/lvgen/lvlexer.go

@@ -124,7 +124,6 @@ func (l *Lexer) Lex(st *yySymType) int {
 	s := <-l.items
 	l.lastItem = s
 	st.val = s.val
-	// fmt.Println("Lex returning", s)
 	return int(s.typ)
 }