unistack-org/metrics
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

set.go: fix data race in Set.ListMetricNames when accessing Set.m map

Browse Source 
The Set.m map can be updated by concurrent goroutines when ListMetricNames is called
This commit is contained in:
Aliaksandr Valialkin 2021-11-01 14:51:25 +02:00
parent 2ec4485cad
commit 0ee99fd214
No known key found for this signature in database
GPG Key ID: A72BEC6CD3D0DED1
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
set.go
View File

@ -511,6 +511,8 @@ func (s *Set) UnregisterMetric(name string) bool {
// ListMetricNames returns a list of all the metrics in s. // ListMetricNames returns a list of all the metrics in s.
func (s *Set) ListMetricNames() []string { func (s *Set) ListMetricNames() []string {
s.mu.Lock()
defer s.mu.Unlock()
var list []string var list []string
for name := range s.m { for name := range s.m {
list = append(list, name) list = append(list, name)