unistack-org/metrics
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Move bucket index calculations to the place where they are used

Browse Source 
This can help https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1096
This commit is contained in:
Aliaksandr Valialkin 2021-02-28 17:39:11 +02:00
parent 5523b934ae
commit 16e4558792
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
histogram.go
View File

@ -86,14 +86,6 @@ func (h *Histogram) Update(v float64) {
return return
} }
bucketIdx := (math.Log10(v) - e10Min) * bucketsPerDecimal bucketIdx := (math.Log10(v) - e10Min) * bucketsPerDecimal
idx := uint(bucketIdx)
if bucketIdx == float64(idx) {
// Edge case for 10^n values, which must go to the lower bucket
// according to Prometheus logic for `le`-based histograms.
idx--
}
decimalBucketIdx := idx / bucketsPerDecimal
offset := idx % bucketsPerDecimal
h.mu.Lock() h.mu.Lock()
h.sum += v h.sum += v
if bucketIdx < 0 { if bucketIdx < 0 {
@ -101,6 +93,14 @@ func (h *Histogram) Update(v float64) {
} else if bucketIdx >= bucketsCount { } else if bucketIdx >= bucketsCount {
h.upper++ h.upper++
} else { } else {
idx := uint(bucketIdx)
if bucketIdx == float64(idx) {
// Edge case for 10^n values, which must go to the lower bucket
// according to Prometheus logic for `le`-based histograms.
idx--
}
decimalBucketIdx := idx / bucketsPerDecimal
offset := idx % bucketsPerDecimal
db := h.decimalBuckets[decimalBucketIdx] db := h.decimalBuckets[decimalBucketIdx]
if db == nil { if db == nil {
var b [bucketsPerDecimal]uint64 var b [bucketsPerDecimal]uint64