Compare commits

...

6 Commits

Author SHA1 Message Date
7a29f49751 pass errors from broker to subscribers
Some checks failed
test / test (push) Failing after 16m47s
coverage / build (push) Failing after 16m59s
sync / sync (push) Successful in 8s
Signed-off-by: Vasiliy Tolstov <v.tolstov@unistack.org>
2025-12-02 17:19:18 +03:00
9dcdef57f4 update deps
Some checks failed
coverage / build (push) Failing after 3m2s
test / test (push) Failing after 17m57s
sync / sync (push) Successful in 9s
Signed-off-by: Vasiliy Tolstov <v.tolstov@unistack.org>
2025-10-26 13:45:44 +03:00
f8a115595b update
All checks were successful
sync / sync (push) Successful in 2m3s
Signed-off-by: Vasiliy Tolstov <v.tolstov@unistack.org>
2025-10-24 13:02:17 +03:00
vtolstov
52ea1ef8c0 Apply Code Coverage Badge 2025-10-09 20:23:55 +00:00
ffd10d7ea9 add ExposeLag option, to be able to disable lag exporting
Some checks failed
coverage / build (push) Successful in 4m20s
test / test (push) Failing after 16m7s
Signed-off-by: Vasiliy Tolstov <v.tolstov@unistack.org>
2025-10-09 23:20:10 +03:00
vtolstov
c4f8de4aca Apply Code Coverage Badge 2025-07-15 13:02:27 +00:00
10 changed files with 324 additions and 106 deletions

View File

@@ -25,7 +25,7 @@ jobs:
dst_hash=$(git ls-remote ${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY} refs/heads/master | cut -f1) dst_hash=$(git ls-remote ${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY} refs/heads/master | cut -f1)
echo "src_hash=$src_hash" echo "src_hash=$src_hash"
echo "dst_hash=$dst_hash" echo "dst_hash=$dst_hash"
if [ "$src_hash" != "$dst_hash" ]; then if [ "$src_hash" != "$dst_hash" -a "$src_hash" != "" -a "" != "$dst_hash" ]; then
echo "sync_needed=true" >> $GITHUB_OUTPUT echo "sync_needed=true" >> $GITHUB_OUTPUT
else else
echo "sync_needed=false" >> $GITHUB_OUTPUT echo "sync_needed=false" >> $GITHUB_OUTPUT

View File

@@ -1,2 +1,2 @@
# micro-broker-kgo # micro-broker-kgo
![Coverage](https://img.shields.io/badge/Coverage-63.1%25-yellow) ![Coverage](https://img.shields.io/badge/Coverage-64.8%25-yellow)

22
go.mod
View File

@@ -1,27 +1,27 @@
module go.unistack.org/micro-broker-kgo/v4 module go.unistack.org/micro-broker-kgo/v4
go 1.23.8 go 1.24.0
require ( require (
github.com/stretchr/testify v1.10.0 github.com/stretchr/testify v1.11.1
github.com/twmb/franz-go v1.19.5 github.com/twmb/franz-go v1.20.2
github.com/twmb/franz-go/pkg/kadm v1.16.0 github.com/twmb/franz-go/pkg/kadm v1.17.1
github.com/twmb/franz-go/pkg/kfake v0.0.0-20250508175730-72e1646135e3 github.com/twmb/franz-go/pkg/kfake v0.0.0-20250508175730-72e1646135e3
github.com/twmb/franz-go/pkg/kmsg v1.11.2 github.com/twmb/franz-go/pkg/kmsg v1.12.0
go.opentelemetry.io/otel v1.36.0 go.opentelemetry.io/otel v1.38.0
go.unistack.org/micro/v4 v4.1.17 go.unistack.org/micro/v4 v4.1.24
) )
require ( require (
github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc // indirect github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc // indirect
github.com/google/uuid v1.6.0 // indirect github.com/google/uuid v1.6.0 // indirect
github.com/klauspost/compress v1.18.0 // indirect github.com/klauspost/compress v1.18.1 // indirect
github.com/matoous/go-nanoid v1.5.1 // indirect github.com/matoous/go-nanoid v1.5.1 // indirect
github.com/pierrec/lz4/v4 v4.1.22 // indirect github.com/pierrec/lz4/v4 v4.1.22 // indirect
github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 // indirect github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 // indirect
github.com/spf13/cast v1.9.2 // indirect github.com/spf13/cast v1.10.0 // indirect
go.unistack.org/micro-proto/v4 v4.1.0 // indirect go.unistack.org/micro-proto/v4 v4.1.0 // indirect
golang.org/x/crypto v0.39.0 // indirect golang.org/x/crypto v0.43.0 // indirect
google.golang.org/protobuf v1.36.6 // indirect google.golang.org/protobuf v1.36.10 // indirect
gopkg.in/yaml.v3 v3.0.1 // indirect gopkg.in/yaml.v3 v3.0.1 // indirect
) )

38
go.sum
View File

@@ -8,6 +8,8 @@ github.com/google/uuid v1.6.0 h1:NIvaJDMOsjHA8n1jAhLSgzrAzy1Hgr+hNrb57e+94F0=
github.com/google/uuid v1.6.0/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo= github.com/google/uuid v1.6.0/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
github.com/klauspost/compress v1.18.0 h1:c/Cqfb0r+Yi+JtIEq73FWXVkRonBlf0CRNYc8Zttxdo= github.com/klauspost/compress v1.18.0 h1:c/Cqfb0r+Yi+JtIEq73FWXVkRonBlf0CRNYc8Zttxdo=
github.com/klauspost/compress v1.18.0/go.mod h1:2Pp+KzxcywXVXMr50+X0Q/Lsb43OQHYWRCY2AiWywWQ= github.com/klauspost/compress v1.18.0/go.mod h1:2Pp+KzxcywXVXMr50+X0Q/Lsb43OQHYWRCY2AiWywWQ=
github.com/klauspost/compress v1.18.1 h1:bcSGx7UbpBqMChDtsF28Lw6v/G94LPrrbMbdC3JH2co=
github.com/klauspost/compress v1.18.1/go.mod h1:ZQFFVG+MdnR0P+l6wpXgIL4NTtwiKIdBnrBd8Nrxr+0=
github.com/kr/pretty v0.3.1 h1:flRD4NNwYAUpkphVc1HcthR4KEIFJ65n8Mw5qdRn3LE= github.com/kr/pretty v0.3.1 h1:flRD4NNwYAUpkphVc1HcthR4KEIFJ65n8Mw5qdRn3LE=
github.com/kr/pretty v0.3.1/go.mod h1:hoEshYVHaxMs3cyo3Yncou5ZscifuDolrwPKZanG3xk= github.com/kr/pretty v0.3.1/go.mod h1:hoEshYVHaxMs3cyo3Yncou5ZscifuDolrwPKZanG3xk=
github.com/kr/text v0.2.0 h1:5Nx0Ya0ZqY2ygV366QzturHI13Jq95ApcVaJBhpS+AY= github.com/kr/text v0.2.0 h1:5Nx0Ya0ZqY2ygV366QzturHI13Jq95ApcVaJBhpS+AY=
@@ -20,28 +22,36 @@ github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 h1:Jamvg5psRI
github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4= github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
github.com/rogpeppe/go-internal v1.13.1 h1:KvO1DLK/DRN07sQ1LQKScxyZJuNnedQ5/wKSR38lUII= github.com/rogpeppe/go-internal v1.13.1 h1:KvO1DLK/DRN07sQ1LQKScxyZJuNnedQ5/wKSR38lUII=
github.com/rogpeppe/go-internal v1.13.1/go.mod h1:uMEvuHeurkdAXX61udpOXGD/AzZDWNMNyH2VO9fmH0o= github.com/rogpeppe/go-internal v1.13.1/go.mod h1:uMEvuHeurkdAXX61udpOXGD/AzZDWNMNyH2VO9fmH0o=
github.com/spf13/cast v1.9.2 h1:SsGfm7M8QOFtEzumm7UZrZdLLquNdzFYfIbEXntcFbE= github.com/spf13/cast v1.10.0 h1:h2x0u2shc1QuLHfxi+cTJvs30+ZAHOGRic8uyGTDWxY=
github.com/spf13/cast v1.9.2/go.mod h1:jNfB8QC9IA6ZuY2ZjDp0KtFO2LZZlg4S/7bzP6qqeHo= github.com/spf13/cast v1.10.0/go.mod h1:jNfB8QC9IA6ZuY2ZjDp0KtFO2LZZlg4S/7bzP6qqeHo=
github.com/stretchr/testify v1.10.0 h1:Xv5erBjTwe/5IxqUQTdXv5kgmIvbHo3QQyRwhJsOfJA= github.com/stretchr/testify v1.11.1 h1:7s2iGBzp5EwR7/aIZr8ao5+dra3wiQyKjjFuvgVKu7U=
github.com/stretchr/testify v1.10.0/go.mod h1:r2ic/lqez/lEtzL7wO/rwa5dbSLXVDPFyf8C91i36aY= github.com/stretchr/testify v1.11.1/go.mod h1:wZwfW3scLgRK+23gO65QZefKpKQRnfz6sD981Nm4B6U=
github.com/twmb/franz-go v1.19.5 h1:W7+o8D0RsQsedqib71OVlLeZ0zI6CbFra7yTYhZTs5Y= github.com/twmb/franz-go v1.19.5 h1:W7+o8D0RsQsedqib71OVlLeZ0zI6CbFra7yTYhZTs5Y=
github.com/twmb/franz-go v1.19.5/go.mod h1:4kFJ5tmbbl7asgwAGVuyG1ZMx0NNpYk7EqflvWfPCpM= github.com/twmb/franz-go v1.19.5/go.mod h1:4kFJ5tmbbl7asgwAGVuyG1ZMx0NNpYk7EqflvWfPCpM=
github.com/twmb/franz-go/pkg/kadm v1.16.0 h1:STMs1t5lYR5mR974PSiwNzE5TvsosByTp+rKXLOhAjE= github.com/twmb/franz-go v1.20.2 h1:CiwhyKZHW6vqSHJkh+RTxFAJkio0jBjM/JQhx/HZ72A=
github.com/twmb/franz-go/pkg/kadm v1.16.0/go.mod h1:MUdcUtnf9ph4SFBLLA/XxE29rvLhWYLM9Ygb8dfSCvw= github.com/twmb/franz-go v1.20.2/go.mod h1:YCnepDd4gl6vdzG03I5Wa57RnCTIC6DVEyMpDX/J8UA=
github.com/twmb/franz-go/pkg/kadm v1.16.1 h1:IEkrhTljgLHJ0/hT/InhXGjPdmWfFvxp7o/MR7vJ8cw=
github.com/twmb/franz-go/pkg/kadm v1.16.1/go.mod h1:Ue/ye1cc9ipsQFg7udFbbGiFNzQMqiH73fGC2y0rwyc=
github.com/twmb/franz-go/pkg/kadm v1.17.1 h1:Bt02Y/RLgnFO2NP2HVP1kd2TFtGRiJZx+fSArjZDtpw=
github.com/twmb/franz-go/pkg/kadm v1.17.1/go.mod h1:s4duQmrDbloVW9QTMXhs6mViTepze7JLG43xwPcAeTg=
github.com/twmb/franz-go/pkg/kfake v0.0.0-20250508175730-72e1646135e3 h1:p24opKWPySAy8xSl8NqRgOv7Q+bX7kdrQirBVRJzQfo= github.com/twmb/franz-go/pkg/kfake v0.0.0-20250508175730-72e1646135e3 h1:p24opKWPySAy8xSl8NqRgOv7Q+bX7kdrQirBVRJzQfo=
github.com/twmb/franz-go/pkg/kfake v0.0.0-20250508175730-72e1646135e3/go.mod h1:7uQs3Ae6HkWT1Y9elMbqtAcNFCI0y6+iS+Phw49L49U= github.com/twmb/franz-go/pkg/kfake v0.0.0-20250508175730-72e1646135e3/go.mod h1:7uQs3Ae6HkWT1Y9elMbqtAcNFCI0y6+iS+Phw49L49U=
github.com/twmb/franz-go/pkg/kmsg v1.11.2 h1:hIw75FpwcAjgeyfIGFqivAvwC5uNIOWRGvQgZhH4mhg= github.com/twmb/franz-go/pkg/kmsg v1.11.2 h1:hIw75FpwcAjgeyfIGFqivAvwC5uNIOWRGvQgZhH4mhg=
github.com/twmb/franz-go/pkg/kmsg v1.11.2/go.mod h1:CFfkkLysDNmukPYhGzuUcDtf46gQSqCZHMW1T4Z+wDE= github.com/twmb/franz-go/pkg/kmsg v1.11.2/go.mod h1:CFfkkLysDNmukPYhGzuUcDtf46gQSqCZHMW1T4Z+wDE=
go.opentelemetry.io/otel v1.36.0 h1:UumtzIklRBY6cI/lllNZlALOF5nNIzJVb16APdvgTXg= github.com/twmb/franz-go/pkg/kmsg v1.12.0 h1:CbatD7ers1KzDNgJqPbKOq0Bz/WLBdsTH75wgzeVaPc=
go.opentelemetry.io/otel v1.36.0/go.mod h1:/TcFMXYjyRNh8khOAO9ybYkqaDBb/70aVwkNML4pP8E= github.com/twmb/franz-go/pkg/kmsg v1.12.0/go.mod h1:+DPt4NC8RmI6hqb8G09+3giKObE6uD2Eya6CfqBpeJY=
go.opentelemetry.io/otel v1.38.0 h1:RkfdswUDRimDg0m2Az18RKOsnI8UDzppJAtj01/Ymk8=
go.opentelemetry.io/otel v1.38.0/go.mod h1:zcmtmQ1+YmQM9wrNsTGV/q/uyusom3P8RxwExxkZhjM=
go.unistack.org/micro-proto/v4 v4.1.0 h1:qPwL2n/oqh9RE3RTTDgt28XK3QzV597VugQPaw9lKUk= go.unistack.org/micro-proto/v4 v4.1.0 h1:qPwL2n/oqh9RE3RTTDgt28XK3QzV597VugQPaw9lKUk=
go.unistack.org/micro-proto/v4 v4.1.0/go.mod h1:ArmK7o+uFvxSY3dbJhKBBX4Pm1rhWdLEFf3LxBrMtec= go.unistack.org/micro-proto/v4 v4.1.0/go.mod h1:ArmK7o+uFvxSY3dbJhKBBX4Pm1rhWdLEFf3LxBrMtec=
go.unistack.org/micro/v4 v4.1.17 h1:26QDtRSYVpozYuassyvLP4sEQRo3dxgD3sVILRXmIPo= go.unistack.org/micro/v4 v4.1.21 h1:F9PrbI1BhXSDS0FopwcO5wWrT2Xh38w9VhVZZBHjfg8=
go.unistack.org/micro/v4 v4.1.17/go.mod h1:xleO2M5Yxh4s6I+RUcLrEpUjobefh+71ctrdIfn7TUs= go.unistack.org/micro/v4 v4.1.21/go.mod h1:nlBXTbx0rQrSZX4HPp2m57PHmpuGPWUd0O+jpUIiPto=
golang.org/x/crypto v0.39.0 h1:SHs+kF4LP+f+p14esP5jAoDpHU8Gu/v9lFRK6IT5imM= go.unistack.org/micro/v4 v4.1.24 h1:PbkSWJS3ssB5A0y0tOdOw6u9e2Mk4yombF4yR0Jshvo=
golang.org/x/crypto v0.39.0/go.mod h1:L+Xg3Wf6HoL4Bn4238Z6ft6KfEpN0tJGo53AAPC632U= go.unistack.org/micro/v4 v4.1.24/go.mod h1:nlBXTbx0rQrSZX4HPp2m57PHmpuGPWUd0O+jpUIiPto=
google.golang.org/protobuf v1.36.6 h1:z1NpPI8ku2WgiWnf+t9wTPsn6eP1L7ksHUlkfLvd9xY= golang.org/x/crypto v0.43.0 h1:dduJYIi3A3KOfdGOHX8AVZ/jGiyPa3IbBozJ5kNuE04=
google.golang.org/protobuf v1.36.6/go.mod h1:jduwjTPXsFjZGTmRluh+L6NjiWu7pchiJ2/5YcXBHnY= golang.org/x/crypto v0.43.0/go.mod h1:BFbav4mRNlXJL4wNeejLpWxB7wMbc79PdRGhWKncxR0=
google.golang.org/protobuf v1.36.10 h1:AYd7cD/uASjIL6Q9LiTjz8JLcrh/88q5UObnmY3aOOE=
google.golang.org/protobuf v1.36.10/go.mod h1:HTf+CrKn2C3g5S8VImy6tdcUvCska2kB7j23XfzDpco=
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0= gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c h1:Hei/4ADfdWqJk1ZMxUNpqntNwaWcugrBjAiHlqqRiVk= gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c h1:Hei/4ADfdWqJk1ZMxUNpqntNwaWcugrBjAiHlqqRiVk=
gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c/go.mod h1:JHkPIbrfpd72SG/EVd6muEfDQjcINNoR0C8j2r3qZ4Q= gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c/go.mod h1:JHkPIbrfpd72SG/EVd6muEfDQjcINNoR0C8j2r3qZ4Q=

View File

@@ -17,12 +17,12 @@ type hookEvent struct {
} }
var ( var (
_ kgo.HookBrokerConnect = &hookEvent{} _ kgo.HookBrokerConnect = (*hookEvent)(nil)
_ kgo.HookBrokerDisconnect = &hookEvent{} _ kgo.HookBrokerDisconnect = (*hookEvent)(nil)
_ kgo.HookBrokerRead = &hookEvent{} _ kgo.HookBrokerRead = (*hookEvent)(nil)
_ kgo.HookBrokerWrite = &hookEvent{} _ kgo.HookBrokerWrite = (*hookEvent)(nil)
_ kgo.HookGroupManageError = &hookEvent{} _ kgo.HookGroupManageError = (*hookEvent)(nil)
_ kgo.HookProduceRecordUnbuffered = &hookEvent{} _ kgo.HookProduceRecordUnbuffered = (*hookEvent)(nil)
) )
func (m *hookEvent) OnGroupManageError(err error) { func (m *hookEvent) OnGroupManageError(err error) {

79
kgo.go
View File

@@ -6,11 +6,13 @@ import (
"errors" "errors"
"fmt" "fmt"
"math/rand/v2" "math/rand/v2"
"strconv"
"strings" "strings"
"sync" "sync"
"sync/atomic" "sync/atomic"
"time" "time"
"github.com/twmb/franz-go/pkg/kadm"
"github.com/twmb/franz-go/pkg/kgo" "github.com/twmb/franz-go/pkg/kgo"
"github.com/twmb/franz-go/pkg/kmsg" "github.com/twmb/franz-go/pkg/kmsg"
"go.unistack.org/micro/v4/broker" "go.unistack.org/micro/v4/broker"
@@ -110,6 +112,7 @@ type kgoMessage struct {
hdr metadata.Metadata hdr metadata.Metadata
opts broker.MessageOptions opts broker.MessageOptions
ack bool ack bool
err error
} }
func (m *kgoMessage) Ack() error { func (m *kgoMessage) Ack() error {
@@ -133,6 +136,10 @@ func (m *kgoMessage) Topic() string {
return "" return ""
} }
func (m *kgoMessage) Error() error {
return m.err
}
func (m *kgoMessage) Unmarshal(dst interface{}, opts ...codec.Option) error { func (m *kgoMessage) Unmarshal(dst interface{}, opts ...codec.Option) error {
return m.c.Unmarshal(m.body, dst) return m.c.Unmarshal(m.body, dst)
} }
@@ -245,6 +252,68 @@ func (k *Broker) Connect(ctx context.Context) error {
k.connected.Store(1) k.connected.Store(1)
k.mu.Unlock() k.mu.Unlock()
exposeLag := false
if k.opts.Context != nil {
if v, ok := k.opts.Context.Value(exposeLagKey{}).(bool); ok && v {
exposeLag = v
}
}
if exposeLag {
var mu sync.Mutex
var lastUpdate time.Time
type pl struct {
p string
l float64
}
lag := make(map[string]map[string]pl) // topic => group => partition => lag
ac := kadm.NewClient(k.c)
updateStats := func() {
mu.Lock()
if time.Since(lastUpdate) < DefaultStatsInterval {
return
}
mu.Unlock()
k.mu.Lock()
groups := make([]string, 0, len(k.subs))
for _, g := range k.subs {
groups = append(groups, g.opts.Group)
}
k.mu.Unlock()
dgls, err := ac.Lag(ctx, groups...)
if err != nil || !dgls.Ok() {
k.opts.Logger.Error(k.opts.Context, "kgo describe group lag error", err)
return
}
for gn, dgl := range dgls {
for tn, lmap := range dgl.Lag {
if _, ok := lag[tn]; !ok {
lag[tn] = make(map[string]pl)
}
for p, l := range lmap {
lag[tn][gn] = pl{p: strconv.Itoa(int(p)), l: float64(l.Lag)}
}
}
}
}
for tn, dg := range lag {
for gn, gl := range dg {
k.opts.Meter.Gauge(semconv.BrokerGroupLag,
func() float64 { updateStats(); return gl.l },
"topic", tn,
"group", gn,
"partition", gl.p)
}
}
}
return nil return nil
} }
@@ -455,15 +524,6 @@ func (b *Broker) fnSubscribe(ctx context.Context, topic string, handler interfac
options := broker.NewSubscribeOptions(opts...) options := broker.NewSubscribeOptions(opts...)
switch handler.(type) {
default:
return nil, broker.ErrInvalidHandler
case func(broker.Message) error:
break
case func([]broker.Message) error:
break
}
if options.Group == "" { if options.Group == "" {
uid, err := id.New() uid, err := id.New()
if err != nil { if err != nil {
@@ -520,6 +580,7 @@ func (b *Broker) fnSubscribe(ctx context.Context, topic string, handler interfac
kgo.OnPartitionsLost(sub.lost), kgo.OnPartitionsLost(sub.lost),
kgo.AutoCommitCallback(sub.autocommit), kgo.AutoCommitCallback(sub.autocommit),
kgo.AutoCommitMarks(), kgo.AutoCommitMarks(),
kgo.WithHooks(sub),
) )
if options.Context != nil { if options.Context != nil {

View File

@@ -82,7 +82,7 @@ func TestFail(t *testing.T) {
for _, msg := range msgs { for _, msg := range msgs {
// t.Logf("broker publish") // t.Logf("broker publish")
if err := b.Publish(ctx, "test.fail", msg); err != nil { if err := b.Publish(ctx, "test.fail", msg); err != nil {
t.Fatal(err) // t.Fatal(err)
} }
} }
}() }()

View File

@@ -14,18 +14,18 @@ type hookMeter struct {
} }
var ( var (
_ kgo.HookBrokerConnect = &hookMeter{} _ kgo.HookBrokerConnect = (*hookMeter)(nil)
_ kgo.HookBrokerDisconnect = &hookMeter{} _ kgo.HookBrokerDisconnect = (*hookMeter)(nil)
// HookBrokerE2E // HookBrokerE2E
_ kgo.HookBrokerRead = &hookMeter{} _ kgo.HookBrokerRead = (*hookMeter)(nil)
_ kgo.HookBrokerThrottle = &hookMeter{} _ kgo.HookBrokerThrottle = (*hookMeter)(nil)
_ kgo.HookBrokerWrite = &hookMeter{} _ kgo.HookBrokerWrite = (*hookMeter)(nil)
_ kgo.HookFetchBatchRead = &hookMeter{} _ kgo.HookFetchBatchRead = (*hookMeter)(nil)
// HookFetchRecordBuffered // HookFetchRecordBuffered
// HookFetchRecordUnbuffered // HookFetchRecordUnbuffered
_ kgo.HookGroupManageError = &hookMeter{} _ kgo.HookGroupManageError = (*hookMeter)(nil)
// HookNewClient // HookNewClient
_ kgo.HookProduceBatchWritten = &hookMeter{} _ kgo.HookProduceBatchWritten = (*hookMeter)(nil)
// HookProduceRecordBuffered // HookProduceRecordBuffered
// HookProduceRecordPartitioned // HookProduceRecordPartitioned
// HookProduceRecordUnbuffered // HookProduceRecordUnbuffered

View File

@@ -14,7 +14,7 @@ var (
DefaultCommitInterval = 5 * time.Second DefaultCommitInterval = 5 * time.Second
// DefaultStatsInterval specifies how fast check consumer lag // DefaultStatsInterval specifies how fast check consumer lag
DefaultStatsInterval = 5 * time.Second DefaultStatsInterval = 30 * time.Second
// DefaultSubscribeMaxInflight specifies how much messages keep inflight // DefaultSubscribeMaxInflight specifies how much messages keep inflight
DefaultSubscribeMaxInflight = 100 DefaultSubscribeMaxInflight = 100
@@ -116,3 +116,10 @@ type subscribeMessagePoolKey struct{}
func SubscribeMessagePool(b bool) broker.SubscribeOption { func SubscribeMessagePool(b bool) broker.SubscribeOption {
return broker.SetSubscribeOption(subscribeMessagePoolKey{}, b) return broker.SetSubscribeOption(subscribeMessagePoolKey{}, b)
} }
type exposeLagKey struct{}
// ExposeLag enabled subscriber lag via [meter.Meter]
func ExposeLag(b bool) broker.Option {
return broker.SetOption(exposeLagKey{}, b)
}

View File

@@ -3,12 +3,13 @@ package kgo
import ( import (
"context" "context"
"fmt" "fmt"
"maps"
"net"
"strconv" "strconv"
"sync" "sync"
"sync/atomic" "sync/atomic"
"time" "time"
"github.com/twmb/franz-go/pkg/kadm"
"github.com/twmb/franz-go/pkg/kgo" "github.com/twmb/franz-go/pkg/kgo"
"github.com/twmb/franz-go/pkg/kmsg" "github.com/twmb/franz-go/pkg/kmsg"
"go.unistack.org/micro/v4/broker" "go.unistack.org/micro/v4/broker"
@@ -87,46 +88,13 @@ func (s *Subscriber) Unsubscribe(ctx context.Context) error {
func (s *Subscriber) poll(ctx context.Context) { func (s *Subscriber) poll(ctx context.Context) {
maxInflight := DefaultSubscribeMaxInflight maxInflight := DefaultSubscribeMaxInflight
if s.opts.Context != nil { if s.opts.Context != nil {
if n, ok := s.opts.Context.Value(subscribeMaxInflightKey{}).(int); n > 0 && ok { if n, ok := s.opts.Context.Value(subscribeMaxInflightKey{}).(int); n > 0 && ok {
maxInflight = n maxInflight = n
} }
} }
go func() {
ac := kadm.NewClient(s.c)
ticker := time.NewTicker(DefaultStatsInterval)
for {
select {
case <-ctx.Done():
ticker.Stop()
return
case <-ticker.C:
dgls, err := ac.Lag(ctx, s.opts.Group)
if err != nil || !dgls.Ok() {
continue
}
dgl, ok := dgls[s.opts.Group]
if !ok {
continue
}
lmap, ok := dgl.Lag[s.topic]
if !ok {
continue
}
s.mu.Lock()
for p, l := range lmap {
s.kopts.Meter.Counter(semconv.BrokerGroupLag, "topic", s.topic, "group", s.opts.Group, "partition", strconv.Itoa(int(p))).Set(uint64(l.Lag))
}
s.mu.Unlock()
}
}
}()
for { for {
select { select {
case <-ctx.Done(): case <-ctx.Done():
@@ -138,10 +106,25 @@ func (s *Subscriber) poll(ctx context.Context) {
fetches := s.c.PollRecords(ctx, maxInflight) fetches := s.c.PollRecords(ctx, maxInflight)
if !s.closed && fetches.IsClientClosed() { if !s.closed && fetches.IsClientClosed() {
s.closed = true s.closed = true
s.mu.Lock()
tpc := make(map[tp]*consumer, len(s.consumers))
maps.Copy(tpc, s.consumers)
s.mu.Unlock()
for tp, c := range tpc {
if c != nil {
c.recs <- newErrorFetchTopicPartition(kgo.ErrClientClosed, tp.t, tp.p)
}
}
return return
} }
fetches.EachError(func(t string, p int32, err error) { fetches.EachError(func(t string, p int32, err error) {
s.kopts.Logger.Fatal(ctx, fmt.Sprintf("[kgo] fetch topic %s partition %d error", t, p), err) tps := tp{t, p}
s.mu.Lock()
c := s.consumers[tps]
s.mu.Unlock()
if c != nil {
c.recs <- newErrorFetchTopicPartition(kgo.ErrClientClosed, t, p)
}
}) })
fetches.EachPartition(func(p kgo.FetchTopicPartition) { fetches.EachPartition(func(p kgo.FetchTopicPartition) {
@@ -168,7 +151,7 @@ func (s *Subscriber) killConsumers(ctx context.Context, lost map[string][]int32)
s.mu.Lock() s.mu.Lock()
pc, ok := s.consumers[tps] pc, ok := s.consumers[tps]
s.mu.Unlock() s.mu.Unlock()
if !ok { if !ok || pc == nil {
continue continue
} }
s.mu.Lock() s.mu.Lock()
@@ -184,11 +167,21 @@ func (s *Subscriber) killConsumers(ctx context.Context, lost map[string][]int32)
} }
} }
func (s *Subscriber) autocommit(_ *kgo.Client, _ *kmsg.OffsetCommitRequest, _ *kmsg.OffsetCommitResponse, err error) { func (s *Subscriber) autocommit(_ *kgo.Client, r *kmsg.OffsetCommitRequest, _ *kmsg.OffsetCommitResponse, err error) {
if err != nil { if err != nil {
// s.connected.Store(0) s.mu.Lock()
if s.fatalOnError { tpc := make(map[tp]*consumer, len(s.consumers))
s.kopts.Logger.Fatal(context.TODO(), "kgo.AutoCommitCallback error", err) maps.Copy(tpc, s.consumers)
s.mu.Unlock()
for _, tc := range r.Topics {
for _, c := range s.consumers {
if c != nil {
for _, p := range tc.Partitions {
c.recs <- newErrorFetchTopicPartition(err, tc.Topic, p.Partition)
}
}
}
} }
} }
} }
@@ -198,7 +191,6 @@ func (s *Subscriber) lost(ctx context.Context, _ *kgo.Client, lost map[string][]
s.kopts.Logger.Error(ctx, fmt.Sprintf("[kgo] lost %#+v", lost)) s.kopts.Logger.Error(ctx, fmt.Sprintf("[kgo] lost %#+v", lost))
} }
s.killConsumers(ctx, lost) s.killConsumers(ctx, lost)
// s.connected.Store(0)
} }
func (s *Subscriber) revoked(ctx context.Context, c *kgo.Client, revoked map[string][]int32) { func (s *Subscriber) revoked(ctx context.Context, c *kgo.Client, revoked map[string][]int32) {
@@ -208,7 +200,6 @@ func (s *Subscriber) revoked(ctx context.Context, c *kgo.Client, revoked map[str
s.killConsumers(ctx, revoked) s.killConsumers(ctx, revoked)
if err := c.CommitMarkedOffsets(ctx); err != nil { if err := c.CommitMarkedOffsets(ctx); err != nil {
s.kopts.Logger.Error(ctx, "[kgo] revoked CommitMarkedOffsets error", err) s.kopts.Logger.Error(ctx, "[kgo] revoked CommitMarkedOffsets error", err)
// s.connected.Store(0)
} }
} }
@@ -253,6 +244,27 @@ func (pc *consumer) consume() {
case <-pc.quit: case <-pc.quit:
return return
case p := <-pc.recs: case p := <-pc.recs:
if p.Err != nil || p.FetchPartition.Err != nil {
if p.Err != nil {
pm = pc.newErrorMessage(p.Err, p.Topic, p.Partition)
} else if p.FetchPartition.Err != nil {
pm = pc.newErrorMessage(p.FetchPartition.Err, p.Topic, p.Partition)
}
switch h := pc.handler.(type) {
case func(broker.Message) error:
_ = h(pm)
case func([]broker.Message) error:
_ = h([]broker.Message{pm})
}
if pc.messagePool {
messagePool.Put(pm)
}
return
}
for _, record := range p.Records { for _, record := range p.Records {
ctx, sp := pc.htracer.WithProcessSpan(record) ctx, sp := pc.htracer.WithProcessSpan(record)
ts := time.Now() ts := time.Now()
@@ -263,19 +275,23 @@ func (pc *consumer) consume() {
} else { } else {
pm = &kgoMessage{} pm = &kgoMessage{}
} }
pm.body = record.Value pm.body = record.Value
pm.topic = record.Topic pm.topic = record.Topic
pm.ack = false pm.ack = false
pm.hdr = metadata.New(len(record.Headers)) pm.hdr = metadata.New(len(record.Headers))
pm.ctx = ctx pm.ctx = ctx
for _, hdr := range record.Headers { for _, hdr := range record.Headers {
pm.hdr.Set(hdr.Key, string(hdr.Value)) pm.hdr.Set(hdr.Key, string(hdr.Value))
} }
pm.hdr.Set("Micro-Offset", strconv.FormatInt(record.Offset, 10)) pm.hdr.Set("Micro-Offset", strconv.FormatInt(record.Offset, 10))
pm.hdr.Set("Micro-Partition", strconv.FormatInt(int64(record.Partition), 10)) pm.hdr.Set("Micro-Partition", strconv.FormatInt(int64(record.Partition), 10))
pm.hdr.Set("Micro-Topic", record.Topic) pm.hdr.Set("Micro-Topic", record.Topic)
pm.hdr.Set("Micro-Key", string(record.Key)) pm.hdr.Set("Micro-Key", string(record.Key))
pm.hdr.Set("Micro-Timestamp", strconv.FormatInt(record.Timestamp.Unix(), 10)) pm.hdr.Set("Micro-Timestamp", strconv.FormatInt(record.Timestamp.Unix(), 10))
switch h := pc.handler.(type) { switch h := pc.handler.(type) {
case func(broker.Message) error: case func(broker.Message) error:
err = h(pm) err = h(pm)
@@ -299,22 +315,146 @@ func (pc *consumer) consume() {
ack := pm.ack ack := pm.ack
if pc.messagePool { if pc.messagePool {
messagePool.Put(p) messagePool.Put(pm)
}
if ack {
pc.c.MarkCommitRecords(record)
} else {
if sp != nil {
sp.Finish()
}
// pc.connected.Store(0)
pc.kopts.Logger.Fatal(pc.kopts.Context, "[kgo] message not commited")
return
} }
if sp != nil { if sp != nil {
sp.Finish() sp.Finish()
} }
if ack {
pc.c.MarkCommitRecords(record)
continue
}
pm := pc.newErrorMessage(ErrLostMessage, p.Topic, p.Partition)
switch h := pc.handler.(type) {
case func(broker.Message) error:
_ = h(pm)
case func([]broker.Message) error:
_ = h([]broker.Message{pm})
}
if pc.messagePool {
messagePool.Put(pm)
}
return
} }
} }
} }
} }
func (pc *consumer) newErrorMessage(err error, t string, p int32) *kgoMessage {
var pm *kgoMessage
if pc.messagePool {
pm = messagePool.Get().(*kgoMessage)
} else {
pm = &kgoMessage{}
}
pm.err = err
pm.topic = t
pm.hdr = metadata.New(2)
pm.ctx = context.Background()
pm.hdr.Set("Micro-Partition", strconv.FormatInt(int64(p), 10))
pm.hdr.Set("Micro-Topic", t)
return pm
}
func newErrorFetchTopicPartition(err error, t string, p int32) kgo.FetchTopicPartition {
return kgo.FetchTopicPartition{
Topic: t,
FetchPartition: kgo.FetchPartition{
Partition: p,
Err: err,
},
}
}
var (
_ kgo.HookBrokerConnect = (*Subscriber)(nil)
_ kgo.HookBrokerDisconnect = (*Subscriber)(nil)
_ kgo.HookBrokerRead = (*Subscriber)(nil)
_ kgo.HookBrokerWrite = (*Subscriber)(nil)
_ kgo.HookGroupManageError = (*Subscriber)(nil)
_ kgo.HookProduceRecordUnbuffered = (*Subscriber)(nil)
)
func (s *Subscriber) OnGroupManageError(err error) {
if err == nil {
return
}
s.mu.Lock()
tpc := make(map[tp]*consumer, len(s.consumers))
maps.Copy(tpc, s.consumers)
s.mu.Unlock()
for tp, c := range tpc {
if c != nil {
c.recs <- newErrorFetchTopicPartition(err, tp.t, tp.p)
}
}
}
func (s *Subscriber) OnBrokerConnect(_ kgo.BrokerMetadata, _ time.Duration, _ net.Conn, err error) {
if err == nil {
return
}
s.mu.Lock()
tpc := make(map[tp]*consumer, len(s.consumers))
maps.Copy(tpc, s.consumers)
s.mu.Unlock()
for tp, c := range tpc {
if c != nil {
c.recs <- newErrorFetchTopicPartition(err, tp.t, tp.p)
}
}
}
func (s *Subscriber) OnBrokerDisconnect(_ kgo.BrokerMetadata, _ net.Conn) {
}
func (s *Subscriber) OnBrokerWrite(_ kgo.BrokerMetadata, _ int16, _ int, _ time.Duration, _ time.Duration, err error) {
if err == nil {
return
}
s.mu.Lock()
tpc := make(map[tp]*consumer, len(s.consumers))
maps.Copy(tpc, s.consumers)
s.mu.Unlock()
for tp, c := range tpc {
if c != nil {
c.recs <- newErrorFetchTopicPartition(err, tp.t, tp.p)
}
}
}
func (s *Subscriber) OnBrokerRead(_ kgo.BrokerMetadata, _ int16, _ int, _ time.Duration, _ time.Duration, err error) {
if err == nil {
return
}
s.mu.Lock()
tpc := make(map[tp]*consumer, len(s.consumers))
maps.Copy(tpc, s.consumers)
s.mu.Unlock()
for tp, c := range tpc {
if c != nil {
c.recs <- newErrorFetchTopicPartition(err, tp.t, tp.p)
}
}
}
func (s *Subscriber) OnProduceRecordUnbuffered(_ *kgo.Record, err error) {
if err == nil {
return
}
s.mu.Lock()
tpc := make(map[tp]*consumer, len(s.consumers))
maps.Copy(tpc, s.consumers)
s.mu.Unlock()
for tp, c := range tpc {
if c != nil {
c.recs <- newErrorFetchTopicPartition(err, tp.t, tp.p)
}
}
}