Bump github.com/twmb/franz-go from 1.2.6 to 1.3.1 #29

vtolstov · 2022-01-07T14:20:47+03:00

dependabot[bot] commented

2022-01-07 14:20:47 +03:00

(Migrated from github.com)

Bumps github.com/twmb/franz-go from 1.2.6 to 1.3.1.

Changelog

Sourced from github.com/twmb/franz-go's changelog.

v1.3.1

This small patch release fixes a leaked-goroutine problem after closing a consuming client, and adds one config validation to hopefully reduce confusion.

For the bug, if a fetch was buffered when you were closing the client, an internal goroutine would stay alive. In normal cases where you have one client in your program and you close it on program shutdown, this leak is not really important. If your program recreates consuming clients often and stays alive, the leaked goroutine could eventually result in unexpected memory consumption. Now, the client internally unbuffers all fetches at the end of Close, which allows the previously-leaking goroutine to exit.

For the config validation, using ConsumePartitions and ConsumeTopics with the same topic in both options would silently ignore the topic in ConsumePartitions. Now, the client will return an error that using the same topic in both options is invalid.

ea11266 config: add duplicately specified topic validation

bb581f4 bugfix client: unbuffer fetches on Close to allow mangeFetchConcurrency to quit

v1.3.0

This release contains three new features, a few behavior changes, and one minor bugfix.

For features, you can now adjust fetched offsets before they are used (thanks @michaelwilner!), you can now "ping" your cluster to see if the client can connect at all, and you can now use SetOffsets when consuming partitions manually. As a somewhat of a feature-ish, producing no longer requires a context, instead if a context is nil, context.Background is used (this was added to allow more laziness when writing small unimportant files).

The transactional behavior change is important: the documentation changes are worth reading, and it is worth using a 2.5+ cluster along with the RequireStableFetchOffsets option if possible. The metadata leader epoch rewinding behavior change allows the client to continue in the event of odd cluster issues.

In kadm, we now return individual per-partition errors if partitions are not included in OffsetCommit responses. The generated code now has a few more enums (thanks @weeco!)

Lastly, as a small bugfix, client.Close() did not properly stop seed brokers. A previous commit split seed brokers and non-seed brokers internally into two fields but did not add broker shutdown on the now-split seed broker field.

e0b520c behavior change kadm: set per-partition errors on missing offsets in CommitOffsets

... (truncated)

Commits

cfd3330 CHANGELOG: note v1.3.1
ea11266 config: add duplicately specified topic validation
bb581f4 client: unbuffer fetches on Close to allow mangeFetchConcurrency to quit
d62f1be changelog: note v1.3.0
e0b520c kadm: set per-partition errors on missing offsets in CommitOffsets
32425df client: add Ping method
a059901 txns: sleep 200ms on commit, preventing rebalance / new commit
12eaa1e metadata: allow leader epoch rewinds after 5 tries
029e655 Produce{,Sync}: default to context.Background if no ctx is provided
eb2cec3 client: stop seed brokers on client.Close
Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/twmb/franz-go](https://github.com/twmb/franz-go) from 1.2.6 to 1.3.1. <details> <summary>Changelog</summary> Sourced from <a href="https://github.com/twmb/franz-go/blob/master/CHANGELOG.md">github.com/twmb/franz-go's changelog</a>. <blockquote> <h1>v1.3.1</h1> This small patch release fixes a leaked-goroutine problem after closing a consuming client, and adds one config validation to hopefully reduce confusion. For the bug, if a fetch was buffered when you were closing the client, an internal goroutine would stay alive. In normal cases where you have one client in your program and you close it on program shutdown, this leak is not really important. If your program recreates consuming clients often and stays alive, the leaked goroutine could eventually result in unexpected memory consumption. Now, the client internally unbuffers all fetches at the end of <code>Close</code>, which allows the previously-leaking goroutine to exit. For the config validation, using <code>ConsumePartitions</code> and <code>ConsumeTopics</code> with the same topic in both options would silently ignore the topic in <code>ConsumePartitions</code>. Now, the client will return an error that using the same topic in both options is invalid. <ul> <li><a href="https://github.com/twmb/franz-go/commit/ea11266"><code>ea11266</code></a> config: add duplicately specified topic validation</li> <li><a href="https://github.com/twmb/franz-go/commit/bb581f4"><code>bb581f4</code></a> bugfix client: unbuffer fetches on Close to allow mangeFetchConcurrency to quit</li> </ul> <h1>v1.3.0</h1> This release contains three new features, a few behavior changes, and one minor bugfix. For features, you can now adjust fetched offsets before they are used (thanks <a href="https://github.com/michaelwilner"><code>@michaelwilner</code></a>!), you can now "ping" your cluster to see if the client can connect at all, and you can now use <code>SetOffsets</code> when consuming partitions manually. As a somewhat of a feature-ish, producing no longer requires a context, instead if a context is nil, <code>context.Background</code> is used (this was added to allow more laziness when writing small unimportant files). The transactional behavior change is important: the documentation changes are worth reading, and it is worth using a 2.5+ cluster along with the <code>RequireStableFetchOffsets</code> option if possible. The metadata leader epoch rewinding behavior change allows the client to continue in the event of odd cluster issues. In kadm, we now return individual per-partition errors if partitions are not included in OffsetCommit responses. The generated code now has a few more enums (thanks <a href="https://github.com/weeco"><code>@weeco</code></a>!) Lastly, as a small bugfix, <code>client.Close()</code> did not properly stop seed brokers. A previous commit split seed brokers and non-seed brokers internally into two fields but did not add broker shutdown on the now-split seed broker field. <ul> <li><a href="https://github.com/twmb/franz-go/commit/e0b520c"><code>e0b520c</code></a> behavior change kadm: set per-partition errors on missing offsets in CommitOffsets</li> </ul>  </blockquote> ... (truncated) </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/twmb/franz-go/commit/cfd3330d96f5a51e4760706ffc022114d222ff67"><code>cfd3330</code></a> CHANGELOG: note v1.3.1</li> <li><a href="https://github.com/twmb/franz-go/commit/ea11266b73e91a505522b0911b41b81f1c3c9c83"><code>ea11266</code></a> config: add duplicately specified topic validation</li> <li><a href="https://github.com/twmb/franz-go/commit/bb581f432fb242736a333f04463a16c5e889be50"><code>bb581f4</code></a> client: unbuffer fetches on Close to allow mangeFetchConcurrency to quit</li> <li><a href="https://github.com/twmb/franz-go/commit/d62f1bef74f97fb40041cd1199338f051b955592"><code>d62f1be</code></a> changelog: note v1.3.0</li> <li><a href="https://github.com/twmb/franz-go/commit/e0b520c8a7d1da75db8ebde36b666ea784cb43f4"><code>e0b520c</code></a> kadm: set per-partition errors on missing offsets in CommitOffsets</li> <li><a href="https://github.com/twmb/franz-go/commit/32425df315f0d9b080901a7da28e4580e5dc07a4"><code>32425df</code></a> client: add Ping method</li> <li><a href="https://github.com/twmb/franz-go/commit/a059901629934345288a1a6c1a9f2ed2ef635019"><code>a059901</code></a> txns: sleep 200ms on commit, preventing rebalance / new commit</li> <li><a href="https://github.com/twmb/franz-go/commit/12eaa1e41c036639a8fb97bb557ae49375225a53"><code>12eaa1e</code></a> metadata: allow leader epoch rewinds after 5 tries</li> <li><a href="https://github.com/twmb/franz-go/commit/029e65549d78531915df452289707baf130c7c9e"><code>029e655</code></a> Produce{,Sync}: default to context.Background if no ctx is provided</li> <li><a href="https://github.com/twmb/franz-go/commit/eb2cec3b3df798189eeb60db8ad62be8ec42d18d"><code>eb2cec3</code></a> client: stop seed brokers on client.Close</li> <li>Additional commits viewable in <a href="https://github.com/twmb/franz-go/compare/v1.2.6...v1.3.1">compare view</a></li> </ul> </details> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/twmb/franz-go&package-manager=go_modules&previous-version=1.2.6&new-version=1.3.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>

vtolstov (Migrated from github.com) reviewed 2022-01-07 14:21:01 +03:00

vtolstov (Migrated from github.com) approved these changes 2022-01-11 14:29:42 +03:00

vtolstov referenced this issue from a commit

2023-04-29 17:27:06 +03:00

Merge pull request #29 from unistack-org/dependabot/go_modules/github.com/twmb/franz-go-1.3.1

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: unistack-org/micro-broker-kgo#29