Bump github.com/twmb/franz-go from 1.3.1 to 1.3.4 #40

vtolstov · 2022-02-22T14:22:44+03:00

dependabot[bot] commented

2022-02-22 14:22:44 +03:00

(Migrated from github.com)

Bumps github.com/twmb/franz-go from 1.3.1 to 1.3.4.

Changelog

Sourced from github.com/twmb/franz-go's changelog.

v1.3.4

This small patch release fixes a problem with 4f2e7fe3 which was meant to address #98. The fix was not complete in that the fix would only trigger if a group member had partitions added to it. We now rearrange the logic such that it occurs always. This bug was found while making a change in the code in support of a new feature in the v1.4 branch; this bug was not encountered in production.

This also bumps the franz-go/pkg/kmsg dependency so that JoinGroup.Reason is properly tagged as v9+.

The next release will be v1.4, which is nearly ready to be merged into this branch and tagged. Follow issue #135 for more details.

02560c7 consumer group: bugfix fetch offsets spanning rebalance

v1.3.3

This patch release contains two minor bug fixes and a few small behavior changes. The upcoming v1.4 release will contain more changes to lint the entire codebase and will have a few new options as features to configure the client internals. There are a few features in development yet that I would like to complete before tagging the next minor release.

Bug fixes

Repeated integration testing resulted in a rare data race, and one other bug was found by linting. For the race, if a group was left or heartbeating stopped before offset fetching finished, then there would be a concurrent double write to an error variable: one write would try to write an error from the request being cut (which would be context.Canceled), and the other write would write the same error, but directly from ctx.Err. Since both of these are the same type pointer and data pointer, it is unlikely this race would result in anything if it was ever encountered, and encountering it would be rare.

For the second bug, after this prior one, I wondered if any linter would have caught this bug (the answer is no). However, in the process of heavily linting the code base, a separate bug was found. This bug has no impact, but it is good to fix. If you previously consumed and specified exact offsets to consume from, the internal ListOffsets request would use that offset as a timestamp, rather than using -1 as I meant to internally. The whole point is just to load the partition, so using a random number for a timestmap is just as good as using -1, but we may as well use -1 to be proper.

Behavior changes

... (truncated)

Commits

99b4da4 CHANGELOG: note v1.3.4
7bf4ce9 franz-go: bump kmsg for generated change
02560c7 consumer group: bugfix fetch offsets spanning rebalance
aa2550d kversion: fix internal doc
ccbdda6 generate: properly version JoinGroup.Reason
c67ef7e CHANGELOG: note v1.3.3
89f9425 client: fix outdated documentation
b39ca31 fetchOffsets: fix data race
4156e9f kgo: fix one bug found by linting
ad991d8 franz-go: bump kmsg dependency for v9 SkipAssignment fix
Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/twmb/franz-go](https://github.com/twmb/franz-go) from 1.3.1 to 1.3.4. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/twmb/franz-go/blob/master/CHANGELOG.md">github.com/twmb/franz-go's changelog</a>.</em></p> <blockquote> <h1>v1.3.4</h1> <p>This small patch release fixes a problem with <a href="https://github.com/twmb/franz-go/commit/4f2e7fe3"><code>4f2e7fe3</code></a> which was meant to address <a href="https://github-redirect.dependabot.com/twmb/franz-go/issues/98">#98</a>. The fix was not complete in that the fix would only trigger if a group member had partitions added to it. We now rearrange the logic such that it occurs always. This bug was found while making a change in the code in support of a new feature in the v1.4 branch; this bug was not encountered in production.</p> <p>This also bumps the franz-go/pkg/kmsg dependency so that <code>JoinGroup.Reason</code> is properly tagged as v9+.</p> <p>The next release will be v1.4, which is nearly ready to be merged into this branch and tagged. Follow issue <a href="https://github-redirect.dependabot.com/twmb/franz-go/issues/135">#135</a> for more details.</p> <ul> <li><a href="https://github.com/twmb/franz-go/commit/02560c7"><code>02560c7</code></a> consumer group: bugfix fetch offsets spanning rebalance</li> </ul> <h1>v1.3.3</h1> <p>This patch release contains two minor bug fixes and a few small behavior changes. The upcoming v1.4 release will contain more changes to lint the entire codebase and will have a few new options as features to configure the client internals. There are a few features in development yet that I would like to complete before tagging the next minor release.</p> <h2>Bug fixes</h2> <p>Repeated integration testing resulted in a rare data race, and one other bug was found by linting. For the race, if a group was left <em>or</em> heartbeating stopped <em>before</em> offset fetching finished, then there would be a concurrent double write to an error variable: one write would try to write an error from the request being cut (which would be <code>context.Canceled</code>), and the other write would write the same error, but directly from <code>ctx.Err</code>. Since both of these are the same type pointer and data pointer, it is unlikely this race would result in anything if it was ever encountered, and encountering it would be rare.</p> <p>For the second bug, after this prior one, I wondered if any linter would have caught this bug (the answer is no). However, in the process of heavily linting the code base, a separate bug was found. This bug has <strong>no impact</strong>, but it is good to fix. If you previously consumed and specified <em>exact</em> offsets to consume from, the internal <code>ListOffsets</code> request would use that offset as a timestamp, rather than using -1 as I meant to internally. The whole point is just to load the partition, so using a random number for a timestmap is just as good as using -1, but we may as well use -1 to be proper.</p> <h2>Behavior changes</h2>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/twmb/franz-go/commit/99b4da42cf4bc48e4cbbbd5e4b29c6ae858a8fef"><code>99b4da4</code></a> CHANGELOG: note v1.3.4</li> <li><a href="https://github.com/twmb/franz-go/commit/7bf4ce9933f951d2fff124797b35e0882c694fa6"><code>7bf4ce9</code></a> franz-go: bump kmsg for generated change</li> <li><a href="https://github.com/twmb/franz-go/commit/02560c7b49cadacdb9104b90fafd9b3a34f29295"><code>02560c7</code></a> consumer group: bugfix fetch offsets spanning rebalance</li> <li><a href="https://github.com/twmb/franz-go/commit/aa2550dfec74d378a191a03f3bc1f21d723bde9d"><code>aa2550d</code></a> kversion: fix internal doc</li> <li><a href="https://github.com/twmb/franz-go/commit/ccbdda6e693d5439b62d3b7550ababb338979a91"><code>ccbdda6</code></a> generate: properly version JoinGroup.Reason</li> <li><a href="https://github.com/twmb/franz-go/commit/c67ef7e570587cf0bd34434fb7aa7c1e34f26045"><code>c67ef7e</code></a> CHANGELOG: note v1.3.3</li> <li><a href="https://github.com/twmb/franz-go/commit/89f94256d65a96865d294f21c63948fae0e7309b"><code>89f9425</code></a> client: fix outdated documentation</li> <li><a href="https://github.com/twmb/franz-go/commit/b39ca311e5c1775250e981bbf28f0e06084f2eff"><code>b39ca31</code></a> fetchOffsets: fix data race</li> <li><a href="https://github.com/twmb/franz-go/commit/4156e9f73ae31338ed98589d93d22036f7349d7f"><code>4156e9f</code></a> kgo: fix one bug found by linting</li> <li><a href="https://github.com/twmb/franz-go/commit/ad991d8eaabebae7ed32232868a238c945bb7208"><code>ad991d8</code></a> franz-go: bump kmsg dependency for v9 SkipAssignment fix</li> <li>Additional commits viewable in <a href="https://github.com/twmb/franz-go/compare/v1.3.1...v1.3.4">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/twmb/franz-go&package-manager=go_modules&previous-version=1.3.1&new-version=1.3.4)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>

vtolstov (Migrated from github.com) reviewed 2022-02-22 14:23:00 +03:00

vtolstov (Migrated from github.com) approved these changes 2022-02-25 09:45:00 +03:00

vtolstov referenced this issue from a commit

2023-04-29 17:27:07 +03:00

Merge pull request #40 from unistack-org/dependabot/go_modules/github.com/twmb/franz-go-1.3.4

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: unistack-org/micro-broker-kgo#40