Bump github.com/twmb/franz-go from 1.7.0 to 1.7.1 #76

vtolstov · 2022-09-05T18:43:09+03:00

dependabot[bot] commented

2022-09-05 18:43:09 +03:00

(Migrated from github.com)

Bumps github.com/twmb/franz-go from 1.7.0 to 1.7.1.

Changelog

Sourced from github.com/twmb/franz-go's changelog.

v1.7.1

This release fixes two bugs, one that is obscure and unlikely to be ran into in most use cases, and one that is not as obsure and may be ran into in a racy scenario. It is recommended to upgrade.

3191842 fixes a bug that could eventually lead to a completely stalled consumer. The problem can happen whenever an internal "consumer session" is stopped and restarted -- which happens on most rebalances, and happens whenever a partition moves from one broker to another. This logic race required no active fetches to be in flight nor buffered, and required a fetch to just about be issued.

0ca6478 fixes a complicated bug that could result in a panic. It requires the following:

using a single client to produce and consume to the

consuming from that topic first

producing to that topic after the first consume

the metadata load that is triggered from the produce fails with partition errors

the metadata load retry moves a previously-errored partition from one broker to another

Any deviation from this sequence of events would not result in a panic. If the final step did not move the partition between brokers, the client would still be internally problematic, but there would be no visible problem (the partition would be produced to two brokers, the produce to the wrong broker would fail while the correct broker would succeed),

Relevant commits

0ca6478 kgo: avoid pointer reuse in metadata across producers & consumers

3191842 consumer: bugfix fetch concurrency loop

5f24fae kgo: fix an incorrect log line, add another log line

Commits

65375ff CHANGELOG: note incoming v1.7.1
0ca6478 kgo: avoid pointer reuse in metadata across producers & consumers
3191842 consumer: bugfix fetch concurrency loop
5f24fae kgo: fix and add log line
eb2e62d Merge pull request #196 from dwagin/dwagin/example-typo
3d6e376 examples: fixed typo
145b11a CHANGELOG: fix 1.7 formatting
d84eaa2 pkg/sasl/kerberos: Make it easier to persist / destroy the kerberos client
See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/twmb/franz-go](https://github.com/twmb/franz-go) from 1.7.0 to 1.7.1. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/twmb/franz-go/blob/master/CHANGELOG.md">github.com/twmb/franz-go's changelog</a>.</em></p> <blockquote> <h1>v1.7.1</h1> <p>This release fixes two bugs, one that is obscure and unlikely to be ran into in most use cases, and one that is not as obsure and may be ran into in a racy scenario. It is recommended to upgrade.</p> <p><a href="https://github.com/twmb/franz-go/commit/3191842a81033342e8d37a529bd0a1b3d190fd9f"><code>3191842</code></a> fixes a bug that could eventually lead to a completely stalled consumer. The problem can happen whenever an internal "consumer session" is stopped and restarted -- which happens on most rebalances, and happens whenever a partition moves from one broker to another. This logic race required no active fetches to be in flight nor buffered, and required a fetch to <em>just about</em> be issued.</p> <p><a href="https://github.com/twmb/franz-go/commit/0ca6478600c632deed4c7d65c13c3459d19071bd"><code>0ca6478</code></a> fixes a complicated bug that could result in a panic. It requires the following:</p> <ul> <li>using a single client to produce and consume to the</li> <li>consuming from that topic first</li> <li>producing to that topic after the first consume</li> <li>the metadata load that is triggered from the produce fails with partition errors</li> <li>the metadata load retry moves a previously-errored partition from one broker to another</li> </ul> <p>Any deviation from this sequence of events would not result in a panic. If the final step did not move the partition between brokers, the client would still be internally problematic, but there would be no visible problem (the partition would be produced to two brokers, the produce to the wrong broker would fail while the correct broker would succeed),</p> <h2>Relevant commits</h2> <ul> <li><a href="https://github.com/twmb/franz-go/commit/0ca6478"><code>0ca6478</code></a> kgo: avoid pointer reuse in metadata across producers & consumers</li> <li><a href="https://github.com/twmb/franz-go/commit/3191842"><code>3191842</code></a> consumer: bugfix fetch concurrency loop</li> <li><a href="https://github.com/twmb/franz-go/commit/5f24fae"><code>5f24fae</code></a> kgo: fix an incorrect log line, add another log line</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/twmb/franz-go/commit/65375ffa71d8a214358ebee4a492e8c2e0e8871f"><code>65375ff</code></a> CHANGELOG: note incoming v1.7.1</li> <li><a href="https://github.com/twmb/franz-go/commit/0ca6478600c632deed4c7d65c13c3459d19071bd"><code>0ca6478</code></a> kgo: avoid pointer reuse in metadata across producers & consumers</li> <li><a href="https://github.com/twmb/franz-go/commit/3191842a81033342e8d37a529bd0a1b3d190fd9f"><code>3191842</code></a> consumer: bugfix fetch concurrency loop</li> <li><a href="https://github.com/twmb/franz-go/commit/5f24faef09e40ce653a182cbe0c381737a6d2bbf"><code>5f24fae</code></a> kgo: fix and add log line</li> <li><a href="https://github.com/twmb/franz-go/commit/eb2e62d8b4a08e9c5729f419c92d51a8aeb9aa1d"><code>eb2e62d</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/twmb/franz-go/issues/196">#196</a> from dwagin/dwagin/example-typo</li> <li><a href="https://github.com/twmb/franz-go/commit/3d6e3762f585c3e1df10e4e6f48dfdfbd7718135"><code>3d6e376</code></a> examples: fixed typo</li> <li><a href="https://github.com/twmb/franz-go/commit/145b11a74d51395ef3fbf3d61d8282560116e4b4"><code>145b11a</code></a> CHANGELOG: fix 1.7 formatting</li> <li><a href="https://github.com/twmb/franz-go/commit/d84eaa20e098377eeadefe4250f5520b51ea1c52"><code>d84eaa2</code></a> pkg/sasl/kerberos: Make it easier to persist / destroy the kerberos client</li> <li>See full diff in <a href="https://github.com/twmb/franz-go/compare/v1.7.0...v1.7.1">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/twmb/franz-go&package-manager=go_modules&previous-version=1.7.0&new-version=1.7.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>

github-actions[bot] (Migrated from github.com) approved these changes 2022-09-05 18:43:23 +03:00

vtolstov referenced this issue from a commit

2023-04-28 22:51:11 +03:00

Bump github.com/twmb/franz-go from 1.7.0 to 1.7.1 (#76)

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: unistack-org/micro-broker-kgo#76