broker/segmentio: speedup publish
Signed-off-by: Vasiliy Tolstov <v.tolstov@unistack.org>
This commit is contained in:
parent
d9c3a34d39
commit
9b9387d916
52
segmentio.go
52
segmentio.go
@ -5,6 +5,7 @@ import (
|
||||
"context"
|
||||
"errors"
|
||||
"sync"
|
||||
"time"
|
||||
|
||||
"github.com/google/uuid"
|
||||
"github.com/micro/go-micro/v2/broker"
|
||||
@ -182,24 +183,65 @@ func (k *kBroker) Options() broker.Options {
|
||||
}
|
||||
|
||||
func (k *kBroker) Publish(topic string, msg *broker.Message, opts ...broker.PublishOption) error {
|
||||
var cached bool
|
||||
|
||||
buf, err := k.opts.Codec.Marshal(msg)
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
|
||||
kmsg := kafka.Message{Value: buf}
|
||||
|
||||
k.Lock()
|
||||
writer, ok := k.writers[topic]
|
||||
if !ok {
|
||||
cfg := k.writerConfig
|
||||
cfg.Topic = topic
|
||||
if err = cfg.Validate(); err != nil {
|
||||
k.Unlock()
|
||||
return err
|
||||
}
|
||||
writer = kafka.NewWriter(cfg)
|
||||
k.writers[topic] = writer
|
||||
} else {
|
||||
cached = true
|
||||
}
|
||||
k.Unlock()
|
||||
|
||||
err = writer.WriteMessages(k.opts.Context, kmsg)
|
||||
if err != nil {
|
||||
switch cached {
|
||||
case false:
|
||||
// non cached case, we can try to wait on some errors, but not timeout
|
||||
if kerr, ok := err.(kafka.Error); ok {
|
||||
if kerr.Temporary() && !kerr.Timeout() {
|
||||
// additional chanse to publish message
|
||||
time.Sleep(200 * time.Millisecond)
|
||||
err = writer.WriteMessages(k.opts.Context, kmsg)
|
||||
}
|
||||
}
|
||||
case true:
|
||||
// cached case, try to recreate writer and try again after that
|
||||
k.Lock()
|
||||
// close older writer to free memory
|
||||
if err = writer.Close(); err != nil {
|
||||
k.Unlock()
|
||||
return err
|
||||
}
|
||||
cfg := k.writerConfig
|
||||
cfg.Topic = topic
|
||||
if err = cfg.Validate(); err != nil {
|
||||
k.Unlock()
|
||||
return err
|
||||
}
|
||||
writer := kafka.NewWriter(cfg)
|
||||
|
||||
err = writer.WriteMessages(k.opts.Context, kafka.Message{Value: buf})
|
||||
if err != nil {
|
||||
return err
|
||||
k.writers[topic] = writer
|
||||
k.Unlock()
|
||||
err = writer.WriteMessages(k.opts.Context, kmsg)
|
||||
}
|
||||
}
|
||||
|
||||
return writer.Close()
|
||||
return err
|
||||
}
|
||||
|
||||
func (k *kBroker) Subscribe(topic string, handler broker.Handler, opts ...broker.SubscribeOption) (broker.Subscriber, error) {
|
||||
|
@ -12,7 +12,7 @@ import (
|
||||
)
|
||||
|
||||
func BenchmarkSegmentioCodecJsonPublish(b *testing.B) {
|
||||
b.Skip()
|
||||
// b.Skip()
|
||||
if tr := os.Getenv("TRAVIS"); len(tr) > 0 {
|
||||
b.Skip()
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user