fix x-www-form-urlencoded requests

Signed-off-by: Vasiliy Tolstov <v.tolstov@unistack.org>

go.mod

@@ -2,4 +2,4 @@ module github.com/unistack-org/micro-client-http/v3
 
 go 1.16
 
-require github.com/unistack-org/micro/v3 v3.2.24
+require github.com/unistack-org/micro/v3 v3.3.11

go.sum

@@ -5,11 +5,11 @@ github.com/google/uuid v1.2.0/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+
 github.com/imdario/mergo v0.3.12/go.mod h1:jmQim1M+e3UYxmgPu/WyfjB3N3VflVyUjjjwH0dnCYA=
 github.com/patrickmn/go-cache v2.1.0+incompatible/go.mod h1:3Qf8kWWT7OJRJbdiICTKqZju1ZixQ/KpMGzzAfe6+WQ=
 github.com/silas/dag v0.0.0-20210121180416-41cf55125c34/go.mod h1:7RTUFBdIRC9nZ7/3RyRNH1bdqIShrDejd1YbLwgPS+I=
-github.com/unistack-org/micro/v3 v3.2.24 h1:3sQ72wy8Vap9KDD7bdLOn+dhlPT0iXSJRXhs2qHoKxA=
+github.com/unistack-org/micro/v3 v3.3.11 h1:Jr0gAw5lLqgddiHKQeWUOUeP6ZqgRhz52EA9zJ5MJ3U=
-github.com/unistack-org/micro/v3 v3.2.24/go.mod h1:iJwCWq2PECMxigfqe6TPC5GLWvj6P94Kk+PTVZGL3w8=
+github.com/unistack-org/micro/v3 v3.3.11/go.mod h1:PPCt675o3HPcODFbJ4iRWPmQFAk1WQ+asQSOb/syq6U=
-golang.org/x/net v0.0.0-20210316092652-d523dce5a7f4/go.mod h1:RBQZq4jEuRlivfhVLdyRGr576XBO4/greRjx4P4O3yc=
+golang.org/x/net v0.0.0-20210331212208-0fccb6fa2b5c/go.mod h1:p54w0d4576C0XHj96bSt6lcn1PtDYWL6XObtHCRCNQM=
 golang.org/x/sys v0.0.0-20201119102817-f84b799fce68/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
-golang.org/x/sys v0.0.0-20210315160823-c6e025ad8005/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
+golang.org/x/sys v0.0.0-20210330210617-4fbd30eecc44/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
 golang.org/x/term v0.0.0-20201126162022-7de9c90e9dd1/go.mod h1:bj7SfCRtBDWHUb9snDiAeCFNEtKQo2Wmx5Cou7ajbmo=
 golang.org/x/text v0.3.3/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ=
 golang.org/x/tools v0.0.0-20180917221912-90fa682c2a6e/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ=

http.go

@@ -19,6 +19,7 @@ import (
 	"github.com/unistack-org/micro/v3/errors"
 	"github.com/unistack-org/micro/v3/metadata"
 	"github.com/unistack-org/micro/v3/router"
+	rutil "github.com/unistack-org/micro/v3/util/reflect"
 )
 
 var (
@@ -34,11 +35,15 @@ type httpClient struct {
 	opts    client.Options
 	dialer  *net.Dialer
 	httpcli *http.Client
+	init    bool
 }
 
-func newRequest(addr string, req client.Request, cf codec.Codec, msg interface{}, opts client.CallOptions) (*http.Request, error) {
+func newRequest(addr string, req client.Request, ct string, cf codec.Codec, msg interface{}, opts client.CallOptions) (*http.Request, error) {
 	hreq := &http.Request{Method: http.MethodPost}
 	body := "*" // as like google api http annotation
+
+	var tags []string
+	var scheme string
 	u, err := url.Parse(addr)
 	if err != nil {
 		hreq.URL = &url.URL{
@@ -47,6 +52,7 @@ func newRequest(addr string, req client.Request, cf codec.Codec, msg interface{}
 			Path:   req.Endpoint(),
 		}
 		hreq.Host = addr
+		scheme = "http"
 	} else {
 		ep := req.Endpoint()
 		if opts.Context != nil {
@@ -59,6 +65,10 @@ func newRequest(addr string, req client.Request, cf codec.Codec, msg interface{}
 			if b, ok := opts.Context.Value(bodyKey{}).(string); ok {
 				body = b
 			}
+			if t, ok := opts.Context.Value(structTagsKey{}).([]string); ok && len(t) > 0 {
+				tags = t
+			}
+
 		}
 		hreq.URL, err = u.Parse(ep)
 		if err != nil {
@@ -66,52 +76,84 @@ func newRequest(addr string, req client.Request, cf codec.Codec, msg interface{}
 		}
 	}
 
-	path, nmsg, err := newPathRequest(hreq.URL.Path, hreq.Method, body, msg)
+	if len(tags) == 0 {
+		switch ct {
+		default:
+			tags = append(tags, "json", "protobuf")
+		case "text/xml":
+			tags = append(tags, "xml")
+		}
+	}
+
+	path, nmsg, err := newPathRequest(hreq.URL.Path, hreq.Method, body, msg, tags)
 	if err != nil {
 		return nil, errors.BadRequest("go.micro.client", err.Error())
 	}
 
-	hreq.URL, err = url.Parse(addr + path)
+	if scheme != "" {
+		hreq.URL, err = url.Parse(scheme + "://" + addr + path)
+	} else {
+		hreq.URL, err = url.Parse(addr + path)
+	}
 	if err != nil {
 		return nil, errors.BadRequest("go.micro.client", err.Error())
 	}
 
 	var b []byte
 
-	// marshal request is struct not empty
 	if nmsg != nil {
-		b, err = cf.Marshal(nmsg)
+		if ct == "application/x-www-form-urlencoded" {
-		if err != nil {
+			data, err := rutil.StructURLValues(nmsg, "", tags)
-			return nil, errors.BadRequest("go.micro.client", err.Error())
+			if err != nil {
+				return nil, errors.BadRequest("go.micro.client", err.Error())
+			}
+			b = []byte(data.Encode())
+		} else {
+			b, err = cf.Marshal(nmsg)
+			if err != nil {
+				return nil, errors.BadRequest("go.micro.client", err.Error())
+			}
 		}
 	}
 
-	hreq.Body = ioutil.NopCloser(bytes.NewBuffer(b))
+	if len(b) > 0 {
-	hreq.ContentLength = int64(len(b))
+		hreq.Body = ioutil.NopCloser(bytes.NewBuffer(b))
+		hreq.ContentLength = int64(len(b))
+	}
 
 	return hreq, nil
 }
 
 func (h *httpClient) call(ctx context.Context, addr string, req client.Request, rsp interface{}, opts client.CallOptions) error {
 	header := make(http.Header, 2)
-	if md, ok := metadata.FromContext(ctx); ok {
+	if md, ok := metadata.FromOutgoingContext(ctx); ok {
 		for k, v := range md {
 			header.Set(k, v)
 		}
 	}
 
+	ct := req.ContentType()
+
 	// set timeout in nanoseconds
 	header.Set("Timeout", fmt.Sprintf("%d", opts.RequestTimeout))
 	// set the content type for the request
-	header.Set("Content-Type", req.ContentType())
+	header.Set("Content-Type", ct)
 
+	var cf codec.Codec
+	var err error
 	// get codec
-	cf, err := h.newCodec(req.ContentType())
+	switch ct {
+	case "application/x-www-form-urlencoded":
+		cf, err = h.newCodec(DefaultContentType)
+	default:
+		cf, err = h.newCodec(ct)
+	}
+
 	if err != nil {
 		return errors.InternalServerError("go.micro.client", err.Error())
 	}
 
-	hreq, err := newRequest(addr, req, cf, req.Body(), opts)
+	hreq, err := newRequest(addr, req, ct, cf, req.Body(), opts)
 	if err != nil {
 		return err
 	}
@@ -142,7 +184,7 @@ func (h *httpClient) call(ctx context.Context, addr string, req client.Request,
 func (h *httpClient) stream(ctx context.Context, addr string, req client.Request, opts client.CallOptions) (client.Stream, error) {
 	var header http.Header
 
-	if md, ok := metadata.FromContext(ctx); ok {
+	if md, ok := metadata.FromOutgoingContext(ctx); ok {
 		header = make(http.Header, len(md)+2)
 		for k, v := range md {
 			header.Set(k, v)
@@ -151,10 +193,11 @@ func (h *httpClient) stream(ctx context.Context, addr string, req client.Request
 		header = make(http.Header, 2)
 	}
 
+	ct := req.ContentType()
 	// set timeout in nanoseconds
 	header.Set("Timeout", fmt.Sprintf("%d", opts.RequestTimeout))
 	// set the content type for the request
-	header.Set("Content-Type", req.ContentType())
+	header.Set("Content-Type", ct)
 
 	// get codec
 	cf, err := h.newCodec(req.ContentType())
@@ -167,7 +210,7 @@ func (h *httpClient) stream(ctx context.Context, addr string, req client.Request
 	if err == nil && u.Scheme != "" && u.Host != "" {
 		dialAddr = u.Host
 	}
-	cc, err := h.dialer.DialContext(ctx, "tcp", addr)
+	cc, err := (h.httpcli.Transport).(*http.Transport).DialContext(ctx, "tcp", addr)
 	if err != nil {
 		return nil, errors.InternalServerError("go.micro.client", fmt.Sprintf("Error dialing: %v", err))
 	}
@@ -178,7 +221,8 @@ func (h *httpClient) stream(ctx context.Context, addr string, req client.Request
 		closed:  make(chan bool),
 		opts:    opts,
 		conn:    cc,
-		codec:   cf,
+		ct:      ct,
+		cf:      cf,
 		header:  header,
 		reader:  bufio.NewReader(cc),
 		request: req,
@@ -194,9 +238,32 @@ func (h *httpClient) newCodec(ct string) (codec.Codec, error) {
 }
 
 func (h *httpClient) Init(opts ...client.Option) error {
+	if len(opts) == 0 && h.init {
+		return nil
+	}
 	for _, o := range opts {
 		o(&h.opts)
 	}
+
+	if err := h.opts.Broker.Init(); err != nil {
+		return err
+	}
+	if err := h.opts.Tracer.Init(); err != nil {
+		return err
+	}
+	if err := h.opts.Router.Init(); err != nil {
+		return err
+	}
+	if err := h.opts.Logger.Init(); err != nil {
+		return err
+	}
+	if err := h.opts.Meter.Init(); err != nil {
+		return err
+	}
+	if err := h.opts.Transport.Init(); err != nil {
+		return err
+	}
+
 	return nil
 }
 
@@ -208,8 +275,8 @@ func (h *httpClient) NewMessage(topic string, msg interface{}, opts ...client.Me
 	return newHTTPMessage(topic, msg, h.opts.ContentType, opts...)
 }
 
-func (h *httpClient) NewRequest(service, method string, req interface{}, reqOpts ...client.RequestOption) client.Request {
+func (h *httpClient) NewRequest(service, method string, req interface{}, opts ...client.RequestOption) client.Request {
-	return newHTTPRequest(service, method, req, h.opts.ContentType, reqOpts...)
+	return newHTTPRequest(service, method, req, h.opts.ContentType, opts...)
 }
 
 func (h *httpClient) Call(ctx context.Context, req client.Request, rsp interface{}, opts ...client.CallOption) error {
@@ -478,7 +545,7 @@ func (h *httpClient) Stream(ctx context.Context, req client.Request, opts ...cli
 func (h *httpClient) Publish(ctx context.Context, p client.Message, opts ...client.PublishOption) error {
 	options := client.NewPublishOptions(opts...)
 
-	md, ok := metadata.FromContext(ctx)
+	md, ok := metadata.FromOutgoingContext(ctx)
 	if !ok {
 		md = metadata.New(2)
 	}
@@ -540,17 +607,31 @@ func NewClient(opts ...client.Option) client.Client {
 		opts: options,
 	}
 
+	dialer, ok := options.Context.Value(httpDialerKey{}).(*net.Dialer)
+	if !ok {
+		dialer = &net.Dialer{
+			Timeout:   30 * time.Second,
+			KeepAlive: 30 * time.Second,
+		}
+	}
+
 	if httpcli, ok := options.Context.Value(httpClientKey{}).(*http.Client); ok {
 		rc.httpcli = httpcli
 	} else {
-		rc.httpcli = http.DefaultClient
+		// TODO customTransport := http.DefaultTransport.(*http.Transport).Clone()
+		tr := &http.Transport{
+			Proxy:                 http.ProxyFromEnvironment,
+			DialContext:           dialer.DialContext,
+			ForceAttemptHTTP2:     true,
+			MaxConnsPerHost:       100,
+			MaxIdleConns:          20,
+			IdleConnTimeout:       60 * time.Second,
+			TLSHandshakeTimeout:   10 * time.Second,
+			ExpectContinueTimeout: 1 * time.Second,
+			TLSClientConfig:       options.TLSConfig,
+		}
+		rc.httpcli = &http.Client{Transport: tr}
 	}
-	if dialer, ok := options.Context.Value(httpDialerKey{}).(*net.Dialer); ok {
-		rc.dialer = dialer
-	} else {
-		rc.dialer = &net.Dialer{}
-	}
-
 	c := client.Client(rc)
 
 	// wrap in reverse
@@ -560,38 +641,3 @@ func NewClient(opts ...client.Option) client.Client {
 
 	return c
 }
-
-func parseRsp(ctx context.Context, hrsp *http.Response, cf codec.Codec, rsp interface{}, opts client.CallOptions) error {
-	b, err := ioutil.ReadAll(hrsp.Body)
-	if err != nil {
-		return errors.InternalServerError("go.micro.client", err.Error())
-	}
-
-	if hrsp.StatusCode < 400 {
-		// unmarshal
-		if err := cf.Unmarshal(b, rsp); err != nil {
-			return errors.InternalServerError("go.micro.client", err.Error())
-		}
-		return nil
-	}
-
-	errmap, ok := opts.Context.Value(errorMapKey{}).(map[string]interface{})
-	if !ok || errmap == nil {
-		// user not provide map of errors
-		// id: req.Service() ??
-		return errors.New("go.micro.client", string(b), int32(hrsp.StatusCode))
-	}
-
-	if err, ok = errmap[fmt.Sprintf("%d", hrsp.StatusCode)].(error); !ok {
-		err, ok = errmap["default"].(error)
-	}
-	if !ok {
-		return errors.New("go.micro.client", string(b), int32(hrsp.StatusCode))
-	}
-
-	if cerr := cf.Unmarshal(b, err); cerr != nil {
-		return errors.InternalServerError("go.micro.client", cerr.Error())
-	}
-
-	return err
-}

http_test.go

@@ -15,7 +15,7 @@ type Request struct {
 
 func TestValidPath(t *testing.T) {
 	req := &Request{Name: "vtolstov", Field1: "field1", Field2: "field2", Field3: 10}
-	p, m, err := newPathRequest("/api/v1/{name}/list", "GET", "", req)
+	p, m, err := newPathRequest("/api/v1/{name}/list", "GET", "", req, nil)
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -32,7 +32,7 @@ func TestValidPath(t *testing.T) {
 
 func TestInvalidPath(t *testing.T) {
 	req := &Request{Name: "vtolstov", Field1: "field1", Field2: "field2", Field3: 10}
-	p, m, err := newPathRequest("/api/v1/{xname}/list", "GET", "", req)
+	p, m, err := newPathRequest("/api/v1/{xname}/list", "GET", "", req, nil)
 	if err == nil {
 		t.Fatalf("path param must not be filled")
 	}

options.go

@@ -1,7 +1,6 @@
 package http
 
 import (
-	"crypto/tls"
 	"net"
 	"net/http"
 
@@ -33,28 +32,21 @@ type tlsAuth struct{}
 type maxRecvMsgSizeKey struct{}
 type maxSendMsgSizeKey struct{}
 
-// maximum streams on a connectioin
+// PoolMaxStreams maximum streams on a connectioin
 func PoolMaxStreams(n int) client.Option {
 	return client.SetOption(poolMaxStreams{}, n)
 }
 
-// maximum idle conns of a pool
+// PoolMaxIdle maximum idle conns of a pool
 func PoolMaxIdle(d int) client.Option {
 	return client.SetOption(poolMaxIdle{}, d)
 }
 
-// AuthTLS should be used to setup a secure authentication using TLS
-func AuthTLS(t *tls.Config) client.Option {
-	return client.SetOption(tlsAuth{}, t)
-}
-
-//
 // MaxRecvMsgSize set the maximum size of message that client can receive.
 func MaxRecvMsgSize(s int) client.Option {
 	return client.SetOption(maxRecvMsgSizeKey{}, s)
 }
 
-//
 // MaxSendMsgSize set the maximum size of message that client can send.
 func MaxSendMsgSize(s int) client.Option {
 	return client.SetOption(maxSendMsgSizeKey{}, s)
@@ -95,3 +87,9 @@ type errorMapKey struct{}
 func ErrorMap(m map[string]interface{}) client.CallOption {
 	return client.SetCallOption(errorMapKey{}, m)
 }
+
+type structTagsKey struct{}
+
+func StructTags(tags []string) client.CallOption {
+	return client.SetCallOption(structTagsKey{}, tags)
+}

stream.go

@@ -18,7 +18,8 @@ type httpStream struct {
 	sync.RWMutex
 	address string
 	opts    client.CallOptions
-	codec   codec.Codec
+	ct      string
+	cf      codec.Codec
 	context context.Context
 	header  http.Header
 	seq     uint64
@@ -63,7 +64,7 @@ func (h *httpStream) Send(msg interface{}) error {
 		return errShutdown
 	}
 
-	hreq, err := newRequest(h.address, h.request, h.codec, msg, h.opts)
+	hreq, err := newRequest(h.address, h.request, h.ct, h.cf, msg, h.opts)
 	if err != nil {
 		return err
 	}
@@ -88,7 +89,7 @@ func (h *httpStream) Recv(msg interface{}) error {
 	}
 	defer hrsp.Body.Close()
 
-	return parseRsp(h.context, hrsp, h.codec, msg, h.opts)
+	return parseRsp(h.context, hrsp, h.cf, msg, h.opts)
 }
 
 func (h *httpStream) Error() error {

util.go

@@ -1,12 +1,17 @@
 package http
 
 import (
+	"context"
 	"fmt"
+	"io/ioutil"
 	"net/http"
 	"reflect"
 	"strings"
 	"sync"
 
+	"github.com/unistack-org/micro/v3/client"
+	"github.com/unistack-org/micro/v3/codec"
+	"github.com/unistack-org/micro/v3/errors"
 	rutil "github.com/unistack-org/micro/v3/util/reflect"
 	util "github.com/unistack-org/micro/v3/util/router"
 )
@@ -16,13 +21,17 @@ var (
 	mu            sync.RWMutex
 )
 
-func newPathRequest(path string, method string, body string, msg interface{}) (string, interface{}, error) {
+func newPathRequest(path string, method string, body string, msg interface{}, tags []string) (string, interface{}, error) {
 	// parse via https://github.com/googleapis/googleapis/blob/master/google/api/http.proto definition
 	tpl, err := newTemplate(path)
 	if err != nil {
 		return "", nil, err
 	}
 
+	if len(tpl.Fields) > 0 && msg == nil {
+		return "", nil, fmt.Errorf("nil message but path params requested: %v", path)
+	}
+
 	fieldsmap := make(map[string]string, len(tpl.Fields))
 	for _, v := range tpl.Fields {
 		fieldsmap[v] = ""
@@ -52,20 +61,49 @@ func newPathRequest(path string, method string, body string, msg interface{}) (s
 			continue
 		}
 		fld := tmsg.Type().Field(i)
-		lfield := strings.ToLower(fld.Name)
+
-		if _, ok := fieldsmap[lfield]; ok {
+		t := &tag{}
-			fieldsmap[lfield] = fmt.Sprintf("%v", val.Interface())
+		for _, tn := range tags {
-		} else if (body == "*" || body == lfield) && method != http.MethodGet {
+			ts, ok := fld.Tag.Lookup(tn)
+			if !ok {
+				continue
+			}
+
+			tp := strings.Split(ts, ",")
+			// special
+			switch tn {
+			case "protobuf": // special
+				t = &tag{key: tn, name: tp[3][5:], opts: append(tp[:3], tp[4:]...)}
+			default:
+				t = &tag{key: tn, name: tp[0], opts: tp[1:]}
+			}
+			if t.name != "" {
+				break
+			}
+		}
+
+		if t.name == "" {
+			// fallback to lowercase
+			t.name = strings.ToLower(fld.Name)
+		}
+
+		if !val.IsValid() || val.IsZero() {
+			continue
+		}
+
+		if _, ok := fieldsmap[t.name]; ok {
+			fieldsmap[t.name] = fmt.Sprintf("%v", val.Interface())
+		} else if (body == "*" || body == t.name) && method != http.MethodGet {
 			tnmsg.Field(i).Set(val)
 		} else {
-			values[lfield] = fmt.Sprintf("%v", val.Interface())
+			values[t.name] = fmt.Sprintf("%v", val.Interface())
 		}
 	}
 
 	// check not filled stuff
 	for k, v := range fieldsmap {
 		if v == "" {
-			return "", nil, fmt.Errorf("path param %s not filled %s", k, v)
+			return "", nil, fmt.Errorf("path param %s not filled", k)
 		}
 	}
 
@@ -120,3 +158,44 @@ func newTemplate(path string) (util.Template, error) {
 
 	return tpl, nil
 }
+
+func parseRsp(ctx context.Context, hrsp *http.Response, cf codec.Codec, rsp interface{}, opts client.CallOptions) error {
+	b, err := ioutil.ReadAll(hrsp.Body)
+	if err != nil {
+		return errors.InternalServerError("go.micro.client", err.Error())
+	}
+
+	if hrsp.StatusCode < 400 {
+		// unmarshal
+		if err := cf.Unmarshal(b, rsp); err != nil {
+			return errors.InternalServerError("go.micro.client", err.Error())
+		}
+		return nil
+	}
+
+	errmap, ok := opts.Context.Value(errorMapKey{}).(map[string]interface{})
+	if !ok || errmap == nil {
+		// user not provide map of errors
+		// id: req.Service() ??
+		return errors.New("go.micro.client", string(b), int32(hrsp.StatusCode))
+	}
+
+	if err, ok = errmap[fmt.Sprintf("%d", hrsp.StatusCode)].(error); !ok {
+		err, ok = errmap["default"].(error)
+	}
+	if !ok {
+		return errors.New("go.micro.client", string(b), int32(hrsp.StatusCode))
+	}
+
+	if cerr := cf.Unmarshal(b, err); cerr != nil {
+		return errors.InternalServerError("go.micro.client", cerr.Error())
+	}
+
+	return err
+}
+
+type tag struct {
+	key  string
+	name string
+	opts []string
+}

util_test.go

@@ -5,10 +5,19 @@ import (
 	"testing"
 )
 
+func TestTemplate(t *testing.T) {
+	tpl, err := newTemplate("/v1/{ClientID}/list")
+	if err != nil {
+		t.Fatal(err)
+	}
+	_ = tpl
+	//	fmt.Printf("%#+v\n", tpl.Pool)
+}
+
 func TestNewPathRequest(t *testing.T) {
 	type Message struct {
-		Name string
+		Name string `json:"name"`
-		Val1 string
+		Val1 string `protobuf:"bytes,1,opt,name=val1,proto3" json:"val1"`
 		Val2 int64
 		Val3 []string
 	}
@@ -16,7 +25,8 @@ func TestNewPathRequest(t *testing.T) {
 	omsg := &Message{Name: "test_name", Val1: "test_val1", Val2: 100, Val3: []string{"slice"}}
 
 	for _, m := range []string{"POST", "PUT", "PATCH", "GET", "DELETE"} {
-		path, nmsg, err := newPathRequest("/v1/test", m, "", omsg)
+		body := ""
+		path, nmsg, err := newPathRequest("/v1/test", m, body, omsg, []string{"protobuf", "json"})
 		if err != nil {
 			t.Fatal(err)
 		}
@@ -26,7 +36,46 @@ func TestNewPathRequest(t *testing.T) {
 		}
 		vals := u.Query()
 		if v, ok := vals["name"]; !ok || v[0] != "test_name" {
-			t.Fatalf("invlid path: %v nmsg: %v", path, nmsg)
+			t.Fatalf("invalid path: %v nmsg: %v", path, nmsg)
+		}
+	}
+}
+
+func TestNewPathVarRequest(t *testing.T) {
+	type Message struct {
+		Name string `json:"name"`
+		Val1 string `protobuf:"bytes,1,opt,name=val1,proto3" json:"val1"`
+		Val2 int64
+		Val3 []string
+	}
+
+	omsg := &Message{Name: "test_name", Val1: "test_val1", Val2: 100, Val3: []string{"slice"}}
+
+	for _, m := range []string{"POST", "PUT", "PATCH", "GET", "DELETE"} {
+		body := ""
+		if m != "GET" {
+			body = "*"
+		}
+		path, nmsg, err := newPathRequest("/v1/test/{val1}", m, body, omsg, []string{"protobuf", "json"})
+		if err != nil {
+			t.Fatal(err)
+		}
+		u, err := url.Parse(path)
+		if err != nil {
+			t.Fatal(err)
+		}
+		if m != "GET" {
+			if _, ok := nmsg.(*Message); !ok {
+				t.Fatalf("invalid nmsg: %#+v\n", nmsg)
+			}
+			if nmsg.(*Message).Name != "test_name" {
+				t.Fatalf("invalid nmsg: %v nmsg: %v", path, nmsg)
+			}
+		} else {
+			vals := u.Query()
+			if v, ok := vals["val2"]; !ok || v[0] != "100" {
+				t.Fatalf("invalid path: %v nmsg: %v", path, nmsg)
+			}
 		}
 	}
 }