simplify

Signed-off-by: Vasiliy Tolstov <v.tolstov@unistack.org>

codec_test.go

@@ -0,0 +1,19 @@
+package proto
+
+import (
+	"bytes"
+	"testing"
+)
+
+func TestReadBody(t *testing.T) {
+	t.Skip("skip as no proto")
+	s := &struct {
+		Name string
+	}{}
+	c := NewCodec()
+	b := bytes.NewReader(nil)
+	err := c.ReadBody(b, s)
+	if err != nil {
+		t.Fatal(err)
+	}
+}

go.mod

@@ -3,6 +3,6 @@ module github.com/unistack-org/micro-codec-proto/v3
 go 1.16
 
 require (
-	github.com/unistack-org/micro/v3 v3.3.13
+	github.com/unistack-org/micro/v3 v3.3.19
 	google.golang.org/protobuf v1.26.0
 )

go.sum

@@ -7,13 +7,13 @@ github.com/google/uuid v1.2.0/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+
 github.com/imdario/mergo v0.3.12/go.mod h1:jmQim1M+e3UYxmgPu/WyfjB3N3VflVyUjjjwH0dnCYA=
 github.com/patrickmn/go-cache v2.1.0+incompatible/go.mod h1:3Qf8kWWT7OJRJbdiICTKqZju1ZixQ/KpMGzzAfe6+WQ=
 github.com/silas/dag v0.0.0-20210121180416-41cf55125c34/go.mod h1:7RTUFBdIRC9nZ7/3RyRNH1bdqIShrDejd1YbLwgPS+I=
-github.com/unistack-org/micro/v3 v3.3.13 h1:y4bDDkbwnjgOckrhFkC6D/o42tr75X33UbrB+Ko0M68=
-github.com/unistack-org/micro/v3 v3.3.13/go.mod h1:98hNcMXp/WyWJwLwCuwrhN1Jm7aCWaRNsMfRjK8Fq+Y=
-golang.org/x/net v0.0.0-20210405180319-a5a99cb37ef4/go.mod h1:p54w0d4576C0XHj96bSt6lcn1PtDYWL6XObtHCRCNQM=
+github.com/unistack-org/micro/v3 v3.3.19 h1:x0bl4H+IZvdHHKfA8qMcox9W92+e7rtbqgRfQPoP79w=
+github.com/unistack-org/micro/v3 v3.3.19/go.mod h1:LXmPfbJnJNvL0kQs8HfnkV3Wya2Wb+C7keVq++RCZnk=
+golang.org/x/net v0.0.0-20210510120150-4163338589ed/go.mod h1:9nx3DQGgdP8bBQD5qxJ1jj9UTztislL4KSBs9R2vV5Y=
 golang.org/x/sys v0.0.0-20201119102817-f84b799fce68/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
-golang.org/x/sys v0.0.0-20210330210617-4fbd30eecc44/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
+golang.org/x/sys v0.0.0-20210423082822-04245dca01da/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
 golang.org/x/term v0.0.0-20201126162022-7de9c90e9dd1/go.mod h1:bj7SfCRtBDWHUb9snDiAeCFNEtKQo2Wmx5Cou7ajbmo=
-golang.org/x/text v0.3.3/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ=
+golang.org/x/text v0.3.6/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ=
 golang.org/x/tools v0.0.0-20180917221912-90fa682c2a6e/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ=
 golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543 h1:E7g+9GITq07hpfrRu66IVDexMakfv52eLZ2CXBWiKr4=
 golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=

proto.go

@@ -3,14 +3,18 @@ package proto
 
 import (
 	"io"
-	"io/ioutil"
 
 	"github.com/unistack-org/micro/v3/codec"
+	rutil "github.com/unistack-org/micro/v3/util/reflect"
 	"google.golang.org/protobuf/proto"
 )
 
 type protoCodec struct{}
 
+const (
+	flattenTag = "flatten"
+)
+
 func (c *protoCodec) Marshal(v interface{}) ([]byte, error) {
 	switch m := v.(type) {
 	case nil:
@@ -18,13 +22,18 @@ func (c *protoCodec) Marshal(v interface{}) ([]byte, error) {
 	case *codec.Frame:
 		return m.Data, nil
 	case proto.Message:
+		if nv, nerr := rutil.StructFieldByTag(v, codec.DefaultTagName, flattenTag); nerr == nil {
+			if nm, ok := nv.(proto.Message); ok {
+				m = nm
+			}
+		}
 		return proto.Marshal(m)
 	}
 	return nil, codec.ErrInvalidMessage
 }
 
 func (c *protoCodec) Unmarshal(d []byte, v interface{}) error {
-	if d == nil {
+	if len(d) == 0 {
 		return nil
 	}
 	switch m := v.(type) {
@@ -33,6 +42,11 @@ func (c *protoCodec) Unmarshal(d []byte, v interface{}) error {
 	case *codec.Frame:
 		m.Data = d
 	case proto.Message:
+		if nv, nerr := rutil.StructFieldByTag(v, codec.DefaultTagName, flattenTag); nerr == nil {
+			if nm, ok := nv.(proto.Message); ok {
+				m = nm
+			}
+		}
 		return proto.Unmarshal(d, m)
 	}
 	return codec.ErrInvalidMessage
@@ -42,46 +56,34 @@ func (c *protoCodec) ReadHeader(conn io.Reader, m *codec.Message, t codec.Messag
 	return nil
 }
 
-func (c *protoCodec) ReadBody(conn io.Reader, b interface{}) error {
-	switch m := b.(type) {
-	case nil:
+func (c *protoCodec) ReadBody(conn io.Reader, v interface{}) error {
+	if v == nil {
 		return nil
-	case *codec.Frame:
-		buf, err := ioutil.ReadAll(conn)
-		if err != nil {
-			return err
-		}
-		m.Data = buf
-		return nil
-	case proto.Message:
-		buf, err := ioutil.ReadAll(conn)
-		if err != nil {
-			return err
-		} else if buf == nil {
-			return nil
-		}
-		return proto.Unmarshal(buf, m)
-	}
-	return codec.ErrInvalidMessage
 	}
 
-func (c *protoCodec) Write(conn io.Writer, m *codec.Message, b interface{}) error {
-	switch m := b.(type) {
-	case nil:
-		return nil
-	case *codec.Frame:
-		_, err := conn.Write(m.Data)
-		return err
-	case proto.Message:
-		buf, err := proto.Marshal(m)
+	buf, err := io.ReadAll(conn)
 	if err != nil {
 		return err
+	} else if len(buf) == 0 {
+		return nil
+	}
+	return c.Unmarshal(buf, v)
+}
+
+func (c *protoCodec) Write(conn io.Writer, m *codec.Message, v interface{}) error {
+	if v == nil {
+		return nil
+	}
+
+	buf, err := c.Marshal(v)
+	if err != nil {
+		return err
+	} else if len(buf) == 0 {
+		return codec.ErrInvalidMessage
 	}
 	_, err = conn.Write(buf)
 	return err
 }
-	return codec.ErrInvalidMessage
-}
 
 func (c *protoCodec) String() string {
 	return "proto"