2 Commits

Author SHA1 Message Date
8ecea8221f fix nil buf check
Signed-off-by: Vasiliy Tolstov <v.tolstov@unistack.org>
2021-04-12 19:17:01 +03:00
adbd069875 add test file
Signed-off-by: Vasiliy Tolstov <v.tolstov@unistack.org>
2021-04-12 17:15:45 +03:00
4 changed files with 43 additions and 2 deletions

18
json/codec_test.go Normal file
View File

@@ -0,0 +1,18 @@
package json
import (
"bytes"
"testing"
)
func TestReadBody(t *testing.T) {
s := &struct {
Name string
}{}
c := NewCodec()
b := bytes.NewReader(nil)
err := c.ReadBody(b, s)
if err != nil {
t.Fatal(err)
}
}

View File

@@ -53,7 +53,7 @@ func (c *jsonCodec) Marshal(b interface{}) ([]byte, error) {
} }
func (c *jsonCodec) Unmarshal(b []byte, v interface{}) error { func (c *jsonCodec) Unmarshal(b []byte, v interface{}) error {
if b == nil { if len(b) == 0 {
return nil return nil
} }
switch m := v.(type) { switch m := v.(type) {
@@ -80,6 +80,8 @@ func (c *jsonCodec) ReadBody(conn io.Reader, b interface{}) error {
buf, err := ioutil.ReadAll(conn) buf, err := ioutil.ReadAll(conn)
if err != nil { if err != nil {
return err return err
} else if len(buf) == 0 {
return nil
} }
m.Data = buf m.Data = buf
return nil return nil

19
proto/codec_test.go Normal file
View File

@@ -0,0 +1,19 @@
package proto
import (
"bytes"
"testing"
)
func TestReadBody(t *testing.T) {
t.Skip("no proto generated")
s := &struct {
Name string
}{}
c := NewCodec()
b := bytes.NewReader(nil)
err := c.ReadBody(b, s)
if err != nil {
t.Fatal(err)
}
}

View File

@@ -54,6 +54,8 @@ func (c *protoCodec) ReadBody(conn io.Reader, b interface{}) error {
buf, err := ioutil.ReadAll(conn) buf, err := ioutil.ReadAll(conn)
if err != nil { if err != nil {
return err return err
} else if len(buf) == 0 {
return nil
} }
m.Data = buf m.Data = buf
return nil return nil
@@ -61,7 +63,7 @@ func (c *protoCodec) ReadBody(conn io.Reader, b interface{}) error {
buf, err := ioutil.ReadAll(conn) buf, err := ioutil.ReadAll(conn)
if err != nil { if err != nil {
return err return err
} else if buf == nil { } else if len(buf) == 0 {
return nil return nil
} }
return proto.Unmarshal(buf, m) return proto.Unmarshal(buf, m)