1 Commits

Author SHA1 Message Date
5f9029c496 fixup conditions
Some checks failed
build / test (push) Has been cancelled
build / lint (push) Has been cancelled
codeql / analyze (go) (push) Has been cancelled
Signed-off-by: Vasiliy Tolstov <v.tolstov@unistack.org>
2024-01-15 02:02:50 +03:00
5 changed files with 49 additions and 38 deletions

25
flag.go
View File

@@ -1,4 +1,4 @@
package flag // import "go.unistack.org/micro-config-flag/v4" package flag // import "go.unistack.org/micro-config-flag/v3"
import ( import (
"context" "context"
@@ -10,9 +10,8 @@ import (
"strings" "strings"
"time" "time"
"go.unistack.org/micro/v4/config" "go.unistack.org/micro/v3/config"
"go.unistack.org/micro/v4/options" rutil "go.unistack.org/micro/v3/util/reflect"
rutil "go.unistack.org/micro/v4/util/reflect"
) )
var ( var (
@@ -40,7 +39,7 @@ func (c *flagConfig) Options() config.Options {
return c.opts return c.opts
} }
func (c *flagConfig) Init(opts ...options.Option) error { func (c *flagConfig) Init(opts ...config.Option) error {
for _, o := range opts { for _, o := range opts {
o(&c.opts) o(&c.opts)
} }
@@ -156,7 +155,11 @@ func (c *flagConfig) Init(opts ...options.Option) error {
return nil return nil
} }
func (c *flagConfig) Load(ctx context.Context, opts ...options.Option) error { func (c *flagConfig) Load(ctx context.Context, opts ...config.LoadOption) error {
if c.opts.SkipLoad != nil && c.opts.SkipLoad(ctx, c) {
return nil
}
options := config.NewLoadOptions(opts...) options := config.NewLoadOptions(opts...)
_ = options _ = options
@@ -174,7 +177,11 @@ func (c *flagConfig) Load(ctx context.Context, opts ...options.Option) error {
return nil return nil
} }
func (c *flagConfig) Save(ctx context.Context, opts ...options.Option) error { func (c *flagConfig) Save(ctx context.Context, opts ...config.SaveOption) error {
if c.opts.SkipSave != nil && c.opts.SkipSave(ctx, c) {
return nil
}
if err := config.DefaultBeforeSave(ctx, c); err != nil && !c.opts.AllowFail { if err := config.DefaultBeforeSave(ctx, c); err != nil && !c.opts.AllowFail {
return err return err
} }
@@ -194,7 +201,7 @@ func (c *flagConfig) Name() string {
return c.opts.Name return c.opts.Name
} }
func (c *flagConfig) Watch(ctx context.Context, opts ...options.Option) (config.Watcher, error) { func (c *flagConfig) Watch(ctx context.Context, opts ...config.WatchOption) (config.Watcher, error) {
return nil, fmt.Errorf("not implemented") return nil, fmt.Errorf("not implemented")
} }
@@ -309,7 +316,7 @@ func (c *flagConfig) configure() {
c.name = flagSetName c.name = flagSetName
} }
func NewConfig(opts ...options.Option) config.Config { func NewConfig(opts ...config.Option) config.Config {
options := config.NewOptions(opts...) options := config.NewOptions(opts...)
if len(options.StructTag) == 0 { if len(options.StructTag) == 0 {
options.StructTag = DefaultStructTag options.StructTag = DefaultStructTag

View File

@@ -7,7 +7,7 @@ import (
"testing" "testing"
"time" "time"
"go.unistack.org/micro/v4/config" "go.unistack.org/micro/v3/config"
) )
func TestLoad(t *testing.T) { func TestLoad(t *testing.T) {

6
go.mod
View File

@@ -1,10 +1,10 @@
module go.unistack.org/micro-config-flag/v4 module go.unistack.org/micro-config-flag/v3
go 1.18 go 1.18
require go.unistack.org/micro/v4 v4.0.5 require go.unistack.org/micro/v3 v3.10.36
require ( require (
github.com/google/uuid v1.3.0 // indirect github.com/google/uuid v1.5.0 // indirect
github.com/imdario/mergo v0.3.16 // indirect github.com/imdario/mergo v0.3.16 // indirect
) )

19
go.sum
View File

@@ -1,13 +1,16 @@
github.com/google/uuid v1.3.0 h1:t6JiXgmwXMjEs8VusXIJk2BXHsn+wx8BZdTaoZ5fu7I= github.com/google/uuid v1.5.0 h1:1p67kYwdtXjb0gL0BPiP1Av9wiZPo5A8z2cWkTZ+eyU=
github.com/google/uuid v1.3.0/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo= github.com/google/uuid v1.5.0/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
github.com/imdario/mergo v0.3.15 h1:M8XP7IuFNsqUx6VPK2P9OSmsYsI/YFaGil0uD21V3dM= github.com/imdario/mergo v0.3.13 h1:lFzP57bqS/wsqKssCGmtLAb8A0wKjLGrve2q3PPVcBk=
github.com/imdario/mergo v0.3.15/go.mod h1:WBLT9ZmE3lPoWsEzCh9LPo3TiwVN+ZKEjmz+hD27ysY= github.com/imdario/mergo v0.3.13/go.mod h1:4lJ1jqUDcsbIECGy0RUJAXNIhg+6ocWgb1ALK2O4oXg=
github.com/imdario/mergo v0.3.16 h1:wwQJbIsHYGMUyLSPrEq1CT16AhnhNJQ51+4fdHUnCl4= github.com/imdario/mergo v0.3.16 h1:wwQJbIsHYGMUyLSPrEq1CT16AhnhNJQ51+4fdHUnCl4=
github.com/imdario/mergo v0.3.16/go.mod h1:WBLT9ZmE3lPoWsEzCh9LPo3TiwVN+ZKEjmz+hD27ysY= github.com/imdario/mergo v0.3.16/go.mod h1:WBLT9ZmE3lPoWsEzCh9LPo3TiwVN+ZKEjmz+hD27ysY=
go.unistack.org/micro/v4 v4.0.1 h1:xo1IxbVfgh8i0eY0VeYa3cbb13u5n/Mxnp3FOgWD4Jo= github.com/patrickmn/go-cache v2.1.0+incompatible/go.mod h1:3Qf8kWWT7OJRJbdiICTKqZju1ZixQ/KpMGzzAfe6+WQ=
go.unistack.org/micro/v4 v4.0.1/go.mod h1:p/J5UcSJjfHsWGT31uKoghQ5rUQZzQJBAFy+Z4+ZVMs= github.com/silas/dag v0.0.0-20211117232152-9d50aa809f35/go.mod h1:7RTUFBdIRC9nZ7/3RyRNH1bdqIShrDejd1YbLwgPS+I=
go.unistack.org/micro/v4 v4.0.5 h1:uacmV8yHjCOtVfECc4w1tgp6bd3bBWrZa8X4iQLk48g= go.unistack.org/micro/v3 v3.10.16 h1:2er/SKKYbV60M+UuJM4eYCF0MZYAIq/yNUrAbTfgq8Q=
go.unistack.org/micro/v4 v4.0.5/go.mod h1:bVEYTlPi0EsdgZZt311bIroDg9ict7ky3C87dSCCAGk= go.unistack.org/micro/v3 v3.10.16/go.mod h1:uMAc0U/x7dmtICCrblGf0ZLgYegu3VwQAquu+OFCw1Q=
go.unistack.org/micro/v3 v3.10.36 h1:+XPhpguDC0HldSePp5TODdMJ06+IUy1AQkYN7ub84DA=
go.unistack.org/micro/v3 v3.10.36/go.mod h1:eUgtvbtiiz6te93m0ZdmoecbitWwjdBmmr84srmEIKA=
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0= gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
gopkg.in/yaml.v3 v3.0.0/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
gopkg.in/yaml.v3 v3.0.1 h1:fxVm/GzAzEWqLHuvctI91KS9hhNmmWOoWu0XTYJS7CA= gopkg.in/yaml.v3 v3.0.1 h1:fxVm/GzAzEWqLHuvctI91KS9hhNmmWOoWu0XTYJS7CA=
gopkg.in/yaml.v3 v3.0.1/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM= gopkg.in/yaml.v3 v3.0.1/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=

View File

@@ -3,61 +3,62 @@ package flag
import ( import (
"flag" "flag"
"go.unistack.org/micro/v4/options" "go.unistack.org/micro/v3/config"
) )
type sliceDelimKey struct{} type sliceDelimKey struct{}
// SliceDelim set the slice delimeter // SliceDelim set the slice delimeter
func SliceDelim(s string) options.Option { func SliceDelim(s string) config.Option {
return options.ContextOption(sliceDelimKey{}, s) return config.SetOption(sliceDelimKey{}, s)
} }
type mapDelimKey struct{} type mapDelimKey struct{}
// MapDelim set the map delimeter // MapDelim set the map delimeter
func MapDelim(s string) options.Option { func MapDelim(s string) config.Option {
return options.ContextOption(mapDelimKey{}, s) return config.SetOption(mapDelimKey{}, s)
} }
type timeFormatKey struct{} type timeFormatKey struct{}
// TimeFormat set the time format // TimeFormat set the time format
func TimeFormat(s string) options.Option { func TimeFormat(s string) config.Option {
return options.ContextOption(timeFormatKey{}, s) return config.SetOption(timeFormatKey{}, s)
} }
type flagSetKey struct{} type flagSetKey struct{}
// FlagSet set flag set name // FlagSet set flag set name
func FlagSet(f *flag.FlagSet) options.Option { func FlagSet(f *flag.FlagSet) config.Option {
return options.ContextOption(flagSetKey{}, f) return config.SetOption(flagSetKey{}, f)
} }
type flagSetNameKey struct{} type flagSetNameKey struct{}
// FlagSetName set flag set name // FlagSetName set flag set name
func FlagSetName(n string) options.Option { func FlagSetName(n string) config.Option {
return options.ContextOption(flagSetNameKey{}, n) return config.SetOption(flagSetNameKey{}, n)
} }
type flagSetErrorHandlingKey struct{} type flagSetErrorHandlingKey struct{}
// FlagErrorHandling set flag set error handling // FlagErrorHandling set flag set error handling
func FlagErrorHandling(eh flag.ErrorHandling) options.Option { func FlagErrorHandling(eh flag.ErrorHandling) config.Option {
return options.ContextOption(flagSetErrorHandlingKey{}, eh) return config.SetOption(flagSetErrorHandlingKey{}, eh)
} }
type flagSetUsageKey struct{} type flagSetUsageKey struct{}
// FlagUsage set flag set usage func // FlagUsage set flag set usage func
func FlagUsage(fn func()) options.Option { func FlagUsage(fn func()) config.Option {
return options.ContextOption(flagSetUsageKey{}, fn) return config.SetOption(flagSetUsageKey{}, fn)
} }
type flagEnvKey struct{} type flagEnvKey struct{}
// FlagEnv set flag set usage func // FlagEnv set flag set usage func
func FlagEnv(n string) options.Option { func FlagEnv(n string) config.Option {
return options.ContextOption(flagEnvKey{}, n) return config.SetOption(flagEnvKey{}, n)
} }