Merge pull request 'fix init with empty options' (#115) from initfix into v3

Reviewed-on: #115

vault.go

@@ -17,6 +17,9 @@ var DefaultStructTag = "vault"
 
 type vaultConfig struct {
 	path     string
+	token    string
+	roleID   string
+	secretID string
 	cli      *api.Client
 	opts     config.Options
 }
@@ -95,43 +98,38 @@ func (c *vaultConfig) Init(opts ...config.Option) error {
 	}
 	c.cli = cli
 	c.path = path
+	c.token = token
+	c.roleID = roleID
+	c.secretID = secretID
 
-	if token != "" {
+	if err = c.setToken(); err != nil && !c.opts.AllowFail {
-		cli.SetToken(token)
-
-		if err := config.DefaultAfterInit(c.opts.Context, c); err != nil && !c.opts.AllowFail {
 		return err
 	}
 
-		return nil
-
-	} else if roleID == "" || secretID == "" {
-		if !c.opts.AllowFail {
-			return fmt.Errorf("missing Token or RoleID and SecretID")
-		}
-
 	if err := config.DefaultAfterInit(c.opts.Context, c); err != nil && !c.opts.AllowFail {
 		return err
 	}
 
 	return nil
+}
+
+func (c *vaultConfig) setToken() error {
+	if c.token != "" {
+		c.cli.SetToken(c.token)
 	}
 
-	rsp, err := cli.Logical().Write("auth/approle/login", map[string]interface{}{
+	if c.roleID != "" && c.secretID != "" {
-		"role_id":   roleID,
+		rsp, err := c.cli.Logical().Write("auth/approle/login", map[string]interface{}{
-		"secret_id": secretID,
+			"role_id":   c.roleID,
+			"secret_id": c.secretID,
 		})
-
 		if err != nil {
 			if !c.opts.AllowFail {
 				return err
 			}
 		} else if err == nil {
-		cli.SetToken(rsp.Auth.ClientToken)
+			c.cli.SetToken(rsp.Auth.ClientToken)
 		}
-
-	if err := config.DefaultAfterInit(c.opts.Context, c); err != nil && !c.opts.AllowFail {
-		return err
 	}
 
 	return nil