Merge pull request #49 from unistack-org/labels_fix

fixup metric labels helper
This commit is contained in:
Василий Толстов 2021-10-31 14:47:22 +03:00 committed by GitHub
commit e33004352b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions

View File

@ -47,10 +47,10 @@ func (r *victoriametricsMeter) buildName(name string, labels ...string) string {
return meter.BuildName(name, nlabels...) return meter.BuildName(name, nlabels...)
} }
for idx := 0; idx <= len(nlabels)/2; idx += 2 { for idx := 0; idx < nl; idx++ {
nlabels[idx] = r.opts.LabelPrefix + nlabels[idx] nlabels[idx] = r.opts.LabelPrefix + nlabels[idx]
idx++
} }
return meter.BuildName(name, nlabels...) return meter.BuildName(name, nlabels...)
} }

View File

@ -14,8 +14,8 @@ import (
func TestBuildName(t *testing.T) { func TestBuildName(t *testing.T) {
m := NewMeter() m := NewMeter()
im := m.(*victoriametricsMeter) im := m.(*victoriametricsMeter)
check := `micro_foo{micro_aaa="b",micro_bar="baz"}` check := `micro_foo{micro_aaa="b",micro_bar="baz",micro_ccc="d"}`
name := im.buildName("foo", "bar", "baz", "aaa", "b") name := im.buildName("foo", "bar", "baz", "aaa", "b", "ccc", "d")
if name != check { if name != check {
t.Fatalf("metric name error: %s != %s", name, check) t.Fatalf("metric name error: %s != %s", name, check)
} }