Merge pull request #131 from unistack-org/dependabot/go_modules/go.unistack.org/micro/v3-3.10.42

Bump go.unistack.org/micro/v3 from 3.10.40 to 3.10.42

.github/workflows/autoapprove.yml

@@ -0,0 +1,20 @@
+name: "autoapprove"
+
+on:
+  pull_request_target:
+    types: [assigned, opened, synchronize, reopened]
+
+permissions:
+  pull-requests: write
+  contents: write
+
+jobs:
+  autoapprove:
+    runs-on: ubuntu-latest
+    steps:
+      - name: approve
+        uses: hmarr/auto-approve-action@v3
+        if: github.actor == 'vtolstov' || github.actor == 'dependabot[bot]'
+        id: approve
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/automerge.yml

@@ -0,0 +1,21 @@
+name: "automerge"
+
+on:
+  pull_request_target:
+    types: [assigned, opened, synchronize, reopened]
+
+permissions:
+  pull-requests: write
+  contents: write
+
+jobs:
+  automerge:
+    runs-on: ubuntu-latest
+    if: github.actor == 'vtolstov'
+    steps:
+      - name: merge
+        id: merge
+        run: gh pr merge --auto --merge "$PR_URL"
+        env:
+          PR_URL: ${{github.event.pull_request.html_url}}
+          GITHUB_TOKEN: ${{secrets.TOKEN}}

.github/workflows/build.yml

@@ -3,19 +3,20 @@ on:
  push:
     branches:
     - master
+    - v3
 jobs:
   test:
     name: test
     runs-on: ubuntu-latest
     steps:
     - name: setup
-      uses: actions/setup-go@v2
+      uses: actions/setup-go@v3
       with:
-        go-version: 1.16
+        go-version: 1.17
     - name: checkout
-      uses: actions/checkout@v2
+      uses: actions/checkout@v3.3.0
     - name: cache
-      uses: actions/cache@v2
+      uses: actions/cache@v3
       with:
         path: ~/go/pkg/mod
         key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
@@ -31,9 +32,9 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3.3.0
       - name: lint
-        uses: golangci/golangci-lint-action@v2
+        uses: golangci/golangci-lint-action@v3.4.0
         continue-on-error: true
         with:
           # Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version.

.github/workflows/codeql-analysis.yml

@@ -43,14 +43,14 @@ jobs:
 
     steps:
     - name: checkout
-      uses: actions/checkout@v2
+      uses: actions/checkout@v3.3.0
     - name: setup
-      uses: actions/setup-go@v2
+      uses: actions/setup-go@v3
       with:
-        go-version: 1.16
+        go-version: 1.17
     # Initializes the CodeQL tools for scanning.
     - name: init
-      uses: github/codeql-action/init@v1
+      uses: github/codeql-action/init@v2
       with:
         languages: ${{ matrix.language }}
         # If you wish to specify custom queries, you can do so here or in a config file.
@@ -61,7 +61,7 @@ jobs:
     # Autobuild attempts to build any compiled languages  (C/C++, C#, or Java).
     # If this step fails, then you should remove it and run the build manually (see below)
     - name: autobuild
-      uses: github/codeql-action/autobuild@v1
+      uses: github/codeql-action/autobuild@v2
 
     # ℹ️ Command-line programs to run using the OS shell.
     # 📚 https://git.io/JvXDl
@@ -75,4 +75,4 @@ jobs:
     #   make release
 
     - name: analyze
-      uses: github/codeql-action/analyze@v1
+      uses: github/codeql-action/analyze@v2

.github/workflows/dependabot-automerge.yml

@@ -1,4 +1,4 @@
-name: "prautomerge"
+name: "dependabot-automerge"
 
 on:
   pull_request_target:
@@ -9,21 +9,17 @@ permissions:
   contents: write
 
 jobs:
-  dependabot:
+  automerge:
     runs-on: ubuntu-latest
-    if: ${{ github.actor == 'dependabot[bot]' }}
+    if: github.actor == 'dependabot[bot]'
     steps:
       - name: metadata
         id: metadata
-        uses: dependabot/fetch-metadata@v1.1.1
+        uses: dependabot/fetch-metadata@v1.3.6
         with:
           github-token: "${{ secrets.TOKEN }}"
-      - name: approve
-        run: gh pr review --approve "$PR_URL"
-        env:
-          PR_URL: ${{github.event.pull_request.html_url}}
-          GITHUB_TOKEN: ${{secrets.TOKEN}}
       - name: merge
+        id: merge
         if: ${{contains(steps.metadata.outputs.dependency-names, 'go.unistack.org')}}
         run: gh pr merge --auto --merge "$PR_URL"
         env:

.github/workflows/pr.yml

@@ -3,19 +3,20 @@ on:
   pull_request:
     branches:
     - master
+    - v3
 jobs:
   test:
     name: test
     runs-on: ubuntu-latest
     steps:
     - name: setup
-      uses: actions/setup-go@v2
+      uses: actions/setup-go@v3
       with:
-        go-version: 1.16
+        go-version: 1.17
     - name: checkout
-      uses: actions/checkout@v2
+      uses: actions/checkout@v3.3.0
     - name: cache
-      uses: actions/cache@v2
+      uses: actions/cache@v3
       with:
         path: ~/go/pkg/mod
         key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
@@ -31,9 +32,9 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3.3.0
       - name: lint
-        uses: golangci/golangci-lint-action@v2
+        uses: golangci/golangci-lint-action@v3.4.0
         continue-on-error: true
         with:
           # Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version.

.github/workflows/push.yml

@@ -9,13 +9,13 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - name: setup
-      uses: actions/setup-go@v2
+      uses: actions/setup-go@v3
       with:
         go-version: 1.15
     - name: checkout
-      uses: actions/checkout@v2
+      uses: actions/checkout@v3.3.0
     - name: cache
-      uses: actions/cache@v2
+      uses: actions/cache@v3
       with:
         path: ~/go/pkg/mod
         key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
@@ -31,9 +31,9 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3.3.0
       - name: lint
-        uses: golangci/golangci-lint-action@v2
+        uses: golangci/golangci-lint-action@v3.4.0
         continue-on-error: true
         with:
           # Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version.

etcd.go

@@ -22,14 +22,9 @@ import (
 	"go.unistack.org/micro/v3/register"
 )
 
-const (
+var DefaultPrefix = "/micro/register/"
-	prefix        = "/micro/register/"
-	defaultDomain = "micro"
-)
 
-var (
+var _ register.Register = &etcdRegister{}
-	_ register.Register = &etcdRegister{}
-)
 
 type etcdRegister struct {
 	client  *clientv3.Client
@@ -41,8 +36,10 @@ type etcdRegister struct {
 	leases map[string]leases
 }
 
-type reg map[string]uint64
+type (
-type leases map[string]clientv3.LeaseID
+	reg    map[string]uint64
+	leases map[string]clientv3.LeaseID
+)
 
 // NewRegister returns an initialized etcd register
 func NewRegister(opts ...register.Option) *etcdRegister {
@@ -200,7 +197,7 @@ func serializeServiceName(s string) string {
 }
 
 func prefixWithDomain(domain string) string {
-	return path.Join(prefix, domain)
+	return path.Join(DefaultPrefix, domain)
 }
 
 func (e *etcdRegister) Init(opts ...register.Option) error {
@@ -227,13 +224,7 @@ func (e *etcdRegister) registerNode(s *register.Service, node *register.Node, op
 	}
 
 	// parse the options
-	var options register.RegisterOptions
+	options := register.NewRegisterOptions(opts...)
-	for _, o := range opts {
-		o(&options)
-	}
-	if len(options.Domain) == 0 {
-		options.Domain = defaultDomain
-	}
 
 	if s.Metadata == nil {
 		s.Metadata = map[string]string{}
@@ -402,13 +393,7 @@ func (e *etcdRegister) Deregister(ctx context.Context, s *register.Service, opts
 	}
 
 	// parse the options
-	var options register.DeregisterOptions
+	options := register.NewDeregisterOptions(opts...)
-	for _, o := range opts {
-		o(&options)
-	}
-	if len(options.Domain) == 0 {
-		options.Domain = defaultDomain
-	}
 
 	for _, node := range s.Nodes {
 		e.Lock()
@@ -465,19 +450,13 @@ func (e *etcdRegister) LookupService(ctx context.Context, name string, opts ...r
 	defer cancel()
 
 	// parse the options and fallback to the default domain
-	var options register.LookupOptions
+	options := register.NewLookupOptions(opts...)
-	for _, o := range opts {
-		o(&options)
-	}
-	if len(options.Domain) == 0 {
-		options.Domain = defaultDomain
-	}
 
 	var results []*mvccpb.KeyValue
 
 	// TODO: refactorout wildcard, this is an incredibly expensive operation
 	if options.Domain == register.WildcardDomain {
-		rsp, err := e.client.Get(ctx, prefix, clientv3.WithPrefix(), clientv3.WithSerializable())
+		rsp, err := e.client.Get(ctx, DefaultPrefix, clientv3.WithPrefix(), clientv3.WithSerializable())
 		if err != nil {
 			return nil, err
 		}
@@ -485,7 +464,7 @@ func (e *etcdRegister) LookupService(ctx context.Context, name string, opts ...r
 		// filter the results for the key we care about
 		for _, kv := range rsp.Kvs {
 			// if the key does not contain the name then pass
-			_, service, ok := getName(string(kv.Key), prefix)
+			_, service, ok := getName(string(kv.Key), DefaultPrefix)
 			if !ok || service != name {
 				continue
 			}
@@ -510,7 +489,7 @@ func (e *etcdRegister) LookupService(ctx context.Context, name string, opts ...r
 
 	for _, n := range results {
 		// only process the things we care about
-		domain, service, ok := getName(string(n.Key), prefix)
+		domain, service, ok := getName(string(n.Key), DefaultPrefix)
 		if !ok || service != name {
 			continue
 		}
@@ -545,22 +524,19 @@ func (e *etcdRegister) LookupService(ctx context.Context, name string, opts ...r
 func (e *etcdRegister) ListServices(ctx context.Context, opts ...register.ListOption) ([]*register.Service, error) {
 	// parse the options
 	options := register.NewListOptions(opts...)
-	if len(options.Domain) == 0 {
-		options.Domain = defaultDomain
-	}
 
 	// determine the prefix
 	var p string
 	if options.Domain == register.WildcardDomain {
-		p = prefix
+		p = DefaultPrefix
 	} else {
 		p = prefixWithDomain(options.Domain)
 	}
 
-	ctx, cancel := context.WithTimeout(context.Background(), e.options.Timeout)
+	nctx, cancel := context.WithTimeout(context.Background(), e.options.Timeout)
 	defer cancel()
 
-	rsp, err := e.client.Get(ctx, p, clientv3.WithPrefix(), clientv3.WithSerializable())
+	rsp, err := e.client.Get(nctx, p, clientv3.WithPrefix(), clientv3.WithSerializable())
 	if err != nil {
 		return nil, err
 	}
@@ -570,7 +546,7 @@ func (e *etcdRegister) ListServices(ctx context.Context, opts ...register.ListOp
 
 	versions := make(map[string]*register.Service)
 	for _, n := range rsp.Kvs {
-		domain, service, ok := getName(string(n.Key), prefix)
+		domain, service, ok := getName(string(n.Key), DefaultPrefix)
 		if !ok {
 			continue
 		}

go.mod

@@ -4,8 +4,8 @@ go 1.16
 
 require (
 	github.com/mitchellh/hashstructure v1.1.0
-	go.etcd.io/etcd/api/v3 v3.5.1
+	go.etcd.io/etcd/api/v3 v3.5.7
-	go.etcd.io/etcd/client/v3 v3.5.1
+	go.etcd.io/etcd/client/v3 v3.5.7
-	go.uber.org/zap v1.20.0
+	go.uber.org/zap v1.24.0
-	go.unistack.org/micro/v3 v3.8.20
+	go.unistack.org/micro/v3 v3.10.42
 )

watcher.go

@@ -21,20 +21,14 @@ type etcdWatcher struct {
 }
 
 func newEtcdWatcher(c *clientv3.Client, timeout time.Duration, opts ...register.WatchOption) (register.Watcher, error) {
-	var wo register.WatchOptions
+	wo := register.NewWatchOptions(opts...)
-	for _, o := range opts {
-		o(&wo)
-	}
-	if len(wo.Domain) == 0 {
-		wo.Domain = defaultDomain
-	}
 
-	watchPath := prefix
+	watchPath := DefaultPrefix
 	if wo.Domain == register.WildcardDomain {
 		if len(wo.Service) > 0 {
 			return nil, errors.New("Cannot watch a service across domains")
 		}
-		watchPath = prefix
+		watchPath = DefaultPrefix
 	} else if len(wo.Service) > 0 {
 		watchPath = servicePath(wo.Domain, wo.Service) + "/"
 	}