unistack-org/micro-server-grpc
4
0
Fork 2
Code Issues 5 Pull Requests Actions Packages Projects Releases 58 Wiki Activity

prepare v4 (need swap target!) #195

Merged
vtolstov merged 4 commits from devstigneev/micro-server-grpc:prepare_v4 into v4 2025-03-02 21:13:26 +03:00
Conversation 1 Commits 4 Files Changed 14 +99 -482
devstigneev commented 2025-02-26 21:34:14 +03:00
Member
Copy Link

Pull Request template

Please, go through these steps before clicking submit on this PR.

  1. Give a descriptive title to your PR.
  2. Provide a description of your changes.
  3. Make sure you have some relevant tests.
  4. Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if applicable).

PLEASE REMOVE THIS TEMPLATE BEFORE SUBMITTING

## Pull Request template Please, go through these steps before clicking submit on this PR. 1. Give a descriptive title to your PR. 2. Provide a description of your changes. 3. Make sure you have some relevant tests. 4. Put `closes #XXXX` in your comment to auto-close the issue that your PR fixes (if applicable). **PLEASE REMOVE THIS TEMPLATE BEFORE SUBMITTING**
devstigneev added 1 commit 2025-02-26 21:34:15 +03:00
prepare v4
Some checks failed
lint / lint (pull_request) Failing after 1m38s
Details
test / test (pull_request) Successful in 3m20s
Details
c0d186327e
vtolstov requested changes 2025-02-26 23:45:40 +03:00
go.mod
@@ -2,22 +2,21 @@ module go.unistack.org/micro-server-grpc/v3
vtolstov commented 2025-02-26 23:42:37 +03:00
Owner
Copy Link

v4

v4
grpc.go Outdated
@@ -252,3 +247,3 @@
md := metadata.New(len(gmd))
for k, v := range gmd {
md[k] = strings.Join(v, ", ")
md[k] = v
vtolstov commented 2025-02-26 23:43:12 +03:00
Owner
Copy Link

make & copy
https://pkg.go.dev/maps#Copy

make & copy https://pkg.go.dev/maps#Copy
👍 1
grpc.go Outdated
@@ -293,1 +285,4 @@
ct = ctype[0]
} else if ctype, ok := md.Get("x-content-type"); ok && len(ctype) > 0 {
ct = ctype[0]
md.Del("x-content-type")
vtolstov commented 2025-02-26 23:45:00 +03:00
Owner
Copy Link

x-content-type можно убирать вообще

x-content-type можно убирать вообще
👍 1
devstigneev added 1 commit 2025-02-27 18:44:17 +03:00
correcting grpc.go
Some checks failed
lint / lint (pull_request) Failing after 1m22s
Details
test / test (pull_request) Successful in 2m23s
Details
8578b74e33
devstigneev added 1 commit 2025-02-27 21:02:52 +03:00
udpate deps
Some checks failed
lint / lint (pull_request) Failing after 1m13s
Details
test / test (pull_request) Successful in 2m10s
Details
80bf955eeb
vtolstov changed target branch from v3 to v4 2025-03-02 21:06:14 +03:00
vtolstov added 1 commit 2025-03-02 21:10:59 +03:00
update
All checks were successful
lint / lint (pull_request) Successful in 1m16s
Details
test / test (pull_request) Successful in 2m1s
Details
171d246752 
Signed-off-by: Vasiliy Tolstov <v.tolstov@unistack.org>
vtolstov merged commit 23a1ff424e into v4 2025-03-02 21:13:26 +03:00
vtolstov deleted branch prepare_v4 2025-03-02 21:13:26 +03:00
Sign in to join this conversation.
Reviewers
No Reviewers
vtolstov
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
atolstikhin devstigneev pugnack vtolstov
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unistack-org/micro-server-grpc#195
No description provided.
Delete Branch "devstigneev/micro-server-grpc:prepare_v4"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?