unistack-org/micro-server-http
4
0
Fork 2
Code Issues 5 Pull Requests Actions Packages Projects Releases 124 Wiki Activity

issue_179 #180

Merged
vtolstov merged 6 commits from devstigneev/micro-server-http:issue_179 into master 2024-03-08 23:05:32 +03:00
Conversation 2 Commits 6 Files Changed 5 +79 -53
devstigneev commented 2024-03-07 18:17:47 +03:00
Member
Copy Link

closes #179

closes #179
devstigneev added 3 commits 2024-03-07 18:17:47 +03:00
removed using http.Serve and add using *http.Server + Shutdown 1d5142d619
removed Listener.Stop 41d7d145ce
removed comments code 49608197d0
devstigneev commented 2024-03-07 18:20:38 +03:00
Author
Member
Copy Link

В чем суть:

Использовался метод http.Serve, который создавал http.Server и не было доступа к полям http.Server

Логику http.Serve поднял на уровень нашего метода Старт и использовал

Так же позволило использовать метод Shutdown который по сути может закрыть эту задачу + можно использовать контекст попробовать

В чем суть: Использовался метод http.Serve, который создавал http.Server и не было доступа к полям http.Server Логику http.Serve поднял на уровень нашего метода Старт и использовал Так же позволило использовать метод Shutdown который по сути может закрыть эту задачу + можно использовать контекст попробовать
devstigneev added 1 commit 2024-03-08 17:58:28 +03:00
update micro version and add gracefulTimeout && update log msg ea8c9dd22e
devstigneev added 1 commit 2024-03-08 18:00:12 +03:00
sent err to channel 1432587369
devstigneev added 1 commit 2024-03-08 18:03:59 +03:00
fix logmessages 2e8462a0f1
vtolstov approved these changes 2024-03-08 23:05:18 +03:00
vtolstov merged commit 28eeca30c0 into master 2024-03-08 23:05:32 +03:00
vtolstov deleted branch issue_179 2024-03-08 23:05:35 +03:00
Sign in to join this conversation.
Reviewers
No Reviewers
vtolstov
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
atolstikhin devstigneev pugnack vtolstov
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unistack-org/micro-server-http#180
Delete Branch "devstigneev/micro-server-http:issue_179"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?