.github/workflows/build.yml

@@ -12,7 +12,7 @@ jobs:
     - name: setup
       uses: actions/setup-go@v3
       with:
-        go-version: 1.21
+        go-version: 1.17
     - name: checkout
       uses: actions/checkout@v3
     - name: cache

.github/workflows/pr.yml

@@ -12,7 +12,7 @@ jobs:
     - name: setup
       uses: actions/setup-go@v3
       with:
-        go-version: 1.20
+        go-version: 1.17
     - name: checkout
       uses: actions/checkout@v3
     - name: cache

go.mod

@@ -4,7 +4,7 @@ go 1.20
 
 require (
 	github.com/opentracing/opentracing-go v1.2.0
-	go.unistack.org/micro/v4 v4.0.13
+	go.unistack.org/micro/v4 v4.0.10
 )
 
 require github.com/stretchr/testify v1.8.3 // indirect

go.sum

@@ -8,6 +8,6 @@ github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+
 github.com/stretchr/testify v1.3.0/go.mod h1:M5WIy9Dh21IEIfnGCwXGc5bZfKNJtfHm1UVUgZn+9EI=
 github.com/stretchr/testify v1.8.3 h1:RP3t2pwF7cMEbC1dqtB6poj3niw/9gnV4Cjg5oW5gtY=
 github.com/stretchr/testify v1.8.3/go.mod h1:sz/lmYIOXD/1dqDmKjjqLyZ2RngseejIcXlSw2iwfAo=
-go.unistack.org/micro/v4 v4.0.13 h1:wyprk+KNAv/zR6bri6p6ucmXcJ9WyZ/vzru4zjPd8dA=
-go.unistack.org/micro/v4 v4.0.13/go.mod h1:ZDgU9931vm2l7X6RN/6UuwRIVp24GRdmQ7dKmegArk4=
+go.unistack.org/micro/v4 v4.0.10 h1:uKqED/n/zrJd4NGxm9OOUw26UMibgYFhf89MOTnM1go=
+go.unistack.org/micro/v4 v4.0.10/go.mod h1:QT3gOIE4qGgBiQGm2Pad/62Sl5R53QfrgYHD448aX14=
 gopkg.in/yaml.v3 v3.0.1 h1:fxVm/GzAzEWqLHuvctI91KS9hhNmmWOoWu0XTYJS7CA=

opentracing.go

@@ -10,7 +10,6 @@ import (
 	"go.unistack.org/micro/v4/metadata"
 	"go.unistack.org/micro/v4/options"
 	"go.unistack.org/micro/v4/tracer"
-	rutil "go.unistack.org/micro/v4/util/reflect"
 )
 
 var _ tracer.Tracer = &otTracer{}
@@ -30,9 +29,7 @@ func (t *otTracer) Flush(ctx context.Context) error {
 
 func (t *otTracer) Init(opts ...options.Option) error {
 	for _, o := range opts {
-		if err := o(&t.opts); err != nil {
-			return err
-		}
+		o(&t.opts)
 	}
 
 	if tr, ok := t.opts.Context.Value(tracerKey{}).(ot.Tracer); ok {
@@ -44,11 +41,6 @@ func (t *otTracer) Init(opts ...options.Option) error {
 	return nil
 }
 
-type spanContext interface {
-	TraceID() idStringer
-	SpanID() idStringer
-}
-
 func (t *otTracer) Start(ctx context.Context, name string, opts ...options.Option) (context.Context, tracer.Span) {
 	options := tracer.NewSpanOptions(opts...)
 	var span ot.Span
@@ -62,50 +54,17 @@ func (t *otTracer) Start(ctx context.Context, name string, opts ...options.Optio
 	case tracer.SpanKindServer, tracer.SpanKindConsumer:
 		ctx, span = t.startSpanFromIncomingContext(ctx, name)
 	}
-
 	sp := &otSpan{span: span, opts: options}
-
-	spctx := span.Context()
-	if v, ok := spctx.(spanContext); ok {
-		sp.traceID = v.TraceID().String()
-		sp.spanID = v.SpanID().String()
-	} else {
-		if val, err := rutil.StructFieldByName(spctx, "TraceID"); err == nil {
-			sp.traceID = fmt.Sprintf("%v", val)
-		}
-		if val, err := rutil.StructFieldByName(spctx, "SpanID"); err == nil {
-			sp.spanID = fmt.Sprintf("%v", val)
-		}
-	}
-
 	return tracer.NewSpanContext(ctx, sp), sp
 }
 
-type idStringer struct {
-	s string
-}
-
-func (s idStringer) String() string {
-	return s.s
-}
-
 type otSpan struct {
 	span      ot.Span
-	spanID    string
-	traceID   string
 	opts      tracer.SpanOptions
 	status    tracer.SpanStatus
 	statusMsg string
 }
 
-func (os *otSpan) TraceID() string {
-	return os.traceID
-}
-
-func (os *otSpan) SpanID() string {
-	return os.spanID
-}
-
 func (os *otSpan) SetStatus(st tracer.SpanStatus, msg string) {
 	os.status = st
 	os.statusMsg = msg
@@ -119,38 +78,26 @@ func (os *otSpan) Tracer() tracer.Tracer {
 	return &otTracer{tracer: os.span.Tracer()}
 }
 
-func (os *otSpan) AddLogs(kv ...interface{}) {
-	os.span.LogKV(kv...)
-}
-
 func (os *otSpan) Finish(opts ...options.Option) {
 	if len(os.opts.Labels)%2 != 0 {
 		os.opts.Labels = os.opts.Labels[:len(os.opts.Labels)-1]
 	}
 	os.opts.Labels = tracer.UniqLabels(os.opts.Labels)
 	for idx := 0; idx < len(os.opts.Labels); idx += 2 {
-		k, ok := os.opts.Labels[idx].(string)
-		if !ok {
-			continue
-		}
-		v, ok := os.opts.Labels[idx+1].(string)
-		if !ok {
-			v = fmt.Sprintf("%v", os.opts.Labels[idx+1])
-		}
-		switch k {
+		switch os.opts.Labels[idx] {
 		case "err":
 			os.status = tracer.SpanStatusError
-			os.statusMsg = v
+			os.statusMsg = fmt.Sprintf("%v", os.opts.Labels[idx+1])
 		case "error":
 			continue
 		case "X-Request-Id", "x-request-id":
-			os.span.SetTag("x-request-id", v)
+			os.span.SetTag("x-request-id", os.opts.Labels[idx+1])
 		case "rpc.call", "rpc.call_type", "rpc.flavor", "rpc.service", "rpc.method",
 			"sdk.database", "db.statement", "db.args", "db.query", "db.method",
 			"messaging.destination.name", "messaging.source.name", "messaging.operation":
-			os.span.SetTag(k, v)
+			os.span.SetTag(fmt.Sprintf("%v", os.opts.Labels[idx]), os.opts.Labels[idx+1])
 		default:
-			os.span.LogKV(k, v)
+			os.span.LogKV(os.opts.Labels[idx], os.opts.Labels[idx+1])
 		}
 	}
 	if os.status == tracer.SpanStatusError {
@@ -190,6 +137,10 @@ func NewTracer(opts ...options.Option) *otTracer {
 	return &otTracer{opts: options}
 }
 
+func spanFromContext(ctx context.Context) ot.Span {
+	return ot.SpanFromContext(ctx)
+}
+
 func (t *otTracer) startSpanFromAny(ctx context.Context, name string, opts ...ot.StartSpanOption) (context.Context, ot.Span) {
 	if tracerSpan, ok := tracer.SpanFromContext(ctx); ok && tracerSpan != nil {
 		return t.startSpanFromContext(ctx, name, opts...)

opentracing_test.go

@@ -2,31 +2,49 @@ package opentracing
 
 import (
 	"context"
+	"sync"
 	"testing"
 
-	"github.com/opentracing/opentracing-go/mocktracer"
+	opentracing "github.com/opentracing/opentracing-go"
 	"go.unistack.org/micro/v4/metadata"
-	"go.unistack.org/micro/v4/tracer"
 )
 
-func TestTraceID(t *testing.T) {
-	md := metadata.New(1)
+func TestStartSpanFromIncomingContext(t *testing.T) {
+	md := metadata.New(2)
+	md.Set("key", "val")
+
+	var g sync.WaitGroup
+
 	ctx, cancel := context.WithCancel(context.Background())
 	defer cancel()
 	ctx = metadata.NewIncomingContext(ctx, md)
 
-	tr := NewTracer(Tracer(mocktracer.New()))
-	if err := tr.Init(); err != nil {
+	tracer := opentracing.GlobalTracer()
+
+	g.Add(8000)
+	cherr := make(chan error)
+	for i := 0; i < 8000; i++ {
+		go func() {
+			defer g.Done()
+			_, sp, err := startSpanFromIncomingContext(ctx, tracer, "test")
+			if err != nil {
+				cherr <- err
+			}
+			sp.Finish()
+		}()
+	}
+
+	for {
+		select {
+		default:
+			g.Wait()
+			close(cherr)
+		case err, ok := <-cherr:
+			if err != nil {
 				t.Fatal(err)
-	}
-
-	var sp tracer.Span
-
-	ctx, sp = tr.Start(ctx, "test")
-	if v := sp.TraceID(); v != "43" {
-		t.Fatalf("invalid span trace id %#+v", v)
-	}
-	if v := sp.SpanID(); v != "44" {
-		t.Fatalf("invalid span span id %#+v", v)
+			} else if !ok {
+				return
+			}
+		}
 	}
 }