many improvements with options and noop stuff

* add many options helpers
* fix noop client to allow publish messages to topic in broker
* fix noop server to allow registering in registry
* fix noop server to allow subscribe to topic in broker
* fix new service initialization

Signed-off-by: Vasiliy Tolstov <v.tolstov@unistack.org>

network/transport/noop.go

@@ -0,0 +1,70 @@
+package transport
+
+type NoopTransport struct {
+	opts Options
+}
+
+func (t *NoopTransport) Init(opts ...Option) error {
+	for _, o := range opts {
+		o(&t.opts)
+	}
+	return nil
+}
+
+func (t *NoopTransport) Options() Options {
+	return t.opts
+}
+
+func (t *NoopTransport) Dial(addr string, opts ...DialOption) (Client, error) {
+	options := NewDialOptions(opts...)
+	return &noopClient{opts: options}, nil
+}
+
+func (t *NoopTransport) Listen(addr string, opts ...ListenOption) (Listener, error) {
+	options := NewListenOptions(opts...)
+	return &noopListener{opts: options}, nil
+}
+
+func (t *NoopTransport) String() string {
+	return "noop"
+}
+
+type noopClient struct {
+	opts DialOptions
+}
+
+func (c *noopClient) Close() error {
+	return nil
+}
+
+func (c *noopClient) Local() string {
+	return ""
+}
+
+func (c *noopClient) Remote() string {
+	return ""
+}
+
+func (c *noopClient) Recv(*Message) error {
+	return nil
+}
+
+func (c *noopClient) Send(*Message) error {
+	return nil
+}
+
+type noopListener struct {
+	opts ListenOptions
+}
+
+func (l *noopListener) Addr() string {
+	return ""
+}
+
+func (l *noopListener) Accept(fn func(Socket)) error {
+	return nil
+}
+
+func (l *noopListener) Close() error {
+	return nil
+}

network/transport/options.go

@@ -106,6 +106,12 @@ func Logger(l logger.Logger) Option {
 	}
 }
 
+func Context(ctx context.Context) Option {
+	return func(o *Options) {
+		o.Context = ctx
+	}
+}
+
 // Codec sets the codec used for encoding where the transport
 // does not support message headers
 func Codec(c codec.Marshaler) Option {

network/transport/transport.go

@@ -6,7 +6,7 @@ import (
 )
 
 var (
-	DefaultTransport Transport
+	DefaultTransport Transport = &NoopTransport{opts: NewOptions()}
 )
 
 // Transport is an interface which is used for communication between

network/tunnel/broker/broker.go

@@ -49,15 +49,15 @@ func (t *tunBroker) Address() string {
 	return t.tunnel.Address()
 }
 
-func (t *tunBroker) Connect() error {
+func (t *tunBroker) Connect(ctx context.Context) error {
 	return t.tunnel.Connect()
 }
 
-func (t *tunBroker) Disconnect() error {
+func (t *tunBroker) Disconnect(ctx context.Context) error {
 	return t.tunnel.Close()
 }
 
-func (t *tunBroker) Publish(topic string, m *broker.Message, opts ...broker.PublishOption) error {
+func (t *tunBroker) Publish(ctx context.Context, topic string, m *broker.Message, opts ...broker.PublishOption) error {
 	// TODO: this is probably inefficient, we might want to just maintain an open connection
 	// it may be easier to add broadcast to the tunnel
 	c, err := t.tunnel.Dial(topic, tunnel.DialMode(tunnel.Multicast))
@@ -72,21 +72,16 @@ func (t *tunBroker) Publish(topic string, m *broker.Message, opts ...broker.Publ
 	})
 }
 
-func (t *tunBroker) Subscribe(topic string, h broker.Handler, opts ...broker.SubscribeOption) (broker.Subscriber, error) {
+func (t *tunBroker) Subscribe(ctx context.Context, topic string, h broker.Handler, opts ...broker.SubscribeOption) (broker.Subscriber, error) {
 	l, err := t.tunnel.Listen(topic, tunnel.ListenMode(tunnel.Multicast))
 	if err != nil {
 		return nil, err
 	}
 
-	var options broker.SubscribeOptions
-	for _, o := range opts {
-		o(&options)
-	}
-
 	tunSub := &tunSubscriber{
 		topic:    topic,
 		handler:  h,
-		opts:     options,
+		opts:     broker.NewSubscribeOptions(opts...),
 		closed:   make(chan bool),
 		listener: l,
 	}
@@ -150,7 +145,7 @@ func (t *tunSubscriber) Topic() string {
 	return t.topic
 }
 
-func (t *tunSubscriber) Unsubscribe() error {
+func (t *tunSubscriber) Unsubscribe(ctx context.Context) error {
 	select {
 	case <-t.closed:
 		return nil
@@ -177,12 +172,7 @@ func (t *tunEvent) Error() error {
 }
 
 func NewBroker(opts ...broker.Option) (broker.Broker, error) {
-	options := broker.Options{
-		Context: context.Background(),
-	}
-	for _, o := range opts {
-		o(&options)
-	}
+	options := broker.NewOptions(opts...)
 
 	t, ok := options.Context.Value(tunnelKey{}).(tunnel.Tunnel)
 	if !ok {