From 1b5c83f3ccea3bb3a7ae47e3434521bae1a92208 Mon Sep 17 00:00:00 2001 From: ben-toogood Date: Wed, 1 Jul 2020 11:09:20 +0100 Subject: [PATCH] registry/mdns: fix deregister bug (#1771) * registry/mdns: fix deregister bug * Update registry/mdns_registry.go Co-authored-by: Dominic Wong --- registry/mdns_registry.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/registry/mdns_registry.go b/registry/mdns_registry.go index 53a23670..74c84f0a 100644 --- a/registry/mdns_registry.go +++ b/registry/mdns_registry.go @@ -359,6 +359,11 @@ func (m *mdnsRegistry) Deregister(service *Service, opts ...DeregisterOption) er } } + // we have no new entries, we can exit + if len(newEntries) == 0 { + return nil + } + // we have more than one entry remaining, we can exit if len(newEntries) > 1 { m.domains[options.Domain][service.Name] = newEntries