From 1fa3ac5599ebeef50114a3e53e2732486fd34456 Mon Sep 17 00:00:00 2001 From: Asim Aslam Date: Wed, 12 Aug 2020 12:52:14 +0100 Subject: [PATCH] write nil when expiry is zero --- store/cockroach/cockroach.go | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/store/cockroach/cockroach.go b/store/cockroach/cockroach.go index 18434dd4..9ab13f58 100644 --- a/store/cockroach/cockroach.go +++ b/store/cockroach/cockroach.go @@ -429,7 +429,14 @@ func (s *sqlStore) Write(r *store.Record, opts ...store.WriteOption) error { } else if r.Expiry != 0 { expiry = time.Now().Add(r.Expiry) } - if _, err := st.Exec(r.Key, r.Value, metadata, expiry); err != nil { + + if expiry.IsZero() { + _, err = st.Exec(r.Key, r.Value, metadata, nil) + } else { + _, err = st.Exec(r.Key, r.Value, metadata, expiry) + } + + if err != nil { return errors.Wrap(err, "Couldn't insert record "+r.Key) }