diff --git a/selector/cache/cache.go b/selector/cache/cache.go index 529ae65a..482c068b 100644 --- a/selector/cache/cache.go +++ b/selector/cache/cache.go @@ -366,11 +366,9 @@ func (c *cacheSelector) Select(service string, opts ...selector.SelectOption) (s } func (c *cacheSelector) Mark(service string, node *registry.Node, err error) { - return } func (c *cacheSelector) Reset(service string) { - return } // Close stops the watcher and destroys the cache diff --git a/selector/default.go b/selector/default.go index 4a35c00a..72abfc1b 100644 --- a/selector/default.go +++ b/selector/default.go @@ -48,11 +48,9 @@ func (r *defaultSelector) Select(service string, opts ...SelectOption) (Next, er } func (r *defaultSelector) Mark(service string, node *registry.Node, err error) { - return } func (r *defaultSelector) Reset(service string) { - return } func (r *defaultSelector) Close() error { diff --git a/selector/filter_test.go b/selector/filter_test.go index 9b3c27a9..5a3e9c0d 100644 --- a/selector/filter_test.go +++ b/selector/filter_test.go @@ -80,7 +80,7 @@ func TestFilterEndpoint(t *testing.T) { } } - if seen == false && data.count > 0 { + if !seen && data.count > 0 { t.Fatalf("Expected %d services but seen is %t; result %+v", data.count, seen, services) } } @@ -232,7 +232,7 @@ func TestFilterVersion(t *testing.T) { seen = true } - if seen == false && data.count > 0 { + if !seen && data.count > 0 { t.Fatalf("Expected %d services but seen is %t; result %+v", data.count, seen, services) } } diff --git a/server/rpc_service.go b/server/rpc_service.go index 776f4441..14b667c9 100644 --- a/server/rpc_service.go +++ b/server/rpc_service.go @@ -199,7 +199,7 @@ func (server *server) register(rcvr interface{}) error { return nil } -func (server *server) sendResponse(sending *sync.Mutex, req *request, reply interface{}, codec serverCodec, errmsg string, last bool) (err error) { +func (server *server) sendResponse(sending sync.Locker, req *request, reply interface{}, codec serverCodec, errmsg string, last bool) (err error) { resp := server.getResponse() // Encode the response header resp.ServiceMethod = req.ServiceMethod