lint fixes

Signed-off-by: Vasiliy Tolstov <v.tolstov@unistack.org>

api/api.go

@@ -10,6 +10,7 @@ import (
 	"github.com/unistack-org/micro/v3/server"
 )
 
+// nolint: revive
 // Api interface
 type Api interface {
 	// Initialise options

client/options.go

@@ -267,7 +267,7 @@ func Transport(t transport.Transport) Option {
 func Register(r register.Register) Option {
 	return func(o *Options) {
 		if o.Router != nil {
-			o.Router.Init(router.Register(r))
+			_ = o.Router.Init(router.Register(r))
 		}
 	}
 }
@@ -331,7 +331,7 @@ func TLSConfig(t *tls.Config) Option {
 		// already set. Required for Init call below.
 
 		// set the transport tls
-		o.Transport.Init(
+		_ = o.Transport.Init(
 			transport.TLSConfig(t),
 		)
 	}

flow/default.go

@@ -241,6 +241,7 @@ func (w *microWorkflow) Execute(ctx context.Context, req *Message, opts ...Execu
 					w.opts.Logger.Tracef(nctx, "will be executed %v", steps[idx][nidx])
 				}
 				cstep := steps[idx][nidx]
+				// nolint: nestif
 				if len(cstep.Requires()) == 0 {
 					wg.Add(1)
 					go func(step Step) {

network/transport/memory_test.go

@@ -16,12 +16,14 @@ func TestMemoryTransport(t *testing.T) {
 	}
 	defer l.Close()
 
+	cherr := make(chan error, 1)
 	// accept
 	go func() {
-		if err := l.Accept(func(sock Socket) {
+		if nerr := l.Accept(func(sock Socket) {
 			for {
 				var m Message
-				if err := sock.Recv(&m); err != nil {
+				if rerr := sock.Recv(&m); rerr != nil {
+					cherr <- rerr
 					return
 				}
 				if len(os.Getenv("INTEGRATION_TESTS")) == 0 {
@@ -30,11 +32,12 @@ func TestMemoryTransport(t *testing.T) {
 				if cerr := sock.Send(&Message{
 					Body: []byte(`pong`),
 				}); cerr != nil {
+					cherr <- cerr
 					return
 				}
 			}
-		}); err != nil {
+		}); nerr != nil {
-			t.Fatalf("Unexpected error accepting %v", err)
+			cherr <- err
 		}
 	}()
 
@@ -45,6 +48,10 @@ func TestMemoryTransport(t *testing.T) {
 	}
 	defer c.Close()
 
+	select {
+	case err := <-cherr:
+		t.Fatal(err)
+	default:
 		// send <=> receive
 		for i := 0; i < 3; i++ {
 			if err := c.Send(&Message{
@@ -60,6 +67,7 @@ func TestMemoryTransport(t *testing.T) {
 				t.Logf("Client Received %s", string(m.Body))
 			}
 		}
+	}
 }
 
 func TestListener(t *testing.T) {

network/tunnel/broker/broker.go

@@ -34,9 +34,9 @@ type tunBatchSubscriber struct {
 }
 
 type tunEvent struct {
+	err     error
 	message *broker.Message
 	topic   string
-	err     error
 }
 
 // used to access tunnel from options context
@@ -199,7 +199,9 @@ func (t *tunBatchSubscriber) run() {
 			},
 		}}
 		// handle the message
-		go t.handler(evts)
+		go func() {
+			_ = t.handler(evts)
+		}()
 
 	}
 }
@@ -235,13 +237,15 @@ func (t *tunSubscriber) run() {
 		c.Close()
 
 		// handle the message
-		go t.handler(&tunEvent{
+		go func() {
+			_ = t.handler(&tunEvent{
 				topic: t.topic,
 				message: &broker.Message{
 					Header: m.Header,
 					Body:   m.Body,
 				},
 			})
+		}()
 	}
 }
 

network/tunnel/transport/transport.go

@@ -37,7 +37,7 @@ func (t *tunTransport) Init(opts ...transport.Option) error {
 	// get the transport
 	tr, ok := t.options.Context.Value(transportKey{}).(transport.Transport)
 	if ok {
-		tun.Init(tunnel.Transport(tr))
+		_ = tun.Init(tunnel.Transport(tr))
 	}
 
 	// set the tunnel

resolver/http/http.go

@@ -11,6 +11,7 @@ import (
 	"github.com/unistack-org/micro/v3/resolver"
 )
 
+// nolint: golint,revive
 // HTTPResolver is a HTTP network resolver
 type HTTPResolver struct {
 	// Proto if not set, defaults to http
@@ -53,6 +54,7 @@ func (r *HTTPResolver) Resolve(name string) ([]*resolver.Record, error) {
 	q.Set("name", name)
 	uri.RawQuery = q.Encode()
 
+	// nolint: noctx
 	rsp, err := http.Get(uri.String())
 	if err != nil {
 		return nil, err

router/options.go

@@ -16,15 +16,15 @@ type Options struct {
 	Name     string
 	Gateway  string
 	Network  string
-	Id       string
+	ID       string
 	Address  string
 	Precache bool
 }
 
-// Id sets Router Id
+// ID sets Router Id
-func Id(id string) Option {
+func ID(id string) Option {
 	return func(o *Options) {
-		o.Id = id
+		o.ID = id
 	}
 }
 
@@ -80,7 +80,7 @@ func Name(n string) Option {
 // NewOptions returns router default options
 func NewOptions(opts ...Option) Options {
 	options := Options{
-		Id:       id.Must(),
+		ID:       id.Must(),
 		Network:  DefaultNetwork,
 		Register: register.DefaultRegister,
 		Logger:   logger.DefaultLogger,

server/options.go

@@ -262,7 +262,7 @@ func TLSConfig(t *tls.Config) Option {
 		// already set. Required for Init call below.
 
 		// set the transport tls
-		o.Transport.Init(
+		_ = o.Transport.Init(
 			transport.TLSConfig(t),
 		)
 	}

util/auth/auth.go

@@ -48,7 +48,7 @@ func Verify(a auth.Auth) error {
 	}
 
 	// set the credentials and token in auth options
-	a.Init(
+	_ = a.Init(
 		auth.ClientToken(token),
 		auth.Credentials(accID, accSecret),
 	)
@@ -79,7 +79,7 @@ func Verify(a auth.Auth) error {
 			}
 
 			// set the token
-			a.Init(auth.ClientToken(tok))
+			_ = a.Init(auth.ClientToken(tok))
 		}
 	}()
 

util/pool/default.go

@@ -49,7 +49,7 @@ func (p *poolConn) Close() error {
 	return nil
 }
 
-func (p *poolConn) Id() string {
+func (p *poolConn) ID() string {
 	return p.id
 }
 

util/pool/pool.go

@@ -21,7 +21,7 @@ type Pool interface {
 // Conn conn pool interface
 type Conn interface {
 	// unique id of connection
-	Id() string
+	ID() string
 	// time it was created
 	Created() time.Time
 	// embedded connection

util/reflect/path.go

@@ -82,9 +82,9 @@ func getValueByName(v reflect.Value, key string) (reflect.Value, error) {
 	case reflect.Struct:
 		value = v.FieldByName(key)
 	case reflect.Map:
-		kValue := reflect.Indirect(reflect.New(v.Type().Key()))
+		kvalue := reflect.Indirect(reflect.New(v.Type().Key()))
-		kValue.SetString(key)
+		kvalue.SetString(key)
-		value = v.MapIndex(kValue)
+		value = v.MapIndex(kvalue)
 	}
 
 	if !value.IsValid() {

util/ring/buffer.go

@@ -28,8 +28,8 @@ type Stream struct {
 	Entries chan *Entry
 	// Stop channel
 	Stop chan bool
-	// Id of the stream
+	// ID of the stream
-	Id string
+	ID string
 }
 
 // Put adds a new value to ring buffer
@@ -53,7 +53,7 @@ func (b *Buffer) Put(v interface{}) {
 	for _, stream := range b.streams {
 		select {
 		case <-stream.Stop:
-			delete(b.streams, stream.Id)
+			delete(b.streams, stream.ID)
 			close(stream.Entries)
 		case stream.Entries <- entry:
 		}
@@ -116,7 +116,7 @@ func (b *Buffer) Stream() (<-chan *Entry, chan bool) {
 	stop := make(chan bool)
 
 	b.streams[id] = &Stream{
-		Id:      id,
+		ID:      id,
 		Entries: entries,
 		Stop:    stop,
 	}