From 33b1cea29d866023b40dddfd1c1641876befdc4a Mon Sep 17 00:00:00 2001 From: Asim Aslam Date: Mon, 17 Apr 2017 14:57:43 +0100 Subject: [PATCH] Don't create new options --- service.go | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/service.go b/service.go index 1f49371e..4f3d0033 100644 --- a/service.go +++ b/service.go @@ -68,17 +68,11 @@ func (s *service) Init(opts ...Option) { // close init close(s.init) - // We might get more command flags or the action here - // This is pretty ugly, find a better way - options := newOptions() - options.Cmd = s.opts.Cmd - + // process options for _, o := range opts { - o(&options) + o(&s.opts) } - s.opts.Cmd = options.Cmd - // Initialise the command flags, overriding new service s.opts.Cmd.Init( cmd.Broker(&s.opts.Broker),