From 4e7621da1849b7889f7a68c507051b95f7d2d33c Mon Sep 17 00:00:00 2001 From: ben-toogood Date: Sun, 12 Jul 2020 07:22:08 +0100 Subject: [PATCH] config/cmd: standardise error handling (#1816) * runtime/kubernetes: remove reference to runtime cells * config/cmd: standardize error handling Co-authored-by: Asim Aslam --- config/cmd/cmd.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/config/cmd/cmd.go b/config/cmd/cmd.go index b4dda0b9..988ab2b0 100644 --- a/config/cmd/cmd.go +++ b/config/cmd/cmd.go @@ -4,7 +4,6 @@ package cmd import ( "crypto/tls" "crypto/x509" - "fmt" "io/ioutil" "math/rand" "strings" @@ -669,7 +668,7 @@ func (c *cmd) Before(ctx *cli.Context) error { // verify the auth's service account if err := authutil.Verify(*c.opts.Auth); err != nil { - return err + logger.Fatalf("Error generating auth account: %v", err) } // Setup broker options. @@ -781,7 +780,7 @@ func (c *cmd) Before(ctx *cli.Context) error { if name := ctx.String("router"); len(name) > 0 && (*c.opts.Router).String() != name { r, ok := c.opts.Routers[name] if !ok { - return fmt.Errorf("Router %s not found", name) + logger.Fatalf("Router %s not found", name) } // close the default router before replacing it