From 606b1ff7cf6812877313ce11a1ec25f5483d16d1 Mon Sep 17 00:00:00 2001 From: magodo Date: Wed, 19 Jun 2019 14:42:09 +0800 Subject: [PATCH] `prefix` in consul api starts with no leading slash When `consul.StripPrefix(true)` is set, current impl. will pass the specified prefix (or default prefix) when calling consul api. However, `prefix` in consul api starts with no leading slash, so the default prefix (`/micro/config`) doesn't actually work. I avoid code changes (esp. the one in `util.go`) to eliminate impact on users who already notice it. --- config/source/consul/README.md | 6 +++--- config/source/consul/consul.go | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/config/source/consul/README.md b/config/source/consul/README.md index 2ba45e5b..061c0a3f 100644 --- a/config/source/consul/README.md +++ b/config/source/consul/README.md @@ -4,7 +4,7 @@ The consul source reads config from consul key/values ## Consul Format -The consul source expects keys under the default prefix `/micro/config` +The consul source expects keys under the default prefix `micro/config` Values are expected to be json @@ -29,8 +29,8 @@ Specify source with data consulSource := consul.NewSource( // optionally specify consul address; default to localhost:8500 consul.WithAddress("10.0.0.10:8500"), - // optionally specify prefix; defaults to /micro/config - consul.WithPrefix("/my/prefix"), + // optionally specify prefix; defaults to micro/config + consul.WithPrefix("my/prefix"), // optionally strip the provided prefix from the keys, defaults to false consul.StripPrefix(true), ) diff --git a/config/source/consul/consul.go b/config/source/consul/consul.go index 16e85332..785f20f7 100644 --- a/config/source/consul/consul.go +++ b/config/source/consul/consul.go @@ -21,7 +21,7 @@ type consul struct { var ( // DefaultPrefix is the prefix that consul keys will be assumed to have if you // haven't specified one - DefaultPrefix = "/micro/config/" + DefaultPrefix = "micro/config/" ) func (c *consul) Read() (*source.ChangeSet, error) {