unistack-org/micro
4
0
Fork 3
Code Issues 20 Pull Requests 2 Actions Packages Projects Releases 283 Wiki Activity

Merge pull request #413 from qkzsky/qkzsky-rpc-fix

Browse Source 
client close: rpc: unable to write error response
This commit is contained in:
Asim Aslam 2019-02-03 13:13:10 +00:00 committed by GitHub
commit 686171c26d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
server/rpc_server.go
View File

@ -157,15 +157,17 @@ func (s *rpcServer) ServeConn(sock transport.Socket) {
// TODO: handle error better // TODO: handle error better
if err := handler(ctx, request, response); err != nil { if err := handler(ctx, request, response); err != nil {
// write an error response if err != lastStreamResponseError {
err = rcodec.Write(&codec.Message{ // write an error response
Header: msg.Header, err = rcodec.Write(&codec.Message{
Error: err.Error(), Header: msg.Header,
Type: codec.Error, Error: err.Error(),
}, nil) Type: codec.Error,
// could not write the error response }, nil)
if err != nil { // could not write the error response
log.Logf("rpc: unable to write error response: %v", err) if err != nil {
log.Logf("rpc: unable to write error response: %v", err)
}
} }
s.wg.Done() s.wg.Done()
return return