move options to dedicated package

Signed-off-by: Vasiliy Tolstov <v.tolstov@unistack.org>

server/context.go

@@ -22,23 +22,3 @@ func NewContext(ctx context.Context, s Server) context.Context {
 	}
 	return context.WithValue(ctx, serverKey{}, s)
 }
-
-// SetOption returns a function to setup a context with given value
-func SetOption(k, v interface{}) Option {
-	return func(o *Options) {
-		if o.Context == nil {
-			o.Context = context.Background()
-		}
-		o.Context = context.WithValue(o.Context, k, v)
-	}
-}
-
-// SetHandlerOption returns a function to setup a context with given value
-func SetHandlerOption(k, v interface{}) HandlerOption {
-	return func(o *HandlerOptions) {
-		if o.Context == nil {
-			o.Context = context.Background()
-		}
-		o.Context = context.WithValue(o.Context, k, v)
-	}
-}

server/context_test.go

@@ -40,14 +40,3 @@ func TestNewContext(t *testing.T) {
 		t.Fatal("NewContext not works")
 	}
 }
-
-func TestSetOption(t *testing.T) {
-	type key struct{}
-	o := SetOption(key{}, "test")
-	opts := &Options{}
-	o(opts)
-
-	if v, ok := opts.Context.Value(key{}).(string); !ok || v == "" {
-		t.Fatal("SetOption not works")
-	}
-}

server/noop.go

@@ -8,6 +8,7 @@ import (
 
 	"go.unistack.org/micro/v4/codec"
 	"go.unistack.org/micro/v4/logger"
+	"go.unistack.org/micro/v4/options"
 	"go.unistack.org/micro/v4/register"
 	maddr "go.unistack.org/micro/v4/util/addr"
 	mnet "go.unistack.org/micro/v4/util/net"
@@ -19,15 +20,11 @@ var DefaultCodecs = map[string]codec.Codec{
 	"application/octet-stream": codec.NewCodec(),
 }
 
-const (
-	defaultContentType = "application/json"
-)
-
 type noopServer struct {
-	h        Handler
+	h        *rpcHandler
 	wg       *sync.WaitGroup
 	rsvc     *register.Service
-	handlers map[string]Handler
+	handlers map[string]*rpcHandler
 	exit     chan chan error
 	opts     Options
 	sync.RWMutex
@@ -36,10 +33,10 @@ type noopServer struct {
 }
 
 // NewServer returns new noop server
-func NewServer(opts ...Option) Server {
+func NewServer(opts ...options.Option) Server {
 	n := &noopServer{opts: NewOptions(opts...)}
 	if n.handlers == nil {
-		n.handlers = make(map[string]Handler)
+		n.handlers = make(map[string]*rpcHandler)
 	}
 	if n.exit == nil {
 		n.exit = make(chan chan error)
@@ -47,18 +44,8 @@ func NewServer(opts ...Option) Server {
 	return n
 }
 
-func (n *noopServer) newCodec(contentType string) (codec.Codec, error) {
-	if cf, ok := n.opts.Codecs[contentType]; ok {
-		return cf, nil
-	}
-	if cf, ok := DefaultCodecs[contentType]; ok {
-		return cf, nil
-	}
-	return nil, codec.ErrUnknownContentType
-}
-
-func (n *noopServer) Handle(handler Handler) error {
-	n.h = handler
+func (n *noopServer) Handle(h interface{}, opts ...options.Option) error {
+	n.h = newRPCHandler(h, opts...)
 	return nil
 }
 
@@ -66,17 +53,13 @@ func (n *noopServer) Name() string {
 	return n.opts.Name
 }
 
-func (n *noopServer) NewHandler(h interface{}, opts ...HandlerOption) Handler {
-	return newRPCHandler(h, opts...)
-}
-
-func (n *noopServer) Init(opts ...Option) error {
+func (n *noopServer) Init(opts ...options.Option) error {
 	for _, o := range opts {
 		o(&n.opts)
 	}
 
 	if n.handlers == nil {
-		n.handlers = make(map[string]Handler, 1)
+		n.handlers = make(map[string]*rpcHandler, 1)
 	}
 
 	if n.exit == nil {
@@ -339,14 +322,14 @@ func (n *noopServer) Stop() error {
 }
 
 type rpcHandler struct {
-	opts      HandlerOptions
+	opts      HandleOptions
 	handler   interface{}
 	name      string
 	endpoints []*register.Endpoint
 }
 
-func newRPCHandler(handler interface{}, opts ...HandlerOption) Handler {
-	options := NewHandlerOptions(opts...)
+func newRPCHandler(handler interface{}, opts ...options.Option) *rpcHandler {
+	options := NewHandleOptions(opts...)
 
 	typ := reflect.TypeOf(handler)
 	hdlr := reflect.ValueOf(handler)
@@ -386,6 +369,6 @@ func (r *rpcHandler) Endpoints() []*register.Endpoint {
 	return r.endpoints
 }
 
-func (r *rpcHandler) Options() HandlerOptions {
+func (r *rpcHandler) Options() HandleOptions {
 	return r.opts
 }

server/options.go

@@ -11,27 +11,12 @@ import (
 	"go.unistack.org/micro/v4/logger"
 	"go.unistack.org/micro/v4/metadata"
 	"go.unistack.org/micro/v4/meter"
-	"go.unistack.org/micro/v4/network/transport"
 	"go.unistack.org/micro/v4/options"
 	"go.unistack.org/micro/v4/register"
 	"go.unistack.org/micro/v4/tracer"
 	"go.unistack.org/micro/v4/util/id"
 )
 
-var (
-	// ServerRequestDurationSeconds specifies meter metric name
-	ServerRequestDurationSeconds = "server_request_duration_seconds"
-	// ServerRequestLatencyMicroseconds specifies meter metric name
-	ServerRequestLatencyMicroseconds = "server_request_latency_microseconds"
-	// ServerRequestTotal specifies meter metric name
-	ServerRequestTotal = "server_request_total"
-	// ServerRequestInflight specifies meter metric name
-	ServerRequestInflight = "server_request_inflight"
-)
-
-// Option func
-type Option func(*Options)
-
 // Options server struct
 type Options struct {
 	// Context holds the external options and can be used for server shutdown
@@ -44,8 +29,6 @@ type Options struct {
 	Logger logger.Logger
 	// Meter holds the meter
 	Meter meter.Meter
-	// Transport holds the transport
-	Transport transport.Transport
 	// Listener may be passed if already created
 	Listener net.Listener
 	// Wait group
@@ -70,8 +53,6 @@ type Options struct {
 	Advertise string
 	// Version holds the server version
 	Version string
-	// HdlrWrappers holds the handler wrappers
-	HdlrWrappers []HandlerWrapper
 	// RegisterAttempts holds the number of register attempts before error
 	RegisterAttempts int
 	// RegisterInterval holds he interval for re-register
@@ -82,12 +63,12 @@ type Options struct {
 	MaxConn int
 	// DeregisterAttempts holds the number of deregister attempts before error
 	DeregisterAttempts int
-	// Hooks may contains HandlerWrapper or Server func wrapper
+	// Hooks may contains HandleWrapper or Server func wrapper
 	Hooks options.Hooks
 }
 
 // NewOptions returns new options struct with default or passed values
-func NewOptions(opts ...Option) Options {
+func NewOptions(opts ...options.Option) Options {
 	options := Options{
 		Codecs:           make(map[string]codec.Codec),
 		Context:          context.Background(),
@@ -99,12 +80,10 @@ func NewOptions(opts ...Option) Options {
 		Meter:            meter.DefaultMeter,
 		Tracer:           tracer.DefaultTracer,
 		Register:         register.DefaultRegister,
-		Transport:        transport.DefaultTransport,
 		Address:          DefaultAddress,
 		Name:             DefaultName,
 		Version:          DefaultVersion,
 		ID:               id.Must(),
-		Namespace:        DefaultNamespace,
 	}
 
 	for _, o := range opts {
@@ -114,140 +93,45 @@ func NewOptions(opts ...Option) Options {
 	return options
 }
 
-// Name sets the server name option
-func Name(n string) Option {
-	return func(o *Options) {
-		o.Name = n
-	}
-}
-
-// Namespace to register handlers in
-func Namespace(n string) Option {
-	return func(o *Options) {
-		o.Namespace = n
-	}
-}
-
-// Logger sets the logger option
-func Logger(l logger.Logger) Option {
-	return func(o *Options) {
-		o.Logger = l
-	}
-}
-
-// Meter sets the meter option
-func Meter(m meter.Meter) Option {
-	return func(o *Options) {
-		o.Meter = m
-	}
-}
-
 // ID unique server id
-func ID(id string) Option {
-	return func(o *Options) {
-		o.ID = id
+func ID(id string) options.Option {
+	return func(src interface{}) error {
+		return options.Set(src, id, ".ID")
 	}
 }
 
 // Version of the service
-func Version(v string) Option {
-	return func(o *Options) {
-		o.Version = v
-	}
-}
-
-// Address to bind to - host:port
-func Address(a string) Option {
-	return func(o *Options) {
-		o.Address = a
+func Version(v string) options.Option {
+	return func(src interface{}) error {
+		return options.Set(src, v, ".Version")
 	}
 }
 
 // Advertise the address to advertise for discovery - host:port
-func Advertise(a string) Option {
-	return func(o *Options) {
-		o.Advertise = a
-	}
-}
-
-// Codec to use to encode/decode requests for a given content type
-func Codec(contentType string, c codec.Codec) Option {
-	return func(o *Options) {
-		o.Codecs[contentType] = c
-	}
-}
-
-// Context specifies a context for the service.
-// Can be used to signal shutdown of the service
-// Can be used for extra option values.
-func Context(ctx context.Context) Option {
-	return func(o *Options) {
-		o.Context = ctx
-	}
-}
-
-// Register used for discovery
-func Register(r register.Register) Option {
-	return func(o *Options) {
-		o.Register = r
-	}
-}
-
-// Tracer mechanism for distributed tracking
-func Tracer(t tracer.Tracer) Option {
-	return func(o *Options) {
-		o.Tracer = t
-	}
-}
-
-// Transport mechanism for communication e.g http, rabbitmq, etc
-func Transport(t transport.Transport) Option {
-	return func(o *Options) {
-		o.Transport = t
-	}
-}
-
-// Metadata associated with the server
-func Metadata(md metadata.Metadata) Option {
-	return func(o *Options) {
-		o.Metadata = metadata.Copy(md)
+func Advertise(a string) options.Option {
+	return func(src interface{}) error {
+		return options.Set(src, a, ".Advertise")
 	}
 }
 
 // RegisterCheck run func before register service
-func RegisterCheck(fn func(context.Context) error) Option {
-	return func(o *Options) {
-		o.RegisterCheck = fn
+func RegisterCheck(fn func(context.Context) error) options.Option {
+	return func(src interface{}) error {
+		return options.Set(src, fn, ".RegisterCheck")
 	}
 }
 
 // RegisterTTL registers service with a TTL
-func RegisterTTL(t time.Duration) Option {
-	return func(o *Options) {
-		o.RegisterTTL = t
+func RegisterTTL(td time.Duration) options.Option {
+	return func(src interface{}) error {
+		return options.Set(src, td, ".RegisterTTL")
 	}
 }
 
 // RegisterInterval registers service with at interval
-func RegisterInterval(t time.Duration) Option {
-	return func(o *Options) {
-		o.RegisterInterval = t
-	}
-}
-
-// TLSConfig specifies a *tls.Config
-func TLSConfig(t *tls.Config) Option {
-	return func(o *Options) {
-		// set the internal tls
-		o.TLSConfig = t
-
-		// set the default transport if one is not
-		// already set. Required for Init call below.
-
-		// set the transport tls
-		_ = o.Transport.Init(
-			transport.TLSConfig(t),
-		)
+func RegisterInterval(td time.Duration) options.Option {
+	return func(src interface{}) error {
+		return options.Set(src, td, ".RegisterInterval")
 	}
 }
 
@@ -255,50 +139,40 @@ func TLSConfig(t *tls.Config) Option {
 // If `wg` is nil, server only wait for completion of rpc handler.
 // For user need finer grained control, pass a concrete `wg` here, server will
 // wait against it on stop.
-func Wait(wg *sync.WaitGroup) Option {
-	return func(o *Options) {
-		if wg == nil {
-			wg = new(sync.WaitGroup)
-		}
-		o.Wait = wg
+func Wait(wg *sync.WaitGroup) options.Option {
+	if wg == nil {
+		wg = new(sync.WaitGroup)
 	}
-}
-
-// WrapHandler adds a handler Wrapper to a list of options passed into the server
-func WrapHandler(w HandlerWrapper) Option {
-	return func(o *Options) {
-		o.HdlrWrappers = append(o.HdlrWrappers, w)
+	return func(src interface{}) error {
+		return options.Set(src, wg, ".Wait")
 	}
 }
 
 // MaxConn specifies maximum number of max simultaneous connections to server
-func MaxConn(n int) Option {
-	return func(o *Options) {
-		o.MaxConn = n
+func MaxConn(n int) options.Option {
+	return func(src interface{}) error {
+		return options.Set(src, n, ".MaxConn")
 	}
 }
 
 // Listener specifies the net.Listener to use instead of the default
-func Listener(l net.Listener) Option {
-	return func(o *Options) {
-		o.Listener = l
+func Listener(nl net.Listener) options.Option {
+	return func(src interface{}) error {
+		return options.Set(src, nl, ".Listener")
 	}
 }
 
-// HandlerOption func
-type HandlerOption func(*HandlerOptions)
-
-// HandlerOptions struct
-type HandlerOptions struct {
+// HandleOptions struct
+type HandleOptions struct {
 	// Context holds external options
 	Context context.Context
 	// Metadata for handler
 	Metadata map[string]metadata.Metadata
 }
 
-// NewHandlerOptions creates new HandlerOptions
-func NewHandlerOptions(opts ...HandlerOption) HandlerOptions {
-	options := HandlerOptions{
+// NewHandleOptions creates new HandleOptions
+func NewHandleOptions(opts ...options.Option) HandleOptions {
+	options := HandleOptions{
 		Context:  context.Background(),
 		Metadata: make(map[string]metadata.Metadata),
 	}
@@ -309,11 +183,3 @@ func NewHandlerOptions(opts ...HandlerOption) HandlerOptions {
 
 	return options
 }
-
-// EndpointMetadata is a Handler option that allows metadata to be added to
-// individual endpoints.
-func EndpointMetadata(name string, md metadata.Metadata) HandlerOption {
-	return func(o *HandlerOptions) {
-		o.Metadata[name] = metadata.Copy(md)
-	}
-}

server/server.go

@@ -7,7 +7,7 @@ import (
 
 	"go.unistack.org/micro/v4/codec"
 	"go.unistack.org/micro/v4/metadata"
-	"go.unistack.org/micro/v4/register"
+	"go.unistack.org/micro/v4/options"
 )
 
 // DefaultServer default server
@@ -26,9 +26,7 @@ var (
 	DefaultRegisterInterval = time.Second * 30
 	// DefaultRegisterTTL holds register record ttl, must be multiple of DefaultRegisterInterval
 	DefaultRegisterTTL = time.Second * 90
-	// DefaultNamespace will be used if no namespace passed
-	DefaultNamespace = "micro"
-	// DefaultMaxMsgSize holds default max msg ssize
+	// DefaultMaxMsgSize holds default max msg size
 	DefaultMaxMsgSize = 1024 * 1024 * 4 // 4Mb
 	// DefaultMaxMsgRecvSize holds default max recv size
 	DefaultMaxMsgRecvSize = 1024 * 1024 * 4 // 4Mb
@@ -41,13 +39,11 @@ type Server interface {
 	// Name returns server name
 	Name() string
 	// Initialise options
-	Init(...Option) error
+	Init(...options.Option) error
 	// Retrieve the options
 	Options() Options
-	// Register a handler
-	Handle(h Handler) error
-	// Create a new handler
-	NewHandler(h interface{}, opts ...HandlerOption) Handler
+	// Create and register new handler
+	Handle(h interface{}, opts ...options.Option) error
 	// Start the server
 	Start() error
 	// Stop the server
@@ -110,21 +106,3 @@ type Stream interface {
 	// Close closes the stream
 	Close() error
 }
-
-// Handler interface represents a request handler. It's generated
-// by passing any type of public concrete object with endpoints into server.NewHandler.
-// Most will pass in a struct.
-//
-// Example:
-//
-//	type Greeter struct {}
-//
-//	func (g *Greeter) Hello(context, request, response) error {
-//	        return nil
-//	}
-type Handler interface {
-	Name() string
-	Handler() interface{}
-	Endpoints() []*register.Endpoint
-	Options() HandlerOptions
-}