unistack-org/micro
4
0
Fork 3
Code Issues 19 Pull Requests 1 Actions Packages Projects Releases 259 Wiki Activity

Replace service prefix with FQDN style prefix (#1107)

Browse Source 
* Replace service prefix with FQDN style prefix

According to the k8s documentation, the label and annotation prefixes should be in the format of a FQDN, with dot separated labels of no more than 63 characters. The current label and annotation paramteres are rejected by the k8s api, most likely because they have two forward slashes in them.

* Use go.micro as service and annotation prefix
This commit is contained in:
Matthew Costa 2020-01-12 14:37:12 +00:00 committed by Asim Aslam
parent 50b20413d3
commit 75b1a62af3
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
registry/kubernetes/kubernetes.go
View File

@ -23,7 +23,7 @@ type kregistry struct {
var ( var (
// used on pods as labels & services to select // used on pods as labels & services to select
// eg: svcSelectorPrefix+"svc.name" // eg: svcSelectorPrefix+"svc.name"
servicePrefix = "micro/service/" servicePrefix = "go.micro/"
serviceValue = "service" serviceValue = "service"
labelTypeKey = "micro" labelTypeKey = "micro"
@ -31,7 +31,7 @@ var (
// used on k8s services to scope a serialised // used on k8s services to scope a serialised
// micro service by pod name // micro service by pod name
annotationPrefix = "micro/service/" annotationPrefix = "go.micro/"
// Pod status // Pod status
podRunning = "Running" podRunning = "Running"