Pass resolver to api auth handler

This commit is contained in:
Ben Toogood 2020-04-02 17:44:48 +01:00
parent 0241197c6a
commit 8b35c264eb
3 changed files with 47 additions and 12 deletions

View File

@ -6,20 +6,25 @@ import (
"net/url" "net/url"
"strings" "strings"
"github.com/micro/go-micro/v2/api/resolver"
"github.com/micro/go-micro/v2/auth" "github.com/micro/go-micro/v2/auth"
) )
// CombinedAuthHandler wraps a server and authenticates requests // CombinedAuthHandler wraps a server and authenticates requests
func CombinedAuthHandler(h http.Handler) http.Handler { func CombinedAuthHandler(namespace string, r resolver.Resolver, h http.Handler) http.Handler {
return authHandler{ return authHandler{
handler: h, handler: h,
resolver: r,
auth: auth.DefaultAuth, auth: auth.DefaultAuth,
namespace: namespace,
} }
} }
type authHandler struct { type authHandler struct {
handler http.Handler handler http.Handler
auth auth.Auth auth auth.Auth
resolver resolver.Resolver
namespace string
} }
func (h authHandler) ServeHTTP(w http.ResponseWriter, req *http.Request) { func (h authHandler) ServeHTTP(w http.ResponseWriter, req *http.Request) {
@ -45,10 +50,21 @@ func (h authHandler) ServeHTTP(w http.ResponseWriter, req *http.Request) {
if err != nil { if err != nil {
acc = &auth.Account{} acc = &auth.Account{}
} }
// Determine the name of the service being requested
endpoint, err := h.resolver.Resolve(req)
if err != nil {
w.WriteHeader(http.StatusInternalServerError)
return
}
resName := h.namespace + "." + endpoint.Name
// Perform the verification check to see if the account has access to
// the resource they're requesting
err = h.auth.Verify(acc, &auth.Resource{ err = h.auth.Verify(acc, &auth.Resource{
Type: "service", Type: "service",
Name: "go.micro.web", Name: resName,
Endpoint: req.URL.Path, Endpoint: endpoint.Path,
}) })
// The account has the necessary permissions to access the // The account has the necessary permissions to access the

View File

@ -8,10 +8,9 @@ import (
"os" "os"
"sync" "sync"
"github.com/micro/go-micro/v2/api/server/auth"
"github.com/gorilla/handlers" "github.com/gorilla/handlers"
"github.com/micro/go-micro/v2/api/server" "github.com/micro/go-micro/v2/api/server"
"github.com/micro/go-micro/v2/api/server/auth"
"github.com/micro/go-micro/v2/api/server/cors" "github.com/micro/go-micro/v2/api/server/cors"
"github.com/micro/go-micro/v2/logger" "github.com/micro/go-micro/v2/logger"
) )
@ -25,9 +24,14 @@ type httpServer struct {
exit chan chan error exit chan chan error
} }
func NewServer(address string) server.Server { func NewServer(address string, opts ...server.Option) server.Server {
var options server.Options
for _, o := range opts {
o(&options)
}
return &httpServer{ return &httpServer{
opts: server.Options{}, opts: options,
mux: http.NewServeMux(), mux: http.NewServeMux(),
address: address, address: address,
exit: make(chan chan error), exit: make(chan chan error),
@ -49,7 +53,7 @@ func (s *httpServer) Init(opts ...server.Option) error {
func (s *httpServer) Handle(path string, handler http.Handler) { func (s *httpServer) Handle(path string, handler http.Handler) {
h := handlers.CombinedLoggingHandler(os.Stdout, handler) h := handlers.CombinedLoggingHandler(os.Stdout, handler)
h = auth.CombinedAuthHandler(handler) h = auth.CombinedAuthHandler(s.opts.Namespace, s.opts.Resolver, handler)
if s.opts.EnableCORS { if s.opts.EnableCORS {
h = cors.CombinedCORSHandler(h) h = cors.CombinedCORSHandler(h)

View File

@ -3,6 +3,7 @@ package server
import ( import (
"crypto/tls" "crypto/tls"
"github.com/micro/go-micro/v2/api/resolver"
"github.com/micro/go-micro/v2/api/server/acme" "github.com/micro/go-micro/v2/api/server/acme"
) )
@ -15,6 +16,8 @@ type Options struct {
EnableTLS bool EnableTLS bool
ACMEHosts []string ACMEHosts []string
TLSConfig *tls.Config TLSConfig *tls.Config
Namespace string
Resolver resolver.Resolver
} }
func EnableCORS(b bool) Option { func EnableCORS(b bool) Option {
@ -52,3 +55,15 @@ func TLSConfig(t *tls.Config) Option {
o.TLSConfig = t o.TLSConfig = t
} }
} }
func Namespace(n string) Option {
return func(o *Options) {
o.Namespace = n
}
}
func Resolver(r resolver.Resolver) Option {
return func(o *Options) {
o.Resolver = r
}
}