unistack-org/micro
4
0
Fork 3
Code Issues 19 Pull Requests 1 Actions Packages Projects Releases 259 Wiki Activity

Merge pull request #794 from micro/hash

Browse Source 
Don't shutdown old nodes in mdns registry
This commit is contained in:
Asim Aslam 2019-09-26 16:50:17 +01:00 committed by GitHub
commit 8b77d62ed4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
registry/mdns_registry.go
View File

@ -11,7 +11,6 @@ import (
"time"
"github.com/micro/mdns"
hash "github.com/mitchellh/hashstructure"
)
var (
@ -27,7 +26,6 @@ type mdnsTxt struct {
}
type mdnsEntry struct {
hash uint64
id string
node *mdns.Server
}
@ -109,13 +107,6 @@ func (m *mdnsRegistry) Register(service *Service, opts ...RegisterOption) error
var gerr error
for _, node := range service.Nodes {
// create hash of service; uint64
h, err := hash.Hash(node, nil)
if err != nil {
gerr = err
continue
}
var seen bool
var e *mdnsEntry
@ -128,14 +119,11 @@ func (m *mdnsRegistry) Register(service *Service, opts ...RegisterOption) error
}
// already registered, continue
if seen && e.hash == h {
if seen {
continue
// hash doesn't match, shutdown
} else if seen {
e.node.Shutdown()
// doesn't exist
} else {
e = &mdnsEntry{hash: h}
e = &mdnsEntry{}
}
txt, err := encode(&mdnsTxt{