unistack-org/micro
4
0
Fork 3
Code Issues 19 Pull Requests 2 Actions 2 Packages Projects Releases 262 Wiki Activity

grpc client goroutine leak fix

Browse Source 
Signed-off-by: Vasiliy Tolstov <v.tolstov@unistack.org>
This commit is contained in:
Василий Толстов 2019-11-25 22:02:24 +03:00
parent 11d81221cc
commit 9763820c75
1 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
client/grpc/stream.go
View File

@ -43,14 +43,12 @@ func (g *grpcStream) Send(msg interface{}) error {
func (g *grpcStream) Recv(msg interface{}) (err error) { func (g *grpcStream) Recv(msg interface{}) (err error) {
defer g.setError(err) defer g.setError(err)
if err = g.stream.RecvMsg(msg); err != nil { if err = g.stream.RecvMsg(msg); err != nil {
if err == io.EOF { // #202 - inconsistent gRPC stream behavior
// #202 - inconsistent gRPC stream behavior // the only way to tell if the stream is done is when we get a EOF on the Recv
// the only way to tell if the stream is done is when we get a EOF on the Recv // here we should close the underlying gRPC ClientConn
// here we should close the underlying gRPC ClientConn closeErr := g.conn.Close()
closeErr := g.conn.Close() if err == io.EOF && closeErr != nil {
if closeErr != nil { err = closeErr
err = closeErr
}
} }
} }
return return