linting fixes

Signed-off-by: Vasiliy Tolstov <v.tolstov@unistack.org>

store/cloudflare/cloudflare.go

@@ -136,6 +136,7 @@ func (w *workersKV) Read(keys ...string) ([]*store.Record, error) {
 	ctx, cancel := context.WithTimeout(context.Background(), 30*time.Second)
 	defer cancel()
 
+	//nolint:prealloc
 	var records []*store.Record
 
 	for _, k := range keys {

store/etcd/etcd.go

@@ -17,6 +17,7 @@ type ekv struct {
 }
 
 func (e *ekv) Read(keys ...string) ([]*store.Record, error) {
+	//nolint:prealloc
 	var values []*mvccpb.KeyValue
 
 	for _, key := range keys {
@@ -73,10 +74,10 @@ func (e *ekv) List() ([]*store.Record, error) {
 	if err != nil {
 		return nil, err
 	}
-	var vals []*store.Record
 	if keyval == nil || len(keyval.Kvs) == 0 {
-		return vals, nil
+		return nil, nil
 	}
+	vals := make([]*store.Record, 0, len(keyval.Kvs))
 	for _, keyv := range keyval.Kvs {
 		vals = append(vals, &store.Record{
 			Key:   string(keyv.Key),

store/memory/memory.go

@@ -25,6 +25,7 @@ func (m *memoryStore) List() ([]*store.Record, error) {
 	m.RLock()
 	defer m.RUnlock()
 
+	//nolint:prealloc
 	var values []*store.Record
 
 	for _, v := range m.values {
@@ -52,6 +53,7 @@ func (m *memoryStore) Read(keys ...string) ([]*store.Record, error) {
 	m.RLock()
 	defer m.RUnlock()
 
+	//nolint:prealloc
 	var records []*store.Record
 
 	for _, key := range keys {

store/postgresql/postgresql_test.go

@@ -76,20 +76,20 @@ func TestSQL(t *testing.T) {
 	records, err = sqlStore.Read("test")
 	if err != nil {
 		t.Error(err)
-	} else {
-		t.Logf("%# v\n", pretty.Formatter(records))
-		if string(records[0].Value) != "bar" {
-			t.Error("Expected bar, got ", string(records[0].Value))
-		}
+	}
+	t.Logf("%# v\n", pretty.Formatter(records))
+	if string(records[0].Value) != "bar" {
+		t.Error("Expected bar, got ", string(records[0].Value))
 	}
 
 	time.Sleep(61 * time.Second)
-	records, err = sqlStore.Read("test")
-	if err == nil {
+	_, err = sqlStore.Read("test")
+	switch err {
+	case nil:
 		t.Error("Key test should have expired")
-	} else {
-		if err != store.ErrNotFound {
-			t.Error(err)
-		}
+	default:
+		t.Error(err)
+	case store.ErrNotFound:
+		break
 	}
 }

store/service/handler/handler.go

@@ -30,7 +30,7 @@ func (s *Store) Read(ctx context.Context, req *pb.ReadRequest, rsp *pb.ReadRespo
 }
 
 func (s *Store) Write(ctx context.Context, req *pb.WriteRequest, rsp *pb.WriteResponse) error {
-	var records []*store.Record
+	records := make([]*store.Record, 0, len(req.Records))
 
 	for _, record := range req.Records {
 		records = append(records, &store.Record{

store/service/service.go

@@ -60,7 +60,8 @@ func (s *serviceStore) Read(keys ...string) ([]*store.Record, error) {
 	if err != nil {
 		return nil, err
 	}
-	var records []*store.Record
+
+	records := make([]*store.Record, 0, len(rsp.Records))
 	for _, val := range rsp.Records {
 		records = append(records, &store.Record{
 			Key:    val.Key,
@@ -73,7 +74,7 @@ func (s *serviceStore) Read(keys ...string) ([]*store.Record, error) {
 
 // Write a record
 func (s *serviceStore) Write(recs ...*store.Record) error {
-	var records []*pb.Record
+	records := make([]*pb.Record, 0, len(recs))
 
 	for _, record := range recs {
 		records = append(records, &pb.Record{