From a997a86e49cbf7bb08bcdaca3dea7aca703ba6d0 Mon Sep 17 00:00:00 2001 From: Asim Aslam Date: Fri, 24 Jan 2020 21:44:48 +0000 Subject: [PATCH] add trace context --- debug/trace/default.go | 8 ++++---- debug/trace/trace.go | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/debug/trace/default.go b/debug/trace/default.go index 05fd9d97..65e3aa84 100644 --- a/debug/trace/default.go +++ b/debug/trace/default.go @@ -37,7 +37,7 @@ func (t *trace) Read(opts ...ReadOption) ([]*Span, error) { return spans, nil } -func (t *trace) Start(ctx context.Context, name string) *Span { +func (t *trace) Start(ctx context.Context, name string) (context.Context, *Span) { span := &Span{ Name: name, Trace: uuid.New().String(), @@ -48,12 +48,12 @@ func (t *trace) Start(ctx context.Context, name string) *Span { // return span if no context if ctx == nil { - return span + return context.Background(), span } s, ok := FromContext(ctx) if !ok { - return span + return ctx, span } // set trace id @@ -62,7 +62,7 @@ func (t *trace) Start(ctx context.Context, name string) *Span { span.Parent = s.Id // return the sapn - return span + return ctx, span } func (t *trace) Finish(s *Span) error { diff --git a/debug/trace/trace.go b/debug/trace/trace.go index 229ce981..a4287213 100644 --- a/debug/trace/trace.go +++ b/debug/trace/trace.go @@ -9,7 +9,7 @@ import ( // Trace is an interface for distributed tracing type Trace interface { // Start a trace - Start(ctx context.Context, name string) *Span + Start(ctx context.Context, name string) (context.Context, *Span) // Finish the trace Finish(*Span) error // Read the traces