Merge pull request #1016 from unistack-org/lint

lint fixes mostly for prealloc also remove deadcode from grpc client

network/default.go

@@ -195,6 +195,7 @@ func (n *network) resolveNodes() ([]string, error) {
 	nodeMap := make(map[string]bool)
 
 	// collect network node addresses
+	//nolint:prealloc
 	var nodes []string
 	var i int
 

network/resolver/dns/dns.go

@@ -38,6 +38,7 @@ func (r *Resolver) Resolve(name string) ([]*resolver.Record, error) {
 		return nil, err
 	}
 
+	//nolint:prealloc
 	var records []*resolver.Record
 
 	for _, answer := range rec.Answer {

network/resolver/dnssrv/dnssrv.go

@@ -17,7 +17,7 @@ func (r *Resolver) Resolve(name string) ([]*resolver.Record, error) {
 	if err != nil {
 		return nil, err
 	}
-	var records []*resolver.Record
+	records := make([]*resolver.Record, len(addrs))
 	for _, addr := range addrs {
 		address := addr.Target
 		if addr.Port > 0 {

network/service/handler/handler.go

@@ -29,10 +29,11 @@ func flatten(n network.Node, visited map[string]bool) []network.Node {
 	}
 
 	// create new list of nodes
+	//nolint:prealloc
 	var nodes []network.Node
 
 	// check if already visited
-	if visited[n.Id()] == false {
+	if !visited[n.Id()] {
 		// append the current node
 		nodes = append(nodes, n)
 	}