unistack-org/micro
4
0
Fork 3
Code Issues 18 Pull Requests 1 Actions Packages Projects Releases 264 Wiki Activity

on service.Init only process options once

Browse Source
This commit is contained in:
Asim Aslam 2017-03-30 17:15:59 +01:00
parent a933aa79c6
commit b43985401a
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
service.go
View File

@ -68,9 +68,11 @@ func (s *service) Init(opts ...Option) {
// This is pretty ugly, find a better way // This is pretty ugly, find a better way
options := newOptions() options := newOptions()
options.Cmd = s.opts.Cmd options.Cmd = s.opts.Cmd
for _, o := range opts { for _, o := range opts {
o(&options) o(&options)
} }
s.opts.Cmd = options.Cmd s.opts.Cmd = options.Cmd
// Initialise the command flags, overriding new service // Initialise the command flags, overriding new service
@ -82,11 +84,6 @@ func (s *service) Init(opts ...Option) {
cmd.Server(&s.opts.Server), cmd.Server(&s.opts.Server),
) )
} }
// Update any options to override command flags
for _, o := range opts {
o(&s.opts)
}
} }
func (s *service) Options() Options { func (s *service) Options() Options {