From b51b4107a85d96faedf71c86aa28dfd17c40e593 Mon Sep 17 00:00:00 2001 From: Vasiliy Tolstov Date: Thu, 6 Feb 2025 16:21:29 +0300 Subject: [PATCH] logger/slog: fixup stacktrace Signed-off-by: Vasiliy Tolstov --- logger/slog/slog.go | 2 +- logger/slog/slog_test.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/logger/slog/slog.go b/logger/slog/slog.go index 1f6589db..de9e1df2 100644 --- a/logger/slog/slog.go +++ b/logger/slog/slog.go @@ -278,7 +278,7 @@ func (s *slogLogger) printLog(ctx context.Context, lvl logger.Level, msg string, } } - if (s.opts.AddStacktrace || lvl == logger.FatalLevel) || (s.opts.AddStacktrace && lvl == logger.ErrorLevel) { + if s.opts.AddStacktrace && (lvl == logger.FatalLevel || lvl == logger.ErrorLevel) { stackInfo := make([]byte, 1024*1024) if stackSize := runtime.Stack(stackInfo, false); stackSize > 0 { traceLines := reTrace.Split(string(stackInfo[:stackSize]), -1) diff --git a/logger/slog/slog_test.go b/logger/slog/slog_test.go index deb87eda..4d59a5a7 100644 --- a/logger/slog/slog_test.go +++ b/logger/slog/slog_test.go @@ -21,7 +21,7 @@ import ( func TestStacktrace(t *testing.T) { ctx := context.TODO() buf := bytes.NewBuffer(nil) - l := NewLogger(logger.WithLevel(logger.ErrorLevel), logger.WithOutput(buf), + l := NewLogger(logger.WithLevel(logger.DebugLevel), logger.WithOutput(buf), WithHandlerFunc(slog.NewTextHandler), logger.WithAddStacktrace(true), )