From c2333a9f35e5c0f71cf99809b97e40c51c839d09 Mon Sep 17 00:00:00 2001 From: Vasiliy Tolstov Date: Sun, 14 Feb 2021 16:26:40 +0300 Subject: [PATCH] gh actions not fail on lint errors Signed-off-by: Vasiliy Tolstov --- .github/workflows/build.yml | 2 +- .github/workflows/pr.yml | 4 ++-- .golangci.yml | 10 ---------- 3 files changed, 3 insertions(+), 13 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 678decb9..8ce77c79 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -50,7 +50,7 @@ jobs: uses: actions/checkout@v2 - name: lint uses: golangci/golangci-lint-action@v2 - # continue-on-error: true + continue-on-error: true with: # Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version. version: v1.30 diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index 6a8bf00e..00f8b88c 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -15,7 +15,7 @@ jobs: - name: cache uses: actions/cache@v2 with: - path: ~/go/pkg/mod + path: ~/go/pkg key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }} restore-keys: ${{ runner.os }}-go- - name: sdk checkout @@ -50,7 +50,7 @@ jobs: uses: actions/checkout@v2 - name: lint uses: golangci/golangci-lint-action@v2 - # continue-on-error: true + continue-on-error: true with: # Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version. version: v1.30 diff --git a/.golangci.yml b/.golangci.yml index 5c65ecae..6a816174 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -1,8 +1,6 @@ run: deadline: 5m modules-download-mode: readonly - skip-dirs: - - util/mdns.new skip-files: - ".*\\.pb\\.go$" - ".*\\.pb\\.micro\\.go$" @@ -30,11 +28,3 @@ linters: - interfacer - typecheck - dupl -output: - format: colored-line-number - # print lines of code with issue, default is true - print-issued-lines: true - # print linter name in the end of issue text, default is true - print-linter-name: true - # make issues output unique by line, default is true - uniq-by-line: true