unistack-org/micro
4
0
Fork 3
Code Issues 14 Pull Requests 2 Actions 2 Packages Projects Releases 252 Wiki Activity

router/registry: fix not started bug (#1877)

Browse Source
This commit is contained in:
ben-toogood 2020-07-28 09:01:08 +01:00 committed by GitHub
parent f17e4fdb44
commit cb4a2864da
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
router/registry/registry.go
View File

@ -1,7 +1,6 @@
package registry package registry
import ( import (
"errors"
"fmt" "fmt"
"sort" "sort"
"strings" "strings"
@ -55,6 +54,9 @@ func NewRouter(opts ...router.Option) router.Router {
// create the new table, passing the fetchRoute method in as a fallback if // create the new table, passing the fetchRoute method in as a fallback if
// the table doesn't contain the result for a query. // the table doesn't contain the result for a query.
r.table = newTable(r.fetchRoutes) r.table = newTable(r.fetchRoutes)
// start the router
r.start()
return r return r
} }
@ -545,13 +547,6 @@ func (r *rtr) Advertise() (<-chan *router.Advert, error) {
r.Lock() r.Lock()
defer r.Unlock() defer r.Unlock()
if r.running {
return nil, errors.New("cannot re-advertise, already running")
}
// start the router
r.start()
// we're mutating the subscribers so they need to be locked also // we're mutating the subscribers so they need to be locked also
r.sub.Lock() r.sub.Lock()
defer r.sub.Unlock() defer r.sub.Unlock()