From d606d00f35615e1e50416bae0d7638d342fdbd6d Mon Sep 17 00:00:00 2001 From: Asim Aslam Date: Thu, 15 Dec 2016 20:45:27 +0000 Subject: [PATCH] superfluous logging --- server/rpc_stream.go | 15 ++------------- server/rpcplus_server.go | 3 --- 2 files changed, 2 insertions(+), 16 deletions(-) diff --git a/server/rpc_stream.go b/server/rpc_stream.go index 41be265a..99a0512e 100644 --- a/server/rpc_stream.go +++ b/server/rpc_stream.go @@ -1,7 +1,6 @@ package server import ( - "log" "sync" "golang.org/x/net/context" @@ -35,12 +34,7 @@ func (r *rpcStream) Send(msg interface{}) error { Seq: r.seq, } - err := r.codec.WriteResponse(&resp, msg, false) - if err != nil { - log.Println("rpc: writing response:", err) - } - - return err + return r.codec.WriteResponse(&resp, msg, false) } func (r *rpcStream) Recv(msg interface{}) error { @@ -57,12 +51,7 @@ func (r *rpcStream) Recv(msg interface{}) error { // we need to stay up to date with sequence numbers r.seq = req.Seq - - if err := r.codec.ReadRequestBody(msg); err != nil { - return err - } - - return nil + return r.codec.ReadRequestBody(msg) } func (r *rpcStream) Error() error { diff --git a/server/rpcplus_server.go b/server/rpcplus_server.go index d7bc33a4..fb5426cd 100644 --- a/server/rpcplus_server.go +++ b/server/rpcplus_server.go @@ -210,9 +210,6 @@ func (server *server) sendResponse(sending *sync.Mutex, req *request, reply inte resp.Seq = req.Seq sending.Lock() err = codec.WriteResponse(resp, reply, last) - if err != nil { - log.Println("rpc: writing response:", err) - } sending.Unlock() server.freeResponse(resp) return err