unistack-org/micro
4
0
Fork 3
Code Issues 18 Pull Requests 1 Actions Packages Projects Releases 265 Wiki Activity

Merge pull request #737 from milosgajdos83/buffered-advertchan

Browse Source 
Lets make advert channel buffered so we don't lose adverts
This commit is contained in:
Asim Aslam 2019-09-05 19:19:03 +01:00 committed by GitHub
commit df5657dcd1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
router/default.go
View File

@ -10,6 +10,7 @@ import (
"github.com/google/uuid" "github.com/google/uuid"
"github.com/micro/go-micro/registry" "github.com/micro/go-micro/registry"
"github.com/micro/go-micro/util/log"
) )
const ( const (
@ -289,6 +290,7 @@ func (r *router) publishAdvert(advType AdvertType, events []*Event) {
Events: events, Events: events,
} }
log.Debugf("Router publishing advert; %+v", a)
r.RLock() r.RLock()
for _, sub := range r.subscribers { for _, sub := range r.subscribers {
// check the exit chan first // check the exit chan first
@ -601,7 +603,7 @@ func (r *router) Advertise() (<-chan *Advert, error) {
switch r.status.Code { switch r.status.Code {
case Advertising: case Advertising:
advertChan := make(chan *Advert) advertChan := make(chan *Advert, 128)
r.subscribers[uuid.New().String()] = advertChan r.subscribers[uuid.New().String()] = advertChan
return advertChan, nil return advertChan, nil
case Running: case Running:
@ -641,7 +643,7 @@ func (r *router) Advertise() (<-chan *Advert, error) {
r.status = Status{Code: Advertising, Error: nil} r.status = Status{Code: Advertising, Error: nil}
// create advert channel // create advert channel
advertChan := make(chan *Advert) advertChan := make(chan *Advert, 128)
r.subscribers[uuid.New().String()] = advertChan r.subscribers[uuid.New().String()] = advertChan
return advertChan, nil return advertChan, nil