Fixing log file path in logs (#1578)

This commit is contained in:
Janos Dobronszki 2020-04-27 10:36:09 +02:00 committed by GitHub
parent e0c9234c0e
commit ec44b67e9f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -4,8 +4,10 @@ import (
"context" "context"
"fmt" "fmt"
"os" "os"
"path"
"runtime" "runtime"
"sort" "sort"
"strings"
"sync" "sync"
"time" "time"
@ -53,6 +55,20 @@ func copyFields(src map[string]interface{}) map[string]interface{} {
return dst return dst
} }
var sourceControlSites = []string{"github.com"}
func logCallerfilePath(filepath string) string {
for _, v := range sourceControlSites {
if strings.Contains(filepath, v) {
parts := strings.Split(filepath, v)
if len(parts) > 0 {
return path.Join(v, parts[1])
}
}
}
return filepath
}
func (l *defaultLogger) Log(level Level, v ...interface{}) { func (l *defaultLogger) Log(level Level, v ...interface{}) {
// TODO decide does we need to write message if log level not used? // TODO decide does we need to write message if log level not used?
if !l.opts.Level.Enabled(level) { if !l.opts.Level.Enabled(level) {
@ -66,7 +82,7 @@ func (l *defaultLogger) Log(level Level, v ...interface{}) {
fields["level"] = level.String() fields["level"] = level.String()
if _, file, line, ok := runtime.Caller(l.opts.CallerSkipCount); ok { if _, file, line, ok := runtime.Caller(l.opts.CallerSkipCount); ok {
fields["caller"] = fmt.Sprintf("%s:%d", file, line) fields["caller"] = fmt.Sprintf("%s:%d", logCallerfilePath(file), line)
} }
rec := dlog.Record{ rec := dlog.Record{
@ -107,7 +123,7 @@ func (l *defaultLogger) Logf(level Level, format string, v ...interface{}) {
fields["level"] = level.String() fields["level"] = level.String()
if _, file, line, ok := runtime.Caller(l.opts.CallerSkipCount); ok { if _, file, line, ok := runtime.Caller(l.opts.CallerSkipCount); ok {
fields["caller"] = fmt.Sprintf("%s:%d", file, line) fields["caller"] = fmt.Sprintf("%s:%d", logCallerfilePath(file), line)
} }
rec := dlog.Record{ rec := dlog.Record{
@ -151,7 +167,7 @@ func NewLogger(opts ...Option) Logger {
Level: InfoLevel, Level: InfoLevel,
Fields: make(map[string]interface{}), Fields: make(map[string]interface{}),
Out: os.Stderr, Out: os.Stderr,
CallerSkipCount: 1, CallerSkipCount: 2,
Context: context.Background(), Context: context.Background(),
} }