From f25ad35f0a6a15566759517bed338a4532f4c2fb Mon Sep 17 00:00:00 2001 From: Lars Lehtonen Date: Mon, 9 Dec 2019 09:28:42 -0800 Subject: [PATCH] web: fix test goroutine in TestTLS() --- web/service_test.go | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/web/service_test.go b/web/service_test.go index 588531b8..a4447174 100644 --- a/web/service_test.go +++ b/web/service_test.go @@ -221,10 +221,10 @@ func TestTLS(t *testing.T) { service.HandleFunc("/", fn) + errCh := make(chan error, 1) go func() { - if err := service.Run(); err != nil { - t.Fatal(err) - } + errCh <- service.Run() + close(errCh) }() var s []*registry.Service @@ -257,4 +257,13 @@ func TestTLS(t *testing.T) { if string(b) != str { t.Errorf("Expected %s got %s", str, string(b)) } + + select { + case err := <-errCh: + if err != nil { + t.Fatalf("Run():%v", err) + } + case <-time.After(time.Duration(time.Second)): + t.Logf("service.Run() survived a client request without an error") + } }