unistack-org/micro
4
0
Fork 3
Code Issues 18 Pull Requests 1 Actions Packages Projects Releases 265 Wiki Activity
942 Commits 10 Branches 350 Tags 11 MiB
d8ba18deff
Commit Graph

175 Commits

Author SHA1 Message Date
Hao Lian
d4b149046f server/rpc_codec: if c.codec.Write fails, reset write buffer and encode an error message about the encoding failure 
When developing go-micro services, it is frequently possible to set invalid results in the response pointer. When this happens (as I and @trushton personally experienced), `sendResponse()` returns an error correctly explaining what happened (e.g. protobuf refused to encode a bad struct) but the `call()` function one above it in the stack ignores the returned error object.

Thus, invalid structs go un-encoded and the _client side times out_. @trushton and I first caught this in our CI builds when we left a protobuf.Empty field uninitialized (nil) instead of setting it to `&ptypes.Empty{}`. This resulted in an `proto: oneof field has nil value` error, but it was dropped and became a terribly confusing client timeout instead.

This patch is two independent changes:

* In rpc_codec, when a serialization failure occurs serialize an error message, which will correctly become a 500 for HTTP services, about the encoding failure. This means rpc_codec only returns an `error` when a socket failure occurs, which I believe is the behavior that rpc_service is expecting anyway.

* In rpc_service, log any errors returned by sendResponse instead of dropping the error object. This will make debugging client timeouts less of a hassle.
 2017-07-17 14:21:43 -04:00
Asim Aslam
3812cbbcb6 defer wg.Done so it's called even if there's a panic 2017-06-12 14:18:59 +01:00
Asim Aslam
e1a1f1c0f0 add wait option 2017-05-31 19:47:50 +01:00
Asim Aslam
f7a9207c7a wait for subscribers to complete 2017-05-31 19:47:41 +01:00
Asim Aslam
2ee22f5336 strip init of wg 2017-05-31 19:35:16 +01:00
Asim Aslam
276a0118da be pedantic 2017-05-31 19:33:11 +01:00
Asim Aslam
726793b6fa Wait for requests to finish before closing transport 2017-05-31 19:21:41 +01:00
Asim Aslam
a7312f5c7e log panics 2017-05-16 19:14:00 +01:00
Asim Aslam
5bce20627f Switch that back to Fatal since we've added the convenience method 2017-05-12 15:14:54 +01:00
Asim Aslam
bab586b71e make use of micro/go-log 2017-05-11 20:43:42 +01:00
Asim Aslam
238c99d228 rename file to please the OCD gods 2017-01-12 20:38:43 +00:00
Asim Aslam
a9889730d6 move addr extractor to misc 2017-01-12 13:20:34 +00:00
Asim Aslam
d606d00f35 superfluous logging 2016-12-15 20:45:27 +00:00
Asim Aslam
71d717a06d strip doc.go files 2016-12-14 15:41:48 +00:00
Asim
a36e042983 We don't need numcalls, save us a mutex lock 2016-11-01 19:40:36 +00:00
Asim
15f19b700f Use struct tags if available 2016-07-30 19:01:42 +01:00
Asim
739b094cd2 Merge branch 'master' into pool 2016-06-06 14:06:03 +01:00
Asim
93c1ae6221 Add debug stats handler 2016-05-28 22:30:47 +01:00
Asim
7a5a9013ef move the option 2016-05-26 20:43:05 +01:00
Asim
ee3ae89ca8 naming nitpick 2016-05-26 20:25:00 +01:00
Asim
8245390b5a Support endpoint metadata 2016-05-26 18:01:02 +01:00
Asim
1254a87286 Add package comments 2016-05-24 22:22:46 +01:00
Asim
2e9f4271a8 Pool first attempt 2016-05-13 15:58:53 +01:00
Asim
8c8573426c Add cascading timeouts 2016-05-12 23:32:58 +01:00
Asim
aea81315d0 Change QueueName to Queue 2016-05-10 10:55:18 +01:00
Asim
decb70b97c Response type for Stream is an interface 2016-04-26 15:52:08 +01:00
Asim
ca91a8383e Add mock server 2016-04-16 00:02:55 +01:00
Asim
bfe20d81d0 More linting fun 2016-04-06 18:03:27 +01:00
Asim
2f50c74f41 Satisfy the golint gods a little 2016-04-06 17:53:16 +01:00
Asim
fe4362be5a Merge pull request #57 from micro/log 
remove use of glog
 2016-03-15 20:56:11 +00:00
Asim
d1eae8fabe remove use of glog 2016-03-14 11:01:10 +00:00
Asim
71764564e7 Add packages for the defaults 2016-03-14 10:45:38 +00:00
Asim
1adcb237d9 Only log registering if not registered 2016-02-27 22:14:25 +00:00
Asim
8e61057bc9 Allow init of wrappers and name. Set server.name for rpc request 2016-02-18 18:08:43 +00:00
Asim
8cd906e75e Set TTL on first registration of http broker. Also dont resubscribe 2016-02-15 22:20:54 +00:00
Asim
6b7f2f3bd3 Merge pull request #45 from micro/metadata 
Move context to metadata
 2016-01-28 18:30:53 +00:00
Asim
1cc621e2d6 FromContext/NewContext methods 2016-01-28 18:23:24 +00:00
Asim
d306559d8f Nitpick Headers to Header 2016-01-28 18:11:13 +00:00
Asim
9ae0956cea Move context to metadata 2016-01-28 17:55:28 +00:00
Asim
013d1de2c4 Prefer RegisterTTL set through Init 2016-01-27 12:23:18 +00:00
Asim
5ec9d561a6 meh 2016-01-26 23:32:27 +00:00
Asim
51d2ce2b4f Support setting subscriber queue name 2016-01-22 21:48:43 +00:00
Asim
93ea171b31 We need the right sequence number for the stream 2016-01-21 01:03:27 +00:00
Asim
fb25558142 Merge pull request #42 from micro/internal_handler 
Add implementation for internal handlers and subscribers.
 2016-01-08 15:00:53 +00:00
Asim
f812613973 Add implementation for internal handlers and subscribers. They are not advertised to discovery 2016-01-08 14:02:32 +00:00
Jelmer Snoeck
3cefc39aff Debug: use the DebugHandler interface. 
Without specifying the interface, DefaultDebugHandler has to be of type
*"github.com/micro/go-micro/server/debug".debug.
 2016-01-07 10:15:30 +00:00
Asim
76918fc703 Make the debug handler an actual thing that can be set by users 2016-01-06 19:24:54 +00:00
Asim
66107fd304 Merge pull request #36 from jelmersnoeck/extendable-health-checker 
DebugHandler: add default health checker.
 2016-01-06 17:14:59 +00:00
Jelmer Snoeck
0d749eb732 DebugHandler: add default health checker. 
By using a DefaultHealthChecker - as with a DefaultName, DefaultServer,
... - it is possible to overwrite the default implementation. This means
we can now do extra actions in our health check that is necessary for
the applications specific needs.
 2016-01-06 17:05:22 +00:00
Asim
8bf72a3325 Replace map[string]string with Context for extra options. map[string]string is essentially useless. Context can store anything 2016-01-06 16:25:12 +00:00
Asim
f467902304 update the example to message the naming of code generated protos 2016-01-06 12:37:35 +00:00
Asim
3e84c23591 Tell me what the registry is too 2016-01-04 23:27:44 +00:00
Asim
227adc490c Add broker and server to metadata 2016-01-04 01:27:05 +00:00
Asim
3b56a62589 Update the way flags are used 2016-01-02 19:12:17 +00:00
Asim
1f1bc27421 Make command internal 2016-01-02 00:38:57 +00:00
Asim
64b45f7846 Update options to be public. This means people can implement the interfaces and actually use the options 2015-12-31 18:11:46 +00:00
Asim
3dd911fb33 Stop recursive loop where its a recursive type 2015-12-25 01:06:51 +00:00
Asim
34947f1be7 Merge pull request #32 from micro/broker 
Update the broker interface to support acking and queue distribution
 2015-12-24 20:03:24 +00:00
Asim
1da6de05ee Fix server panic 2015-12-23 22:45:32 +00:00
Asim
536216fd01 Fix the rest of the code 2015-12-23 19:16:55 +00:00
Asim
6226a80e78 Print stack when panic 2015-12-21 17:18:04 +00:00
Asim
be43d827c7 Add String method to all interfaces 2015-12-19 21:56:14 +00:00
Asim
3b295b16e7 Working bidirectional streaming example 2015-12-18 20:28:50 +00:00
Asim
4cba0c57ab Checkpoint the world 2015-12-18 01:01:59 +00:00
Asim
6ae48c9f29 checkpoint 2015-12-17 20:37:35 +00:00
Asim
ba3b056e76 add headers 2015-12-16 02:15:09 +00:00
Asim
dd73c1f0ac support slices in extractor, longer term need to look at all types 2015-12-07 16:12:46 +00:00
Asim
919bfed0c1 add comments 2015-12-03 01:05:16 +00:00
Asim
20114ccd87 move the comment 2015-12-03 00:59:32 +00:00
Asim
a69811fc72 Fix the sub extractor 2015-12-03 00:49:58 +00:00
Asim
9c17e64ef1 add comments for wrappers 2015-12-02 21:16:44 +00:00
Asim
5e364693ee Rename to hdlrWrappers for symmetry sake 2015-12-02 21:12:09 +00:00
Asim
96d7975052 make it clear that it flags streaming response 2015-12-02 21:02:46 +00:00
Asim
a695e10d21 Send Request and Publication types 2015-12-02 20:56:50 +00:00
Asim
4b18b779aa Update to use actual values passed through the chain 2015-12-02 20:11:00 +00:00
Asim
eef155490e Setup subscription wrappers 2015-12-02 19:56:57 +00:00
Asim
cfa676af19 Only support single signature for subscriber and validate 2015-12-02 17:42:14 +00:00
Asim
b1511ed813 Update wrapper and examples 2015-12-02 11:54:36 +00:00
Asim
c5a08d3159 Some nitpicking 2015-12-02 01:38:56 +00:00
Asim
7a870dfbb1 Strip named registration 2015-12-02 01:18:32 +00:00
Asim
dae745f30f Experimental server side wrappers for handlers 2015-12-02 00:47:52 +00:00
Asim
0c9f8411bb Pull rpcplus in local for the time being. We need to modify it for server side middleware 2015-12-01 23:32:23 +00:00
Asim
8825b5c0a8 rename debug handler 2015-12-01 19:13:48 +00:00
Asim
bf01feb2e3 Fix comment for godoc 2015-12-01 18:45:52 +00:00
Asim
d02986d1bd Add some comments 2015-12-01 18:41:43 +00:00
Asim
dddcdc34ed rename to protorpc and jsonrpc 2015-11-28 18:54:38 +00:00
Asim
80f53ab176 Add json codec 2015-11-28 18:40:32 +00:00
Asim
654728027b Updated codec interface and code. Painful stuff 2015-11-28 11:22:29 +00:00
Asim
f49922f6b3 experimental codec branch 2015-11-27 00:17:36 +00:00
Asim
ad6e8194ed Add client comments 2015-11-26 12:21:00 +00:00
Asim
24b8cd3d97 more comments 2015-11-26 00:23:36 +00:00
Asim
bb360d5f2c add comment 2015-11-26 00:18:39 +00:00
Asim
c4d8701d68 add comment 2015-11-26 00:17:05 +00:00
Asim
96955dbd53 add comments 2015-11-26 00:13:17 +00:00
Asim
40fea1ac24 nitpick ordering 2015-11-25 20:22:49 +00:00
Asim
12a1e1eeda Add pluggable codec support 2015-11-25 19:50:05 +00:00
Asim
469b12ecea Temporary stop gap for panicking server handlers 2015-11-24 00:52:59 +00:00
Asim
5d88115f2a update links from myodc to micro 2015-11-20 16:17:33 +00:00
Asim
2041591033 add advertising option 2015-11-11 18:22:04 +00:00
Asim
4e6d1df9ea Add extractor test 2015-11-05 12:39:08 +00:00