Commit Graph

3620 Commits

Author SHA1 Message Date
Asim Aslam
419b952fb3 Merge pull request #119 from jelmersnoeck/jelmer/consul-registry-node-health
ConsulRegistry: use health checks to select nodes.
2016-08-26 12:13:47 +01:00
Jelmer Snoeck
e59f7a7ace
ConsulRegistry: use health checks to select nodes.
Consul sees a healthcheck that is in the warning state as a "failed"
node. This means that when we ask Consul for services that are passing,
it would not return nodes that have warning healthchecks.

In the cache, we only check on critical to skip for nodes. This makes
the cache out of sync with the non-cache implementation.

This patch reworks the non-cache implementation to ask for all nodes
(even unhealthy ones) and does the same check as within the cache, skip
nodes that have critical healthchecks.

We've noticed this issue when we deployed custom healthchecks where the
cache was acting properly, but after 1 minute we saw "None Available"
errors. This is due to the TTL expiry on the cache, which is then
followed by doing a non cached request.
2016-08-26 08:36:45 +01:00
Asim
b8241f3026 specify the Accept header along with Content-Type 2016-08-25 13:34:47 +01:00
Asim
71d64f911f make a copy of services for handle method 2016-08-24 18:37:11 +01:00
Asim
0afaaeec8d make a copy of services 2016-08-24 18:27:15 +01:00
Asim Aslam
321358ae1f Merge pull request #115 from jelmersnoeck/jelmer/deregister-node-if-checks-fail
ConsulWatcher: deregister if service checks fail.
2016-08-11 16:13:49 +01:00
Jelmer Snoeck
81231c0b6f
ConsulWatcher: deregister if service checks fail. 2016-08-11 15:18:50 +01:00
Asim
66c38b75aa Name timeout rather than deadline 2016-08-01 16:31:27 +01:00
Asim Aslam
56aaeff042 Merge pull request #114 from micro/extractor
Use struct tags if available
2016-08-01 13:03:32 +01:00
Asim
15f19b700f Use struct tags if available 2016-07-30 19:01:42 +01:00
Asim
2d6c403992 don't close next chan, instead use exit chan 2016-07-30 11:58:10 +01:00
Asim Aslam
720bda1439 Merge pull request #112 from micro/deadline
Transport Deadline Support
2016-07-29 16:29:14 +01:00
Asim
9d08a7955d add deadline test 2016-07-29 15:30:51 +01:00
Asim
e7903c65ce use deadline within http transport 2016-07-28 19:12:56 +01:00
Asim
5b034ba253 Add deadline option 2016-07-28 18:38:17 +01:00
Asim
32f9546ed5 nitpick 2016-07-03 02:52:04 +01:00
Asim
65d6e45707 update readme 2016-07-03 02:49:13 +01:00
Asim
db087eff3b update mailing list link 2016-07-03 02:05:19 +01:00
Asim
5827e1ab2b nitpick that blurb 2016-07-03 02:02:17 +01:00
Asim
2460132391 add link to greeter 2016-07-03 02:00:22 +01:00
Asim
6aac602b31 return error when zero services in mock registry 2016-06-30 20:11:04 +01:00
Asim
0190b1ab3a Don't unmarshal if result is nil 2016-06-30 16:45:30 +01:00
Asim
02481c4446 request panic catch all 2016-06-30 16:19:02 +01:00
Asim
7640a76d88 Change help messages 2016-06-28 22:41:44 +01:00
Asim
1cdf98418f add http broker benchmark so we can test codec changes 2016-06-25 03:15:56 +01:00
Asim
0348d0eed9 Concurrent use of message and we modify it, bad practice, copy it 2016-06-25 03:15:42 +01:00
Asim
7968a8eb6d Update table 2016-06-21 03:27:08 +01:00
Asim
fe89a7633f Update table 2016-06-21 03:26:22 +01:00
Asim
5447a7ae7c Update table 2016-06-21 03:25:27 +01:00
Asim
619517a611 Update table 2016-06-21 03:24:49 +01:00
Asim
2df23e4371 reword some more 2016-06-20 02:55:36 +01:00
Asim
03f1a4e6d4 change travis link 2016-06-20 02:54:06 +01:00
Asim
d0f67931d0 reword readme 2016-06-20 02:52:38 +01:00
Asim
5b381f13f0 Add comments 2016-06-19 16:02:14 +01:00
Asim
30e0fef615 Strip blacklist 2016-06-19 14:41:33 +01:00
Asim
95f1e80af4 Add alternative mdns comment 2016-06-18 23:19:52 +01:00
Asim
02a0eb29d2 Temporarily disable blacklisting 2016-06-17 15:41:29 +01:00
Asim Aslam
d31cd76b8c Merge pull request #86 from micro/pool
Connection Pooling
2016-06-07 01:35:25 +01:00
Asim
ff0bd76905 Add a pool test 2016-06-07 01:18:54 +01:00
Asim
58ad01e3e1 Don't log that cruft 2016-06-07 00:48:34 +01:00
Asim
89401cbb95 Make pool configurable 2016-06-07 00:46:14 +01:00
Asim
38a66817e6 Add a conn lifetime for the pool 2016-06-06 23:37:52 +01:00
Asim
6669248291 gofmt 2016-06-06 23:37:07 +01:00
Asim
739b094cd2 Merge branch 'master' into pool 2016-06-06 14:06:03 +01:00
Asim
69aa8537d3 Add some comments 2016-06-06 14:05:02 +01:00
Asim Aslam
05596cfae4 Merge pull request #99 from xujinzheng/master
improve self-signed host list
2016-06-06 14:02:16 +01:00
Zeal
d8ecd42868 rename getIPAddrList() to getIPAddrs and improve code format 2016-06-06 20:56:53 +08:00
Zeal
eb0422cee1 improve self-signed host list 2016-06-05 23:13:29 +08:00
Asim
34365812d8 Fix double close 2016-06-03 11:08:58 +01:00
Asim
702072f177 Make mock listen on random port if 0 is specified 2016-06-01 15:22:27 +01:00