unistack-org/micro
3
0
Fork 3
Code Issues 16 Pull Requests 2 Actions Packages Projects Releases 239 Wiki Activity

server: fix race in noop server #117

Merged
vtolstov merged 1 commits from race into v3 2022-04-15 15:53:18 +03:00
Conversation 1 Commits 1 Files Changed 1 +2 -2
vtolstov commented 2022-04-15 15:51:06 +03:00 (Migrated from github.com)
Copy Link

Signed-off-by: Vasiliy Tolstov v.tolstov@unistack.org

Signed-off-by: Vasiliy Tolstov <v.tolstov@unistack.org>
github-actions[bot] (Migrated from github.com) approved these changes 2022-04-15 15:51:19 +03:00
codecov[bot] commented 2022-04-15 15:51:53 +03:00 (Migrated from github.com)
Copy Link

Codecov Report

Merging #117 (74db004) into v3 (f93ba9d) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v3     #117      +/-   ##
==========================================
- Coverage   34.93%   34.82%   -0.11%     
==========================================
  Files         100      100              
  Lines        8691     8691              
==========================================
- Hits         3036     3027       -9     
- Misses       5341     5349       +8     
- Partials      314      315       +1
Impacted Files Coverage Δ
server/noop.go 60.89% <100.00%> (ø)
broker/memory.go 51.52% <0.00%> (-3.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f93ba9d...74db004. Read the comment docs.

# [Codecov](https://codecov.io/gh/unistack-org/micro/pull/117?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=unistack-org) Report > Merging [#117](https://codecov.io/gh/unistack-org/micro/pull/117?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=unistack-org) (74db004) into [v3](https://codecov.io/gh/unistack-org/micro/commit/f93ba9d977268c61bb87b15044fc1a9d3ebaf659?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=unistack-org) (f93ba9d) will **decrease** coverage by `0.10%`. > The diff coverage is `100.00%`. [![Impacted file tree graph](https://codecov.io/gh/unistack-org/micro/pull/117/graphs/tree.svg?width=650&height=150&src=pr&token=OZPO2LP7VS&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=unistack-org)](https://codecov.io/gh/unistack-org/micro/pull/117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=unistack-org) ```diff @@ Coverage Diff @@ ## v3 #117 +/- ## ========================================== - Coverage 34.93% 34.82% -0.11% ========================================== Files 100 100 Lines 8691 8691 ========================================== - Hits 3036 3027 -9 - Misses 5341 5349 +8 - Partials 314 315 +1 ``` | [Impacted Files](https://codecov.io/gh/unistack-org/micro/pull/117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=unistack-org) | Coverage Δ | | |---|---|---| | [server/noop.go](https://codecov.io/gh/unistack-org/micro/pull/117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=unistack-org#diff-c2VydmVyL25vb3AuZ28=) | `60.89% <100.00%> (ø)` | | | [broker/memory.go](https://codecov.io/gh/unistack-org/micro/pull/117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=unistack-org#diff-YnJva2VyL21lbW9yeS5nbw==) | `51.52% <0.00%> (-3.94%)` | :arrow_down: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/unistack-org/micro/pull/117?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=unistack-org). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=unistack-org) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/unistack-org/micro/pull/117?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=unistack-org). Last update [f93ba9d...74db004](https://codecov.io/gh/unistack-org/micro/pull/117?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=unistack-org). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=unistack-org).
Sign in to join this conversation.
Reviewers
No reviewers
github-actions[bot]
Labels
Clear labels
  
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: unistack-org/micro#117
No description provided.
Delete Branch "race"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?