unistack-org/micro
4
0
Fork 3
Code Issues 20 Pull Requests 1 Actions Packages Projects Releases 280 Wiki Activity

Improvements #130

Merged
vtolstov merged 14 commits from improvements into v3 2022-05-03 16:08:51 +03:00
Conversation 1 Commits 14 Files Changed 16 +373 -41
vtolstov commented 2022-05-03 16:06:20 +03:00 (Migrated from github.com)
Copy Link
  • coverage improvements
* coverage improvements
github-actions[bot] (Migrated from github.com) approved these changes 2022-05-03 16:06:35 +03:00
codecov[bot] commented 2022-05-03 16:07:35 +03:00 (Migrated from github.com)
Copy Link

Codecov Report

Merging #130 (c26ad51) into v3 (b433cbc) will increase coverage by 0.86%.
The diff coverage is 37.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v3     #130      +/-   ##
==========================================
+ Coverage   39.95%   40.82%   +0.86%     
==========================================
  Files          95       95              
  Lines        8515     8532      +17     
==========================================
+ Hits         3402     3483      +81     
+ Misses       4767     4732      -35     
+ Partials      346      317      -29
Impacted Files Coverage Δ
client/noop.go 16.56% <3.57%> (-0.48%) ⬇️
metadata/metadata.go 89.85% <100.00%> (+0.30%) ⬆️
client/lookup.go 0.00% <0.00%> (-17.25%) ⬇️
network/transport/memory.go 70.55% <0.00%> (-1.23%) ⬇️
metadata/context.go 61.85% <0.00%> (+3.09%) ⬆️
store/context.go 36.17% <0.00%> (+12.76%) ⬆️
config/context.go 100.00% <0.00%> (+17.14%) ⬆️
broker/context.go 100.00% <0.00%> (+20.68%) ⬆️
client/context.go 100.00% <0.00%> (+20.68%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b433cbc...c26ad51. Read the comment docs.

# [Codecov](https://codecov.io/gh/unistack-org/micro/pull/130?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=unistack-org) Report > Merging [#130](https://codecov.io/gh/unistack-org/micro/pull/130?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=unistack-org) (c26ad51) into [v3](https://codecov.io/gh/unistack-org/micro/commit/b433cbcbb638bad5da2300de98b18f46ed9b0909?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=unistack-org) (b433cbc) will **increase** coverage by `0.86%`. > The diff coverage is `37.20%`. [![Impacted file tree graph](https://codecov.io/gh/unistack-org/micro/pull/130/graphs/tree.svg?width=650&height=150&src=pr&token=OZPO2LP7VS&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=unistack-org)](https://codecov.io/gh/unistack-org/micro/pull/130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=unistack-org) ```diff @@ Coverage Diff @@ ## v3 #130 +/- ## ========================================== + Coverage 39.95% 40.82% +0.86% ========================================== Files 95 95 Lines 8515 8532 +17 ========================================== + Hits 3402 3483 +81 + Misses 4767 4732 -35 + Partials 346 317 -29 ``` | [Impacted Files](https://codecov.io/gh/unistack-org/micro/pull/130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=unistack-org) | Coverage Δ | | |---|---|---| | [client/noop.go](https://codecov.io/gh/unistack-org/micro/pull/130/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=unistack-org#diff-Y2xpZW50L25vb3AuZ28=) | `16.56% <3.57%> (-0.48%)` | :arrow_down: | | [metadata/metadata.go](https://codecov.io/gh/unistack-org/micro/pull/130/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=unistack-org#diff-bWV0YWRhdGEvbWV0YWRhdGEuZ28=) | `89.85% <100.00%> (+0.30%)` | :arrow_up: | | [client/lookup.go](https://codecov.io/gh/unistack-org/micro/pull/130/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=unistack-org#diff-Y2xpZW50L2xvb2t1cC5nbw==) | `0.00% <0.00%> (-17.25%)` | :arrow_down: | | [network/transport/memory.go](https://codecov.io/gh/unistack-org/micro/pull/130/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=unistack-org#diff-bmV0d29yay90cmFuc3BvcnQvbWVtb3J5Lmdv) | `70.55% <0.00%> (-1.23%)` | :arrow_down: | | [metadata/context.go](https://codecov.io/gh/unistack-org/micro/pull/130/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=unistack-org#diff-bWV0YWRhdGEvY29udGV4dC5nbw==) | `61.85% <0.00%> (+3.09%)` | :arrow_up: | | [store/context.go](https://codecov.io/gh/unistack-org/micro/pull/130/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=unistack-org#diff-c3RvcmUvY29udGV4dC5nbw==) | `36.17% <0.00%> (+12.76%)` | :arrow_up: | | [config/context.go](https://codecov.io/gh/unistack-org/micro/pull/130/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=unistack-org#diff-Y29uZmlnL2NvbnRleHQuZ28=) | `100.00% <0.00%> (+17.14%)` | :arrow_up: | | [broker/context.go](https://codecov.io/gh/unistack-org/micro/pull/130/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=unistack-org#diff-YnJva2VyL2NvbnRleHQuZ28=) | `100.00% <0.00%> (+20.68%)` | :arrow_up: | | [client/context.go](https://codecov.io/gh/unistack-org/micro/pull/130/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=unistack-org#diff-Y2xpZW50L2NvbnRleHQuZ28=) | `100.00% <0.00%> (+20.68%)` | :arrow_up: | | ... and [8 more](https://codecov.io/gh/unistack-org/micro/pull/130/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=unistack-org) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/unistack-org/micro/pull/130?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=unistack-org). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=unistack-org) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/unistack-org/micro/pull/130?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=unistack-org). Last update [b433cbc...c26ad51](https://codecov.io/gh/unistack-org/micro/pull/130?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=unistack-org). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=unistack-org).
Sign in to join this conversation.
Reviewers
No Reviewers
github-actions[bot]
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unistack-org/micro#130
No description provided.
Delete Branch "improvements"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?